From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: [PULL 08/11] migration: Print block status when needed
Date: Wed, 18 Oct 2023 12:06:48 +0200 [thread overview]
Message-ID: <20231018100651.32674-9-quintela@redhat.com> (raw)
In-Reply-To: <20231018100651.32674-1-quintela@redhat.com>
The new line was only printed when command options were used. When we
used migration parameters and capabilities, it wasn't.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231017172307.22858-2-quintela@redhat.com>
---
migration/migration-hmp-cmds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index d206700a43..a82597f18e 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -30,6 +30,7 @@
#include "sysemu/runstate.h"
#include "ui/qemu-spice.h"
#include "sysemu/sysemu.h"
+#include "options.h"
#include "migration.h"
static void migration_global_dump(Monitor *mon)
@@ -696,7 +697,6 @@ void hmp_x_colo_lost_heartbeat(Monitor *mon, const QDict *qdict)
typedef struct HMPMigrationStatus {
QEMUTimer *timer;
Monitor *mon;
- bool is_block_migration;
} HMPMigrationStatus;
static void hmp_migrate_status_cb(void *opaque)
@@ -722,7 +722,7 @@ static void hmp_migrate_status_cb(void *opaque)
timer_mod(status->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + 1000);
} else {
- if (status->is_block_migration) {
+ if (migrate_block()) {
monitor_printf(status->mon, "\n");
}
if (info->error_desc) {
@@ -762,7 +762,6 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
status = g_malloc0(sizeof(*status));
status->mon = mon;
- status->is_block_migration = blk || inc;
status->timer = timer_new_ms(QEMU_CLOCK_REALTIME, hmp_migrate_status_cb,
status);
timer_mod(status->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
--
2.41.0
next prev parent reply other threads:[~2023-10-18 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:06 [PULL 00/11] Migration 20231018 patches Juan Quintela
2023-10-18 10:06 ` [PULL 01/11] migration: RDMA is not compatible with anything else Juan Quintela
2023-10-18 10:06 ` [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c Juan Quintela
2023-10-18 10:06 ` [PULL 03/11] migration: Create populate_compress() Juan Quintela
2023-10-18 10:06 ` [PULL 04/11] migration: Create ram_compressed_pages() Juan Quintela
2023-10-18 10:06 ` [PULL 05/11] migration: Move update_compress_threads_counts() to ram-compress.c Juan Quintela
2023-10-18 10:06 ` [PULL 06/11] migration: Simplify decompress_data_with_multi_threads() Juan Quintela
2023-10-18 10:06 ` [PULL 07/11] migration: Use "i" as an for index in ram-compress.c Juan Quintela
2023-10-18 10:06 ` Juan Quintela [this message]
2023-10-18 10:06 ` [PULL 09/11] migration: save_compress_page() can take block through pss Juan Quintela
2023-10-18 10:06 ` [PULL 10/11] migration: control_save_page() " Juan Quintela
2023-10-18 10:06 ` [PULL 11/11] migration: save_zero_page() " Juan Quintela
2023-10-19 18:51 ` [PULL 00/11] Migration 20231018 patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018100651.32674-9-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.