All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-nonmm-stable] minmax-allow-comparisons-of-int-against-unsigned-char-short.patch removed from -mm tree
@ 2023-10-18 21:43 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-10-18 21:43 UTC (permalink / raw)
  To: mm-commits, willy, torvalds, Jason, hch, david.laight,
	andriy.shevchenko, David.Laight, akpm


The quilt patch titled
     Subject: minmax: allow comparisons of 'int' against 'unsigned char/short'
has been removed from the -mm tree.  Its filename was
     minmax-allow-comparisons-of-int-against-unsigned-char-short.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: David Laight <David.Laight@ACULAB.COM>
Subject: minmax: allow comparisons of 'int' against 'unsigned char/short'
Date: Mon, 18 Sep 2023 08:18:40 +0000

Since 'unsigned char/short' get promoted to 'signed int' it is safe to
compare them against an 'int' value.

Link: https://lkml.kernel.org/r/8732ef5f809c47c28a7be47c938b28d4@AcuMS.aculab.com
Signed-off-by: David Laight <david.laight@aculab.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/minmax.h |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/include/linux/minmax.h~minmax-allow-comparisons-of-int-against-unsigned-char-short
+++ a/include/linux/minmax.h
@@ -26,8 +26,9 @@
 	__builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))),	\
 		is_signed_type(typeof(x)), 0)
 
-#define __types_ok(x, y) \
-	(__is_signed(x) == __is_signed(y))
+#define __types_ok(x, y) 			\
+	(__is_signed(x) == __is_signed(y) ||	\
+		__is_signed((x) + 0) == __is_signed((y) + 0))
 
 #define __cmp_op_min <
 #define __cmp_op_max >
_

Patches currently in -mm which might be from David.Laight@ACULAB.COM are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-18 21:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 21:43 [merged mm-nonmm-stable] minmax-allow-comparisons-of-int-against-unsigned-char-short.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.