From: Jakub Kicinski <kuba@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: initialize waitqueues before starting watchdog_task
Date: Fri, 20 Oct 2023 16:51:26 -0700 [thread overview]
Message-ID: <20231020165126.03bb9eff@kernel.org> (raw)
In-Reply-To: <20231019071346.55949-1-mschmidt@redhat.com>
On Thu, 19 Oct 2023 09:13:46 +0200 Michal Schmidt wrote:
> It is not safe to initialize the waitqueues after queueing the
> watchdog_task. It will be using them.
>
> The chance of this causing a real problem is very small, because
> there will be some sleeping before any of the waitqueues get used.
> I got a crash only after inserting an artificial sleep in iavf_probe.
>
> Queue the watchdog_task as the last step in iavf_probe. Add a comment to
> prevent repeating the mistake.
Applied as 7db31110438 in net, thanks!
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: netdev@vger.kernel.org,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net] iavf: initialize waitqueues before starting watchdog_task
Date: Fri, 20 Oct 2023 16:51:26 -0700 [thread overview]
Message-ID: <20231020165126.03bb9eff@kernel.org> (raw)
In-Reply-To: <20231019071346.55949-1-mschmidt@redhat.com>
On Thu, 19 Oct 2023 09:13:46 +0200 Michal Schmidt wrote:
> It is not safe to initialize the waitqueues after queueing the
> watchdog_task. It will be using them.
>
> The chance of this causing a real problem is very small, because
> there will be some sleeping before any of the waitqueues get used.
> I got a crash only after inserting an artificial sleep in iavf_probe.
>
> Queue the watchdog_task as the last step in iavf_probe. Add a comment to
> prevent repeating the mistake.
Applied as 7db31110438 in net, thanks!
next prev parent reply other threads:[~2023-10-20 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:13 [Intel-wired-lan] [PATCH net] iavf: initialize waitqueues before starting watchdog_task Michal Schmidt
2023-10-19 7:13 ` Michal Schmidt
2023-10-19 8:14 ` [Intel-wired-lan] " Paul Menzel
2023-10-19 8:14 ` Paul Menzel
2023-10-19 9:15 ` Przemek Kitszel
2023-10-19 9:15 ` Przemek Kitszel
2023-10-20 23:51 ` Jakub Kicinski [this message]
2023-10-20 23:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020165126.03bb9eff@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.