All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [jcmvbkbc-xtensa:xtensa-6.6-rc6-esp32 35/43] checkpatch: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Date: Sat, 21 Oct 2023 08:32:32 +0800	[thread overview]
Message-ID: <202310210847.TcKu8ocW-lkp@intel.com> (raw)

tree:   https://github.com/jcmvbkbc/linux-xtensa xtensa-6.6-rc6-esp32
head:   7b60fbaf629519456a4de1b76bf9edfb331ffb50
commit: 2003dcbbb2cbe970e845e24fe570ff1d0b5eff49 [35/43] xtensa: add TRAX support
reproduce: (https://download.01.org/0day-ci/archive/20231021/202310210847.TcKu8ocW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310210847.TcKu8ocW-lkp@intel.com/

# many are suggestions rather than must-fix

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#47: FILE: arch/xtensa/include/asm/trax.h:1:
+#ifndef _XTENSA_TRAX_H

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#94: FILE: arch/xtensa/kernel/trax.c:1:
+#include <linux/errno.h>

ERROR:SPACING: spaces required around that '>' (ctx:OxW)
#205: FILE: arch/xtensa/kernel/trax.c:112:
+		for (i = 100; i --> 0; ) {
 		                  ^

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#360: FILE: arch/xtensa/kernel/trax.c:267:
+#if 0

WARNING:BRACES: braces {} are not necessary for single statement blocks
#551: FILE: arch/xtensa/kernel/trax.c:458:
+		if (j % 8 && n - i > 8 - j % 8) {
+			b |= ctx->packet_buffer[j / 8 + 1] << (8 - j % 8);
+		}

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#602: FILE: arch/xtensa/kernel/trax.c:509:
+		return false;
+	} else {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#602: FILE: arch/xtensa/kernel/trax.c:509:
+	} else {
+	    if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets &&

WARNING:TABSTOP: Statements should start on a tabstop
#603: FILE: arch/xtensa/kernel/trax.c:510:
+	    if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets &&

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (12, 20)
#603: FILE: arch/xtensa/kernel/trax.c:510:
+	    if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets &&
[...]
+		    ++ctx->msg_packet;

WARNING:TABSTOP: Statements should start on a tabstop
#606: FILE: arch/xtensa/kernel/trax.c:513:
+		    return true;

WARNING:TABSTOP: Statements should start on a tabstop
#607: FILE: arch/xtensa/kernel/trax.c:514:
+	    } else {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (12, 20)
#607: FILE: arch/xtensa/kernel/trax.c:514:
+	    } else {
+		    ctx->msg.type = TRAX_MSG_TYPE_UNDEF;

WARNING:TABSTOP: Statements should start on a tabstop
#610: FILE: arch/xtensa/kernel/trax.c:517:
+		    return false;

WARNING:TABSTOP: Statements should start on a tabstop
#611: FILE: arch/xtensa/kernel/trax.c:518:
+	    }

WARNING:BRACES: braces {} are not necessary for single statement blocks
#912: FILE: arch/xtensa/kernel/trax.c:819:
+	if (pde) {
+		proc_set_size(pde, trax_state.memsz * 4);
+	}

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-10-21  0:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310210847.TcKu8ocW-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.