From: Andrew Jones <ajones@ventanamicro.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable
Date: Mon, 23 Oct 2023 11:59:26 +0200 [thread overview]
Message-ID: <20231023-8397e25545716f7f168e9007@orel> (raw)
In-Reply-To: <20231004143054.482091-2-cleger@rivosinc.com>
On Wed, Oct 04, 2023 at 04:30:50PM +0200, Cl?ment L?ger wrote:
> For the sake of coherency, use local labels in assembly when
> applicable. This also avoid kprobes being confused when applying a
> kprobe since the size of function is computed by checking where the
> next visible symbol is located. This might end up in computing some
> function size to be way shorter than expected and thus failing to apply
> kprobes to the specified offset.
>
> Signed-off-by: Cl?ment L?ger <cleger@rivosinc.com>
> ---
> arch/riscv/kernel/entry.S | 10 +++----
> arch/riscv/kernel/head.S | 18 ++++++-------
> arch/riscv/kernel/mcount.S | 10 +++----
> arch/riscv/lib/memmove.S | 54 +++++++++++++++++++-------------------
> 4 files changed, 46 insertions(+), 46 deletions(-)
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org
Subject: Re: [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable
Date: Mon, 23 Oct 2023 11:59:26 +0200 [thread overview]
Message-ID: <20231023-8397e25545716f7f168e9007@orel> (raw)
In-Reply-To: <20231004143054.482091-2-cleger@rivosinc.com>
On Wed, Oct 04, 2023 at 04:30:50PM +0200, Clément Léger wrote:
> For the sake of coherency, use local labels in assembly when
> applicable. This also avoid kprobes being confused when applying a
> kprobe since the size of function is computed by checking where the
> next visible symbol is located. This might end up in computing some
> function size to be way shorter than expected and thus failing to apply
> kprobes to the specified offset.
>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
> arch/riscv/kernel/entry.S | 10 +++----
> arch/riscv/kernel/head.S | 18 ++++++-------
> arch/riscv/kernel/mcount.S | 10 +++----
> arch/riscv/lib/memmove.S | 54 +++++++++++++++++++-------------------
> 4 files changed, 46 insertions(+), 46 deletions(-)
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org
Subject: Re: [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable
Date: Mon, 23 Oct 2023 11:59:26 +0200 [thread overview]
Message-ID: <20231023-8397e25545716f7f168e9007@orel> (raw)
In-Reply-To: <20231004143054.482091-2-cleger@rivosinc.com>
On Wed, Oct 04, 2023 at 04:30:50PM +0200, Clément Léger wrote:
> For the sake of coherency, use local labels in assembly when
> applicable. This also avoid kprobes being confused when applying a
> kprobe since the size of function is computed by checking where the
> next visible symbol is located. This might end up in computing some
> function size to be way shorter than expected and thus failing to apply
> kprobes to the specified offset.
>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
> arch/riscv/kernel/entry.S | 10 +++----
> arch/riscv/kernel/head.S | 18 ++++++-------
> arch/riscv/kernel/mcount.S | 10 +++----
> arch/riscv/lib/memmove.S | 54 +++++++++++++++++++-------------------
> 4 files changed, 46 insertions(+), 46 deletions(-)
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
next prev parent reply other threads:[~2023-10-23 9:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 14:30 [PATCH 0/5] riscv: cleanup assembly usage of ENTRY()/END() and use local labels Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-23 9:59 ` Andrew Jones [this message]
2023-10-23 9:59 ` Andrew Jones
2023-10-23 9:59 ` Andrew Jones
2023-10-04 14:30 ` [PATCH 2/5] riscv: Use SYM_*() assembly macros instead of deprecated ones Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-23 9:59 ` Andrew Jones
2023-10-23 9:59 ` Andrew Jones
2023-10-23 9:59 ` Andrew Jones
2023-10-23 10:08 ` Clément Léger
2023-10-23 10:08 ` Clément Léger
2023-10-23 10:08 ` Clément Léger
2023-10-04 14:30 ` [PATCH 3/5] riscv: kernel: Use correct SYM_DATA_*() macro for data Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
2023-10-04 14:30 ` [PATCH 4/5] riscv: kvm: Use SYM_*() assembly macros instead of deprecated ones Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
2023-10-04 14:30 ` [PATCH 5/5] riscv: kvm: use ".L" local labels in assembly when applicable Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-04 14:30 ` Clément Léger
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
2023-10-23 10:03 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023-8397e25545716f7f168e9007@orel \
--to=ajones@ventanamicro.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.