All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert Esteve <aesteve@redhat.com>
To: qemu-devel@nongnu.org
Cc: zackr@vmware.com, contact@emersion.fr, linux-doc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>,
	iforbes@vmware.com,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Chia-I Wu <olvaffe@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Hans de Goede <hdegoede@redhat.com>,
	Matt Roper <matthew.d.roper@intel.com>,
	David Airlie <airlied@gmail.com>,
	banackm@vmware.com, Rob Clark <robdclark@gmail.com>,
	javierm@redhat.com, krastevm@vmware.com,
	spice-devel@lists.freedesktop.org,
	Gurchetan Singh <gurchetansingh@chromium.org>,
	Jonathan Corbet <corbet@lwn.net>,
	David Airlie <airlied@redhat.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, mombasawalam@vmware.com,
	Daniel Vetter <daniel@ffwll.ch>,
	ppaalanen@gmail.com,
	VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes
Date: Mon, 23 Oct 2023 09:46:07 +0200	[thread overview]
Message-ID: <20231023074613.41327-4-aesteve@redhat.com> (raw)
In-Reply-To: <20231023074613.41327-1-aesteve@redhat.com>

From: Zack Rusin <zackr@vmware.com>

Atomic modesetting got support for mouse hotspots via the hotspot
properties. Port the legacy kms hotspot handling to the new properties
on cursor planes.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Cc: Maaz Mombasawala <mombasawalam@vmware.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 818b7f109f538..bea0abc3d4188 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -768,13 +768,8 @@ vmw_du_cursor_plane_atomic_update(struct drm_plane *plane,
 	struct vmw_plane_state *old_vps = vmw_plane_state_to_vps(old_state);
 	s32 hotspot_x, hotspot_y;
 
-	hotspot_x = du->hotspot_x;
-	hotspot_y = du->hotspot_y;
-
-	if (new_state->fb) {
-		hotspot_x += new_state->fb->hot_x;
-		hotspot_y += new_state->fb->hot_y;
-	}
+	hotspot_x = du->hotspot_x + new_state->hotspot_x;
+	hotspot_y = du->hotspot_y + new_state->hotspot_y;
 
 	du->cursor_surface = vps->surf;
 	du->cursor_bo = vps->bo;
-- 
2.41.0


WARNING: multiple messages have this Message-ID (diff)
From: Albert Esteve <aesteve@redhat.com>
To: qemu-devel@nongnu.org
Cc: linux-doc@vger.kernel.org, banackm@vmware.com,
	virtualization@lists.linux-foundation.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	mombasawalam@vmware.com, iforbes@vmware.com,
	Jonathan Corbet <corbet@lwn.net>,
	javierm@redhat.com,
	VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
	David Airlie <airlied@redhat.com>,
	Maxime Ripard <mripard@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	ppaalanen@gmail.com, dri-devel@lists.freedesktop.org,
	spice-devel@lists.freedesktop.org,
	Gurchetan Singh <gurchetansingh@chromium.org>,
	Matt Roper <matthew.d.roper@intel.com>,
	linux-kernel@vger.kernel.org, krastevm@vmware.com,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes
Date: Mon, 23 Oct 2023 09:46:07 +0200	[thread overview]
Message-ID: <20231023074613.41327-4-aesteve@redhat.com> (raw)
In-Reply-To: <20231023074613.41327-1-aesteve@redhat.com>

From: Zack Rusin <zackr@vmware.com>

Atomic modesetting got support for mouse hotspots via the hotspot
properties. Port the legacy kms hotspot handling to the new properties
on cursor planes.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Cc: Maaz Mombasawala <mombasawalam@vmware.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 818b7f109f538..bea0abc3d4188 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -768,13 +768,8 @@ vmw_du_cursor_plane_atomic_update(struct drm_plane *plane,
 	struct vmw_plane_state *old_vps = vmw_plane_state_to_vps(old_state);
 	s32 hotspot_x, hotspot_y;
 
-	hotspot_x = du->hotspot_x;
-	hotspot_y = du->hotspot_y;
-
-	if (new_state->fb) {
-		hotspot_x += new_state->fb->hot_x;
-		hotspot_y += new_state->fb->hot_y;
-	}
+	hotspot_x = du->hotspot_x + new_state->hotspot_x;
+	hotspot_y = du->hotspot_y + new_state->hotspot_y;
 
 	du->cursor_surface = vps->surf;
 	du->cursor_bo = vps->bo;
-- 
2.41.0


  parent reply	other threads:[~2023-10-23  7:46 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  7:46 [PATCH v6 0/9] Fix cursor planes with virtualized drivers Albert Esteve
2023-10-23  7:46 ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 1/9] drm: Disable the cursor plane on atomic contexts " Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:53   ` Simon Ser
2023-10-23  7:53     ` Simon Ser
2023-10-23  7:46 ` [PATCH v6 2/9] drm/atomic: Add support for mouse hotspots Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` Albert Esteve [this message]
2023-10-23  7:46   ` [PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes Albert Esteve
2023-10-23  7:46 ` [PATCH v6 4/9] drm/qxl: " Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 5/9] drm/vboxvideo: " Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 6/9] drm/virtio: " Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 7/9] drm: Remove legacy cursor hotspot code Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 8/9] drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  7:46 ` [PATCH v6 9/9] drm: Introduce documentation for hotspot properties Albert Esteve
2023-10-23  7:46   ` Albert Esteve
2023-10-23  8:23   ` Pekka Paalanen
2023-10-23  8:23     ` Pekka Paalanen
2023-10-23  8:23     ` Pekka Paalanen
2023-10-23 21:29   ` Javier Martinez Canillas
2023-10-23 21:29     ` Javier Martinez Canillas
2023-10-24 19:34     ` Michael Banack
2023-10-24 19:34       ` Michael Banack
2023-10-25  6:36       ` Javier Martinez Canillas
2023-10-25  6:36         ` Javier Martinez Canillas
2023-10-23  7:55 ` [PATCH v6 0/9] Fix cursor planes with virtualized drivers Simon Ser
2023-10-23  7:55   ` Simon Ser
2023-10-23  8:14   ` Albert Esteve
2023-10-23  8:14     ` Albert Esteve
2023-10-23  8:19     ` Simon Ser
2023-10-23  8:19       ` Simon Ser
2023-11-22 12:49     ` Javier Martinez Canillas
2023-11-22 12:49       ` Javier Martinez Canillas
2023-11-23 22:11       ` Simon Ser
2023-11-23 22:11         ` Simon Ser
2023-11-24 10:56         ` Javier Martinez Canillas
2023-11-24 10:56           ` Javier Martinez Canillas
2023-11-24 14:41 ` Javier Martinez Canillas
2023-11-24 14:41   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023074613.41327-4-aesteve@redhat.com \
    --to=aesteve@redhat.com \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=banackm@vmware.com \
    --cc=contact@emersion.fr \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gurchetansingh@chromium.org \
    --cc=hdegoede@redhat.com \
    --cc=iforbes@vmware.com \
    --cc=javierm@redhat.com \
    --cc=krastevm@vmware.com \
    --cc=kraxel@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=mombasawalam@vmware.com \
    --cc=mripard@kernel.org \
    --cc=olvaffe@gmail.com \
    --cc=ppaalanen@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robdclark@gmail.com \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.