From: Denys Dmytriyenko <denis@denix.org>
To: Andrew Davis <afd@ti.com>
Cc: meta-ti@lists.yoctoproject.org, Denys Dmytriyenko <denys@konsulko.com>
Subject: Re: [meta-ti] [master/kirkstone][PATCH 5/5] conf: beagle*: recommend essential FW images for Beagle devices
Date: Mon, 23 Oct 2023 12:56:14 -0400 [thread overview]
Message-ID: <20231023165614.GR2408@denix.org> (raw)
In-Reply-To: <190bcd54-29fd-4c2c-a39e-18e7fe42c4bd@ti.com>
On Mon, Oct 23, 2023 at 10:50:43AM -0500, Andrew Davis wrote:
> On 10/20/23 3:44 PM, Denys Dmytriyenko wrote:
> >From: Denys Dmytriyenko <denys@konsulko.com>
> >
> >Set MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS per platform to list recommended
> >essential FW images to be added to rootfs by default.
> >
> >Correct beagle-x15 to pull devicetrees and kernel image as well.
> >
>
> Would it be better to have the bb.org kernel pull in `kernel-rdepends.inc` like
> the other kernels and get all these RDEPENDS/RRECOMMENDS from that?
No, I was actually working on the opposite - moving those to corresponding
machine/SoC configs and removing kernel-rdepends.inc
MACHINE_ESSENTIAL_EXTRA_RDEPENDS and MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS are
a proper way to express such dependencies for things like FW images to be
pulled into an image, instead of making kernel RDEPENDS on them. And it is
not specific to a particular kernel, so you don't need to keep including that
kernel-rdepends.inc from every kernel recipe.
> >Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >---
> > meta-ti-bsp/conf/machine/beagle-x15.conf | 2 ++
> > meta-ti-bsp/conf/machine/beaglebone-ai64.conf | 3 +++
> > meta-ti-bsp/conf/machine/beaglebone.conf | 2 ++
> > meta-ti-bsp/conf/machine/beagleplay.conf | 3 +++
> > 4 files changed, 10 insertions(+)
> >
> >diff --git a/meta-ti-bsp/conf/machine/beagle-x15.conf b/meta-ti-bsp/conf/machine/beagle-x15.conf
> >index be27705c..3b857165 100644
> >--- a/meta-ti-bsp/conf/machine/beagle-x15.conf
> >+++ b/meta-ti-bsp/conf/machine/beagle-x15.conf
> >@@ -19,3 +19,5 @@ MACHINE_GUI_CLASS = "bigscreen"
> > SERIAL_CONSOLES = "115200;ttyS2"
> > UBOOT_MACHINE = "am57xx_evm_config"
> >+
> >+MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-zimage"
> >diff --git a/meta-ti-bsp/conf/machine/beaglebone-ai64.conf b/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >index 2f9c7288..3f5a027e 100644
> >--- a/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >+++ b/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >@@ -24,4 +24,7 @@ ti/k3-j721e-sk.dtb \
> > "
> > MACHINE_GUI_CLASS = "bigscreen"
> >+
> > MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-image"
> >+
> >+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw vxd-dec-fw"
> >diff --git a/meta-ti-bsp/conf/machine/beaglebone.conf b/meta-ti-bsp/conf/machine/beaglebone.conf
> >index 2d811d0d..45944ce8 100644
> >--- a/meta-ti-bsp/conf/machine/beaglebone.conf
> >+++ b/meta-ti-bsp/conf/machine/beaglebone.conf
> >@@ -23,3 +23,5 @@ MACHINE_FEATURES += "screen"
> > SERIAL_CONSOLES = "115200;ttyS0"
> > MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-zimage"
> >+
> >+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "amx3-cm3"
> >diff --git a/meta-ti-bsp/conf/machine/beagleplay.conf b/meta-ti-bsp/conf/machine/beagleplay.conf
> >index 6a0f697f..4dd550a1 100644
> >--- a/meta-ti-bsp/conf/machine/beagleplay.conf
> >+++ b/meta-ti-bsp/conf/machine/beagleplay.conf
> >@@ -42,4 +42,7 @@ ti/k3-am625-sk-rpi-hdr-pwm.dtbo \
> > "
> > MACHINE_GUI_CLASS = "bigscreen"
> >+
> > MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-image"
> >+
> >+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += ""
next prev parent reply other threads:[~2023-10-23 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 20:44 [master/kirkstone][PATCH 1/5] conf: beaglebone-ai64: trim down the DTB list Denys Dmytriyenko
2023-10-20 20:44 ` [master/kirkstone][PATCH 2/5] conf: beagleplay: " Denys Dmytriyenko
2023-10-20 20:44 ` [master/kirkstone][PATCH 3/5] linux-bb.org: update kernel to 6.1 for Beagle devices Denys Dmytriyenko
2023-10-23 15:53 ` [meta-ti] " Ryan Eatmon
2023-10-23 19:19 ` Denys Dmytriyenko
2023-10-23 20:24 ` Ryan Eatmon
2023-10-20 20:44 ` [master/kirkstone][PATCH 4/5] u-boot-bb.org: add back Beagle-specific U-boot 2023.04 Denys Dmytriyenko
2023-10-20 20:44 ` [master/kirkstone][PATCH 5/5] conf: beagle*: recommend essential FW images for Beagle devices Denys Dmytriyenko
2023-10-23 15:50 ` [meta-ti] " Andrew Davis
2023-10-23 15:52 ` Ryan Eatmon
2023-10-23 16:56 ` Denys Dmytriyenko
2023-10-23 16:56 ` Denys Dmytriyenko [this message]
2023-10-23 17:18 ` Andrew Davis
2023-10-23 19:03 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023165614.GR2408@denix.org \
--to=denis@denix.org \
--cc=afd@ti.com \
--cc=denys@konsulko.com \
--cc=meta-ti@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.