Re: [meta-ti] [master/kirkstone][PATCH 5/5] conf: beagle*: recommend essential FW images for Beagle devices

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Oct 23, 2023 at 12:18:18PM -0500, Andrew Davis wrote:
> On 10/23/23 11:56 AM, Denys Dmytriyenko wrote:
> >On Mon, Oct 23, 2023 at 10:50:43AM -0500, Andrew Davis wrote:
> >>On 10/20/23 3:44 PM, Denys Dmytriyenko wrote:
> >>>From: Denys Dmytriyenko <denys@konsulko.com>
> >>>
> >>>Set MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS per platform to list recommended
> >>>essential FW images to be added to rootfs by default.
> >>>
> >>>Correct beagle-x15 to pull devicetrees and kernel image as well.
> >>>
> >>
> >>Would it be better to have the bb.org kernel pull in `kernel-rdepends.inc` like
> >>the other kernels and get all these RDEPENDS/RRECOMMENDS from that?
> >
> >No, I was actually working on the opposite - moving those to corresponding
> >machine/SoC configs and removing kernel-rdepends.inc
> >
> >MACHINE_ESSENTIAL_EXTRA_RDEPENDS and MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS are
> >a proper way to express such dependencies for things like FW images to be
> >pulled into an image, instead of making kernel RDEPENDS on them. And it is
> >not specific to a particular kernel, so you don't need to keep including that
> >kernel-rdepends.inc from every kernel recipe.
> >
> 
> If you are going to do it this way for all platforms, then you should
> be able to do this in the machine/include/*.inc files vs out here
> in each and every machine.

Yes, that's what I said above - "corresponding machine/SoC configs".
See the RFC patch I just sent to the list a bit earlier.


> So my question would be, if this is the right
> direction, why only the Beagle plats in this patch?

The main reason was Ravi's multiple revisions trying to remove PRU Eth 
firmware images from kernel-rdepends.inc - didn't want to step over that and 
require even more iterations... Now that it is dropped, this is no longer a 
blocker.


> >>>Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >>>---
> >>>  meta-ti-bsp/conf/machine/beagle-x15.conf      | 2 ++
> >>>  meta-ti-bsp/conf/machine/beaglebone-ai64.conf | 3 +++
> >>>  meta-ti-bsp/conf/machine/beaglebone.conf      | 2 ++
> >>>  meta-ti-bsp/conf/machine/beagleplay.conf      | 3 +++
> >>>  4 files changed, 10 insertions(+)
> >>>
> >>>diff --git a/meta-ti-bsp/conf/machine/beagle-x15.conf b/meta-ti-bsp/conf/machine/beagle-x15.conf
> >>>index be27705c..3b857165 100644
> >>>--- a/meta-ti-bsp/conf/machine/beagle-x15.conf
> >>>+++ b/meta-ti-bsp/conf/machine/beagle-x15.conf
> >>>@@ -19,3 +19,5 @@ MACHINE_GUI_CLASS = "bigscreen"
> >>>  SERIAL_CONSOLES = "115200;ttyS2"
> >>>  UBOOT_MACHINE = "am57xx_evm_config"
> >>>+
> >>>+MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-zimage"
> >>>diff --git a/meta-ti-bsp/conf/machine/beaglebone-ai64.conf b/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >>>index 2f9c7288..3f5a027e 100644
> >>>--- a/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >>>+++ b/meta-ti-bsp/conf/machine/beaglebone-ai64.conf
> >>>@@ -24,4 +24,7 @@ ti/k3-j721e-sk.dtb \
> >>>  "
> >>>  MACHINE_GUI_CLASS = "bigscreen"
> >>>+
> >>>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-image"
> >>>+
> >>>+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw vxd-dec-fw"
> >>>diff --git a/meta-ti-bsp/conf/machine/beaglebone.conf b/meta-ti-bsp/conf/machine/beaglebone.conf
> >>>index 2d811d0d..45944ce8 100644
> >>>--- a/meta-ti-bsp/conf/machine/beaglebone.conf
> >>>+++ b/meta-ti-bsp/conf/machine/beaglebone.conf
> >>>@@ -23,3 +23,5 @@ MACHINE_FEATURES += "screen"
> >>>  SERIAL_CONSOLES = "115200;ttyS0"
> >>>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-zimage"
> >>>+
> >>>+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "amx3-cm3"
> >>>diff --git a/meta-ti-bsp/conf/machine/beagleplay.conf b/meta-ti-bsp/conf/machine/beagleplay.conf
> >>>index 6a0f697f..4dd550a1 100644
> >>>--- a/meta-ti-bsp/conf/machine/beagleplay.conf
> >>>+++ b/meta-ti-bsp/conf/machine/beagleplay.conf
> >>>@@ -42,4 +42,7 @@ ti/k3-am625-sk-rpi-hdr-pwm.dtbo \
> >>>  "
> >>>  MACHINE_GUI_CLASS = "bigscreen"
> >>>+
> >>>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-devicetree kernel-image-image"
> >>>+
> >>>+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += ""