From: Alex Henrie <alexhenrie24@gmail.com>
To: netdev@vger.kernel.org, jbohac@suse.cz,
benoit.boissinot@ens-lyon.org, davem@davemloft.net,
hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org,
pabeni@redhat.com, kuba@kernel.org
Cc: Alex Henrie <alexhenrie24@gmail.com>
Subject: [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed
Date: Tue, 24 Oct 2023 15:23:07 -0600 [thread overview]
Message-ID: <20231024212312.299370-2-alexhenrie24@gmail.com> (raw)
In-Reply-To: <20231024212312.299370-1-alexhenrie24@gmail.com>
Without this patch, there is nothing to stop the preferred lifetime of a
temporary address from being greater than its valid lifetime. If that
was the case, the valid lifetime was effectively ignored.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
net/ipv6/addrconf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index c2d471ad7922..26aedaab3647 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1399,6 +1399,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
idev->cnf.temp_valid_lft + age);
cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor;
cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft);
+ cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft);
cfg.plen = ifp->prefix_len;
tmp_tstamp = ifp->tstamp;
--
2.42.0
next prev parent reply other threads:[~2023-10-24 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 21:23 [PATCH net-next v2 0/4] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are in the valid range Alex Henrie
2023-10-24 21:23 ` Alex Henrie [this message]
2023-10-25 12:23 ` [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Jiri Pirko
2023-10-25 16:28 ` Alex Henrie
2023-10-26 5:11 ` Jiri Pirko
2023-10-26 0:41 ` David Ahern
2023-10-24 21:23 ` [PATCH net-next v2 2/4] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2023-10-25 12:25 ` Jiri Pirko
2023-10-26 0:43 ` David Ahern
2023-10-24 21:23 ` [PATCH net-next v2 3/4] Documentation: networking: explain what happens if temp_valid_lft is too small Alex Henrie
2023-10-26 0:43 ` David Ahern
2023-10-24 21:23 ` [PATCH net-next v2 4/4] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Alex Henrie
2023-10-26 0:44 ` David Ahern
2023-10-26 1:30 ` [PATCH net-next v2 0/4] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are in the valid range patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024212312.299370-2-alexhenrie24@gmail.com \
--to=alexhenrie24@gmail.com \
--cc=benoit.boissinot@ens-lyon.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=jbohac@suse.cz \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.