Re: [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed

[Jiri Pirko <jiri@resnulli.us>]

Tue, Oct 24, 2023 at 11:23:07PM CEST, alexhenrie24@gmail.com wrote:
>Without this patch, there is nothing to stop the preferred lifetime of a
>temporary address from being greater than its valid lifetime. If that
>was the case, the valid lifetime was effectively ignored.
>

Sounds like a bugfix, correct? In that case, could you please
provide a proper Fixes tag and target -net tree?


>Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
>---
> net/ipv6/addrconf.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>index c2d471ad7922..26aedaab3647 100644
>--- a/net/ipv6/addrconf.c
>+++ b/net/ipv6/addrconf.c
>@@ -1399,6 +1399,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
> 			      idev->cnf.temp_valid_lft + age);
> 	cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor;
> 	cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft);
>+	cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft);
> 
> 	cfg.plen = ifp->prefix_len;
> 	tmp_tstamp = ifp->tstamp;
>-- 
>2.42.0
>
>