From: Jason Gunthorpe <jgg@ziepe.ca>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: oe-kbuild-all@lists.linux.dev, kernel test robot <lkp@intel.com>,
Yi Liu <yi.l.liu@intel.com>
Subject: Re: [jgg-iommufd:for-next 36/39] drivers/iommu/iommufd/hw_pagetable.c:101: warning: Function parameter or member 'user_data' not described in 'iommufd_hwpt_paging_alloc'
Date: Tue, 24 Oct 2023 20:09:13 -0300 [thread overview]
Message-ID: <20231024230913.GN691768@ziepe.ca> (raw)
In-Reply-To: <ZTgosVlGp/H/k6pd@Asurada-Nvidia>
On Tue, Oct 24, 2023 at 01:27:29PM -0700, Nicolin Chen wrote:
> I think we forgot to add this:
>
> ----------------------------------
> diff --git a/drivers/iommu/iommufd/hw_pagetable.c b/drivers/iommu/iommufd/hw_pagetable.c
> index 6e11693617a0..358708973cd7 100644
> --- a/drivers/iommu/iommufd/hw_pagetable.c
> +++ b/drivers/iommu/iommufd/hw_pagetable.c
> @@ -84,6 +84,7 @@ iommufd_hwpt_paging_enforce_cc(struct iommufd_hwpt_paging *hwpt_paging)
> * @idev: Device to get an iommu_domain for
> * @flags: Flags from userspace
> * @immediate_attach: True if idev should be attached to the hwpt
> + * @user_data: Optional user_data pointer
> *
> * Allocate a new iommu_domain and return it as a hw_pagetable. The HWPT
> * will be linked to the given ioas and upon return the underlying iommu_domain
> ----------------------------------
Okay I fixed it
Thanks,
Jason
prev parent reply other threads:[~2023-10-24 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 20:21 [jgg-iommufd:for-next 36/39] drivers/iommu/iommufd/hw_pagetable.c:101: warning: Function parameter or member 'user_data' not described in 'iommufd_hwpt_paging_alloc' kernel test robot
2023-10-24 20:27 ` Nicolin Chen
2023-10-24 23:09 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024230913.GN691768@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=lkp@intel.com \
--cc=nicolinc@nvidia.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.