Re: [jgg-iommufd:for-next 36/39] drivers/iommu/iommufd/hw_pagetable.c:101: warning: Function parameter or member 'user_data' not described in 'iommufd_hwpt_paging_alloc'

[Nicolin Chen <nicolinc@nvidia.com>]

Hi Jason,

On Wed, Oct 25, 2023 at 04:21:08AM +0800, kernel test robot wrote:

> >> drivers/iommu/iommufd/hw_pagetable.c:101: warning: Function parameter or member 'user_data' not described in 'iommufd_hwpt_paging_alloc'
> 
> 
> vim +101 drivers/iommu/iommufd/hw_pagetable.c
> 
> 17bad52708b457 Jason Gunthorpe 2023-07-17   79
> ea4acfac57b9de Jason Gunthorpe 2022-11-29   80  /**
> 3bc7f01ff2de6b Nicolin Chen    2023-10-24   81   * iommufd_hwpt_paging_alloc() - Get a PAGING iommu_domain for a device
> ea4acfac57b9de Jason Gunthorpe 2022-11-29   82   * @ictx: iommufd context
> ea4acfac57b9de Jason Gunthorpe 2022-11-29   83   * @ioas: IOAS to associate the domain with
> 339fbf3ae14426 Jason Gunthorpe 2023-03-01   84   * @idev: Device to get an iommu_domain for
> 89d63875d80ea1 Yi Liu          2023-09-28   85   * @flags: Flags from userspace
> 339fbf3ae14426 Jason Gunthorpe 2023-03-01   86   * @immediate_attach: True if idev should be attached to the hwpt
> ea4acfac57b9de Jason Gunthorpe 2022-11-29   87   *
> 339fbf3ae14426 Jason Gunthorpe 2023-03-01   88   * Allocate a new iommu_domain and return it as a hw_pagetable. The HWPT
> 339fbf3ae14426 Jason Gunthorpe 2023-03-01   89   * will be linked to the given ioas and upon return the underlying iommu_domain
> 339fbf3ae14426 Jason Gunthorpe 2023-03-01   90   * is fully popoulated.
> 70eadc7fc7ef29 Jason Gunthorpe 2023-07-17   91   *
> 70eadc7fc7ef29 Jason Gunthorpe 2023-07-17   92   * The caller must hold the ioas->mutex until after
> 70eadc7fc7ef29 Jason Gunthorpe 2023-07-17   93   * iommufd_object_abort_and_destroy() or iommufd_object_finalize() is called on
> 70eadc7fc7ef29 Jason Gunthorpe 2023-07-17   94   * the returned hwpt.
> ea4acfac57b9de Jason Gunthorpe 2022-11-29   95   */
> 3bc7f01ff2de6b Nicolin Chen    2023-10-24   96  struct iommufd_hwpt_paging *
> 3bc7f01ff2de6b Nicolin Chen    2023-10-24   97  iommufd_hwpt_paging_alloc(struct iommufd_ctx *ictx, struct iommufd_ioas *ioas,
> 89d63875d80ea1 Yi Liu          2023-09-28   98                            struct iommufd_device *idev, u32 flags,
> a6f4f0247d4e7b Nicolin Chen    2023-10-24   99                            bool immediate_attach,
> a6f4f0247d4e7b Nicolin Chen    2023-10-24  100                            const struct iommu_user_data *user_data)

I think we forgot to add this:

----------------------------------
diff --git a/drivers/iommu/iommufd/hw_pagetable.c b/drivers/iommu/iommufd/hw_pagetable.c
index 6e11693617a0..358708973cd7 100644
--- a/drivers/iommu/iommufd/hw_pagetable.c
+++ b/drivers/iommu/iommufd/hw_pagetable.c
@@ -84,6 +84,7 @@ iommufd_hwpt_paging_enforce_cc(struct iommufd_hwpt_paging *hwpt_paging)
  * @idev: Device to get an iommu_domain for
  * @flags: Flags from userspace
  * @immediate_attach: True if idev should be attached to the hwpt
+ * @user_data: Optional user_data pointer
  *
  * Allocate a new iommu_domain and return it as a hw_pagetable. The HWPT
  * will be linked to the given ioas and upon return the underlying iommu_domain
----------------------------------

Thanks
Nic