All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all
@ 2023-10-16 11:22 Quentin Schulz
  2023-10-16 15:27 ` [yocto] Using cmake... how? Dave Hitchman
  2023-10-25 13:43 ` [yocto] [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all Trevor Woerner
  0 siblings, 2 replies; 16+ messages in thread
From: Quentin Schulz @ 2023-10-16 11:22 UTC (permalink / raw)
  To: twoerner; +Cc: yocto, Quentin Schulz, Quentin Schulz

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

The goal of the default COMPATIBLE_MACHINE was to not allow
rockchip-rkbin to be even parsed if a MACHINE isn't part of the
COMPATIBLE_MACHINE.

However, COMPATIBLE_MACHINE is a regexp checked using Python's re module
approximately like:
"""
if re.match(COMPATIBLE_MACHINE, MACHINE):
	return True
"""

and re.match() returns a match whatever MACHINE is if COMPATIBLE_MACHINE
is the empty string.

Therefore, let's change it to `^$` which only matches the empty string,
which shouldn't be possible for anything in MACHINEOVERRIDES, and if it
is there are probably bigger problems than parsing rockchip-rkbin.

Fixes: 3c7f532c2e25 ("rk3588(s): add")
Cc: Quentin Schulz <foss+yocto@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 recipes-bsp/rkbin/rockchip-rkbin_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb
index 7fefb01..f9e680d 100644
--- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb
+++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb
@@ -12,7 +12,7 @@ inherit bin_package deploy
 
 S = "${WORKDIR}/git"
 
-COMPATIBLE_MACHINE = ""
+COMPATIBLE_MACHINE = "^$"
 COMPATIBLE_MACHINE:rk3588s = "rk3588s"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-10-25 13:43 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 11:22 [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all Quentin Schulz
2023-10-16 15:27 ` [yocto] Using cmake... how? Dave Hitchman
2023-10-16 19:48   ` Khem Raj
2023-10-17  5:49   ` Mikko Rapeli
2023-10-17  9:21     ` Dave Hitchman
2023-10-17  9:52       ` Mikko Rapeli
2023-10-17 10:09         ` Dave Hitchman
2023-10-17 10:22           ` Mikko Rapeli
2023-10-17 11:35             ` Dave Hitchman
2023-10-17 11:42               ` Mikko Rapeli
2023-10-17 11:53               ` Mikko Rapeli
2023-10-17 11:58                 ` Dave Hitchman
2023-10-17 12:23                   ` Mikko Rapeli
2023-10-17 13:32                   ` Ross Burton
2023-10-17 15:18                     ` Dave Hitchman
2023-10-25 13:43 ` [yocto] [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all Trevor Woerner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.