* [broonie-sound:for-next 45/75] sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast
@ 2023-10-27 5:11 kernel test robot
2023-10-27 6:18 ` syed saba kareem
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-10-27 5:11 UTC (permalink / raw)
To: Syed Saba Kareem; +Cc: oe-kbuild-all, Mark Brown
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
head: 00236a89602f7b67016bd1d9bc63079f2c0f0a8d
commit: 3a94c8ad0aae2b14a55059869871ea2d199af489 [45/75] ASoC: amd: acp: add code for scanning acp pdm controller
config: i386-buildonly-randconfig-001-20231027 (https://download.01.org/0day-ci/archive/20231027/202310271326.7xKHbFDH-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310271326.7xKHbFDH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310271326.7xKHbFDH-lkp@intel.com/
All warnings (new ones prefixed by >>):
sound/soc/amd/acp/acp-legacy-common.c: In function 'check_acp_pdm':
sound/soc/amd/acp/acp-legacy-common.c:392:19: error: implicit declaration of function 'acpi_find_child_device'; did you mean 'acpi_match_device'? [-Werror=implicit-function-declaration]
392 | pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
| ^~~~~~~~~~~~~~~~~~~~~~
| acpi_match_device
>> sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
392 | pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
| ^
cc1: some warnings being treated as errors
vim +392 sound/soc/amd/acp/acp-legacy-common.c
354
355 int check_acp_pdm(struct pci_dev *pci, struct acp_chip_info *chip)
356 {
357 struct acpi_device *pdm_dev;
358 const union acpi_object *obj;
359 u32 pdm_addr, val;
360
361 val = readl(chip->base + ACP_PIN_CONFIG);
362 switch (val) {
363 case ACP_CONFIG_4:
364 case ACP_CONFIG_5:
365 case ACP_CONFIG_6:
366 case ACP_CONFIG_7:
367 case ACP_CONFIG_8:
368 case ACP_CONFIG_10:
369 case ACP_CONFIG_11:
370 case ACP_CONFIG_12:
371 case ACP_CONFIG_13:
372 case ACP_CONFIG_14:
373 break;
374 default:
375 return -EINVAL;
376 }
377
378 switch (chip->acp_rev) {
379 case ACP3X_DEV:
380 pdm_addr = ACP_RENOIR_PDM_ADDR;
381 break;
382 case ACP6X_DEV:
383 pdm_addr = ACP_REMBRANDT_PDM_ADDR;
384 break;
385 case ACP63_DEV:
386 pdm_addr = ACP63_PDM_ADDR;
387 break;
388 default:
389 return -EINVAL;
390 }
391
> 392 pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
393 if (pdm_dev) {
394 if (!acpi_dev_get_property(pdm_dev, "acp-audio-device-type",
395 ACPI_TYPE_INTEGER, &obj) &&
396 obj->integer.value == pdm_addr)
397 return 0;
398 }
399 return -ENODEV;
400 }
401 EXPORT_SYMBOL_NS_GPL(check_acp_pdm, SND_SOC_ACP_COMMON);
402
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [broonie-sound:for-next 45/75] sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast
2023-10-27 5:11 [broonie-sound:for-next 45/75] sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast kernel test robot
@ 2023-10-27 6:18 ` syed saba kareem
0 siblings, 0 replies; 2+ messages in thread
From: syed saba kareem @ 2023-10-27 6:18 UTC (permalink / raw)
To: kernel test robot, Syed Saba Kareem; +Cc: oe-kbuild-all, Mark Brown
On 10/27/23 10:41, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> head: 00236a89602f7b67016bd1d9bc63079f2c0f0a8d
> commit: 3a94c8ad0aae2b14a55059869871ea2d199af489 [45/75] ASoC: amd: acp: add code for scanning acp pdm controller
> config: i386-buildonly-randconfig-001-20231027 (https://download.01.org/0day-ci/archive/20231027/202310271326.7xKHbFDH-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310271326.7xKHbFDH-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310271326.7xKHbFDH-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> sound/soc/amd/acp/acp-legacy-common.c: In function 'check_acp_pdm':
> sound/soc/amd/acp/acp-legacy-common.c:392:19: error: implicit declaration of function 'acpi_find_child_device'; did you mean 'acpi_match_device'? [-Werror=implicit-function-declaration]
Will fix it.
> 392 | pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
> | ^~~~~~~~~~~~~~~~~~~~~~
> | acpi_match_device
>>> sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 392 | pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
> | ^
> cc1: some warnings being treated as errors
>
>
> vim +392 sound/soc/amd/acp/acp-legacy-common.c
>
> 354
> 355 int check_acp_pdm(struct pci_dev *pci, struct acp_chip_info *chip)
> 356 {
> 357 struct acpi_device *pdm_dev;
> 358 const union acpi_object *obj;
> 359 u32 pdm_addr, val;
> 360
> 361 val = readl(chip->base + ACP_PIN_CONFIG);
> 362 switch (val) {
> 363 case ACP_CONFIG_4:
> 364 case ACP_CONFIG_5:
> 365 case ACP_CONFIG_6:
> 366 case ACP_CONFIG_7:
> 367 case ACP_CONFIG_8:
> 368 case ACP_CONFIG_10:
> 369 case ACP_CONFIG_11:
> 370 case ACP_CONFIG_12:
> 371 case ACP_CONFIG_13:
> 372 case ACP_CONFIG_14:
> 373 break;
> 374 default:
> 375 return -EINVAL;
> 376 }
> 377
> 378 switch (chip->acp_rev) {
> 379 case ACP3X_DEV:
> 380 pdm_addr = ACP_RENOIR_PDM_ADDR;
> 381 break;
> 382 case ACP6X_DEV:
> 383 pdm_addr = ACP_REMBRANDT_PDM_ADDR;
> 384 break;
> 385 case ACP63_DEV:
> 386 pdm_addr = ACP63_PDM_ADDR;
> 387 break;
> 388 default:
> 389 return -EINVAL;
> 390 }
> 391
> > 392 pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
> 393 if (pdm_dev) {
> 394 if (!acpi_dev_get_property(pdm_dev, "acp-audio-device-type",
> 395 ACPI_TYPE_INTEGER, &obj) &&
> 396 obj->integer.value == pdm_addr)
> 397 return 0;
> 398 }
> 399 return -ENODEV;
> 400 }
> 401 EXPORT_SYMBOL_NS_GPL(check_acp_pdm, SND_SOC_ACP_COMMON);
> 402
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 6:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 5:11 [broonie-sound:for-next 45/75] sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast kernel test robot
2023-10-27 6:18 ` syed saba kareem
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.