[android-common:android12-5.4-lts 13548/29903] drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer

[android-common:android12-5.4-lts 13548/29903] drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer

[kernel test robot]

tree:   https://android.googlesource.com/kernel/common android12-5.4-lts
head:   fcdc8d9a71cdda01c736bb52ad5d494e5b0937a3
commit: bb3980554f05c633bc76fd7e4b6d054a85be460d [13548/29903] ANDROID: usb: f_accessory: Avoid bitfields for shared variables
config: x86_64-randconfig-122-20231027 (https://download.01.org/0day-ci/archive/20231027/202310271828.Xo7v5TtJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310271828.Xo7v5TtJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310271828.Xo7v5TtJ-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:702:35: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:722:23: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:758:23: sparse: sparse: Using plain integer as NULL pointer
>> drivers/usb/gadget/function/f_accessory.c:1408:5: sparse: sparse: symbol 'acc_ctrlrequest_configfs' was not declared. Should it be static?

vim +295 drivers/usb/gadget/function/f_accessory.c

483cb5629ea789 Benoit Goby 2011-12-19  286  
483cb5629ea789 Benoit Goby 2011-12-19  287  /* remove a request from the head of a list */
483cb5629ea789 Benoit Goby 2011-12-19  288  static struct usb_request *req_get(struct acc_dev *dev, struct list_head *head)
483cb5629ea789 Benoit Goby 2011-12-19  289  {
483cb5629ea789 Benoit Goby 2011-12-19  290  	unsigned long flags;
483cb5629ea789 Benoit Goby 2011-12-19  291  	struct usb_request *req;
483cb5629ea789 Benoit Goby 2011-12-19  292  
483cb5629ea789 Benoit Goby 2011-12-19  293  	spin_lock_irqsave(&dev->lock, flags);
483cb5629ea789 Benoit Goby 2011-12-19  294  	if (list_empty(head)) {
483cb5629ea789 Benoit Goby 2011-12-19 @295  		req = 0;
483cb5629ea789 Benoit Goby 2011-12-19  296  	} else {
483cb5629ea789 Benoit Goby 2011-12-19  297  		req = list_first_entry(head, struct usb_request, list);
483cb5629ea789 Benoit Goby 2011-12-19  298  		list_del(&req->list);
483cb5629ea789 Benoit Goby 2011-12-19  299  	}
483cb5629ea789 Benoit Goby 2011-12-19  300  	spin_unlock_irqrestore(&dev->lock, flags);
483cb5629ea789 Benoit Goby 2011-12-19  301  	return req;
483cb5629ea789 Benoit Goby 2011-12-19  302  }
483cb5629ea789 Benoit Goby 2011-12-19  303  

:::::: The code at line 295 was first introduced by commit
:::::: 483cb5629ea7893f94481511e630ae14a5c0d1c0 ANDROID: usb: gadget: f_accessory: Add Android Accessory function

:::::: TO: Benoit Goby <benoit@android.com>
:::::: CC: Todd Kjos <tkjos@google.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki