All of lore.kernel.org
 help / color / mirror / Atom feed
* [linyunsheng:page_frag_unify_rfc 2/4] net/core/skbuff.c:301:15: error: '__napi_alloc_frag_align' undeclared here (not in a function); did you mean 'napi_alloc_frag_align'?
@ 2023-10-28 18:50 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-10-28 18:50 UTC (permalink / raw)
  To: Yunsheng Lin; +Cc: oe-kbuild-all

tree:   https://github.com/gestionlin/linux.git page_frag_unify_rfc
head:   7675d2f57391bcfccc739671a7b3b2a40acfc595
commit: 1ec6b07022b1485c830aa4c58fd4154ba67306cf [2/4] mm/page_alloc: modify page_frag_alloc_align() to accept align as an argument
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20231029/202310290202.89YaW5CS-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290202.89YaW5CS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310290202.89YaW5CS-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/linkage.h:7,
                    from include/linux/kernel.h:17,
                    from include/linux/cpumask.h:10,
                    from include/linux/mm_types_task.h:14,
                    from include/linux/mm_types.h:5,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from net/core/skbuff.c:37:
>> net/core/skbuff.c:301:15: error: '__napi_alloc_frag_align' undeclared here (not in a function); did you mean 'napi_alloc_frag_align'?
     301 | EXPORT_SYMBOL(__napi_alloc_frag_align);
         |               ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/export.h:74:23: note: in definition of macro '__EXPORT_SYMBOL'
      74 |         extern typeof(sym) sym;                                 \
         |                       ^~~
   include/linux/export.h:86:41: note: in expansion of macro '_EXPORT_SYMBOL'
      86 | #define EXPORT_SYMBOL(sym)              _EXPORT_SYMBOL(sym, "")
         |                                         ^~~~~~~~~~~~~~
   net/core/skbuff.c:301:1: note: in expansion of macro 'EXPORT_SYMBOL'
     301 | EXPORT_SYMBOL(__napi_alloc_frag_align);
         | ^~~~~~~~~~~~~
>> net/core/skbuff.c:322:15: error: '__netdev_alloc_frag_align' undeclared here (not in a function); did you mean 'netdev_alloc_frag_align'?
     322 | EXPORT_SYMBOL(__netdev_alloc_frag_align);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/export.h:74:23: note: in definition of macro '__EXPORT_SYMBOL'
      74 |         extern typeof(sym) sym;                                 \
         |                       ^~~
   include/linux/export.h:86:41: note: in expansion of macro '_EXPORT_SYMBOL'
      86 | #define EXPORT_SYMBOL(sym)              _EXPORT_SYMBOL(sym, "")
         |                                         ^~~~~~~~~~~~~~
   net/core/skbuff.c:322:1: note: in expansion of macro 'EXPORT_SYMBOL'
     322 | EXPORT_SYMBOL(__netdev_alloc_frag_align);
         | ^~~~~~~~~~~~~


vim +301 net/core/skbuff.c

dbae2b062824fc Paolo Abeni       2022-09-28  292  
1ec6b07022b148 Yunsheng Lin      2023-10-28  293  void *napi_alloc_frag_align(unsigned int fragsz, unsigned int align)
50fad4b543b30e Alexander Lobakin 2021-02-13  294  {
50fad4b543b30e Alexander Lobakin 2021-02-13  295  	struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
50fad4b543b30e Alexander Lobakin 2021-02-13  296  
50fad4b543b30e Alexander Lobakin 2021-02-13  297  	fragsz = SKB_DATA_ALIGN(fragsz);
50fad4b543b30e Alexander Lobakin 2021-02-13  298  
1ec6b07022b148 Yunsheng Lin      2023-10-28  299  	return page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13  300  }
50fad4b543b30e Alexander Lobakin 2021-02-13 @301  EXPORT_SYMBOL(__napi_alloc_frag_align);
50fad4b543b30e Alexander Lobakin 2021-02-13  302  
1ec6b07022b148 Yunsheng Lin      2023-10-28  303  void *netdev_alloc_frag_align(unsigned int fragsz, unsigned int align)
50fad4b543b30e Alexander Lobakin 2021-02-13  304  {
50fad4b543b30e Alexander Lobakin 2021-02-13  305  	void *data;
50fad4b543b30e Alexander Lobakin 2021-02-13  306  
50fad4b543b30e Alexander Lobakin 2021-02-13  307  	fragsz = SKB_DATA_ALIGN(fragsz);
afa79d08c6c8e1 Changbin Du       2021-08-13  308  	if (in_hardirq() || irqs_disabled()) {
32e3573f739209 Yajun Deng        2021-09-14  309  		struct page_frag_cache *nc = this_cpu_ptr(&netdev_alloc_cache);
32e3573f739209 Yajun Deng        2021-09-14  310  
1ec6b07022b148 Yunsheng Lin      2023-10-28  311  		data = page_frag_alloc_align(nc, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13  312  	} else {
32e3573f739209 Yajun Deng        2021-09-14  313  		struct napi_alloc_cache *nc;
32e3573f739209 Yajun Deng        2021-09-14  314  
50fad4b543b30e Alexander Lobakin 2021-02-13  315  		local_bh_disable();
32e3573f739209 Yajun Deng        2021-09-14  316  		nc = this_cpu_ptr(&napi_alloc_cache);
1ec6b07022b148 Yunsheng Lin      2023-10-28  317  		data = page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC, align);
50fad4b543b30e Alexander Lobakin 2021-02-13  318  		local_bh_enable();
50fad4b543b30e Alexander Lobakin 2021-02-13  319  	}
50fad4b543b30e Alexander Lobakin 2021-02-13  320  	return data;
50fad4b543b30e Alexander Lobakin 2021-02-13  321  }
50fad4b543b30e Alexander Lobakin 2021-02-13 @322  EXPORT_SYMBOL(__netdev_alloc_frag_align);
50fad4b543b30e Alexander Lobakin 2021-02-13  323  

:::::: The code at line 301 was first introduced by commit
:::::: 50fad4b543b30e9323da485d4090c3a94b2b6271 skbuff: move NAPI cache declarations upper in the file

:::::: TO: Alexander Lobakin <alobakin@pm.me>
:::::: CC: David S. Miller <davem@davemloft.net>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-28 18:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-28 18:50 [linyunsheng:page_frag_unify_rfc 2/4] net/core/skbuff.c:301:15: error: '__napi_alloc_frag_align' undeclared here (not in a function); did you mean 'napi_alloc_frag_align'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.