From: kernel test robot <lkp@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: oe-kbuild-all@lists.linux.dev,
Richard Weinberger <richard@nod.at>,
Zhihao Cheng <chengzhihao1@huawei.com>
Subject: [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
Date: Sun, 29 Oct 2023 07:29:53 +0800 [thread overview]
Message-ID: <202310290749.EkmBAiIQ-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
head: 75690493591fe283e4c92a3ba7c4420e9858abdb
commit: 48ec6328de6c153a64474d9e5b6ec95f20f4142b [1/18] ubifs: Fix some kernel-doc comments
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310290749.EkmBAiIQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
vim +1385 fs/ubifs/file.c
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 1374
8c1c5f263833ec Dongsheng Yang 2015-11-07 1375 /**
8c1c5f263833ec Dongsheng Yang 2015-11-07 1376 * ubifs_update_time - update time of inode.
8c1c5f263833ec Dongsheng Yang 2015-11-07 1377 * @inode: inode to update
48ec6328de6c15 Yang Li 2023-07-12 1378 * @time: timespec structure to hold the current time value
48ec6328de6c15 Yang Li 2023-07-12 1379 * @flags: time updating control flag determines updating
48ec6328de6c15 Yang Li 2023-07-12 1380 * which time fields of @inode
8c1c5f263833ec Dongsheng Yang 2015-11-07 1381 *
8c1c5f263833ec Dongsheng Yang 2015-11-07 1382 * This function updates time of the inode.
8c1c5f263833ec Dongsheng Yang 2015-11-07 1383 */
913e99287b98fd Jeff Layton 2023-08-07 1384 int ubifs_update_time(struct inode *inode, int flags)
8c1c5f263833ec Dongsheng Yang 2015-11-07 @1385 {
8c1c5f263833ec Dongsheng Yang 2015-11-07 1386 struct ubifs_inode *ui = ubifs_inode(inode);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1387 struct ubifs_info *c = inode->i_sb->s_fs_info;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1388 struct ubifs_budget_req req = { .dirtied_ino = 1,
8c1c5f263833ec Dongsheng Yang 2015-11-07 1389 .dirtied_ino_d = ALIGN(ui->data_len, 8) };
8c1c5f263833ec Dongsheng Yang 2015-11-07 1390 int err, release;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1391
541d4c798a5988 Jeff Layton 2023-08-07 1392 if (!IS_ENABLED(CONFIG_UBIFS_ATIME_SUPPORT)) {
541d4c798a5988 Jeff Layton 2023-08-07 1393 generic_update_time(inode, flags);
541d4c798a5988 Jeff Layton 2023-08-07 1394 return 0;
541d4c798a5988 Jeff Layton 2023-08-07 1395 }
e3d73dead4988f Sascha Hauer 2019-03-26 1396
8c1c5f263833ec Dongsheng Yang 2015-11-07 1397 err = ubifs_budget_space(c, &req);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1398 if (err)
8c1c5f263833ec Dongsheng Yang 2015-11-07 1399 return err;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1400
8c1c5f263833ec Dongsheng Yang 2015-11-07 1401 mutex_lock(&ui->ui_mutex);
97ebfdb7ad089d Jeff Layton 2023-08-07 1402 inode_update_timestamps(inode, flags);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1403 release = ui->dirty;
ecf84096a526f2 Christoph Hellwig 2020-04-09 1404 __mark_inode_dirty(inode, I_DIRTY_SYNC);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1405 mutex_unlock(&ui->ui_mutex);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1406 if (release)
8c1c5f263833ec Dongsheng Yang 2015-11-07 1407 ubifs_release_budget(c, &req);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1408 return 0;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1409 }
8c1c5f263833ec Dongsheng Yang 2015-11-07 1410
:::::: The code at line 1385 was first introduced by commit
:::::: 8c1c5f263833ec2dc8fd716cf4281265c485d7ad ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs
:::::: TO: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
:::::: CC: Richard Weinberger <richard@nod.at>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-10-28 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 23:29 kernel test robot [this message]
2023-10-30 2:00 ` [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time' Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310290749.EkmBAiIQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=chengzhihao1@huawei.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=richard@nod.at \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.