* [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
@ 2023-10-28 23:29 kernel test robot
2023-10-30 2:00 ` Zhihao Cheng
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-10-28 23:29 UTC (permalink / raw)
To: Yang Li; +Cc: oe-kbuild-all, Richard Weinberger, Zhihao Cheng
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
head: 75690493591fe283e4c92a3ba7c4420e9858abdb
commit: 48ec6328de6c153a64474d9e5b6ec95f20f4142b [1/18] ubifs: Fix some kernel-doc comments
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310290749.EkmBAiIQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
vim +1385 fs/ubifs/file.c
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 1374
8c1c5f263833ec Dongsheng Yang 2015-11-07 1375 /**
8c1c5f263833ec Dongsheng Yang 2015-11-07 1376 * ubifs_update_time - update time of inode.
8c1c5f263833ec Dongsheng Yang 2015-11-07 1377 * @inode: inode to update
48ec6328de6c15 Yang Li 2023-07-12 1378 * @time: timespec structure to hold the current time value
48ec6328de6c15 Yang Li 2023-07-12 1379 * @flags: time updating control flag determines updating
48ec6328de6c15 Yang Li 2023-07-12 1380 * which time fields of @inode
8c1c5f263833ec Dongsheng Yang 2015-11-07 1381 *
8c1c5f263833ec Dongsheng Yang 2015-11-07 1382 * This function updates time of the inode.
8c1c5f263833ec Dongsheng Yang 2015-11-07 1383 */
913e99287b98fd Jeff Layton 2023-08-07 1384 int ubifs_update_time(struct inode *inode, int flags)
8c1c5f263833ec Dongsheng Yang 2015-11-07 @1385 {
8c1c5f263833ec Dongsheng Yang 2015-11-07 1386 struct ubifs_inode *ui = ubifs_inode(inode);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1387 struct ubifs_info *c = inode->i_sb->s_fs_info;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1388 struct ubifs_budget_req req = { .dirtied_ino = 1,
8c1c5f263833ec Dongsheng Yang 2015-11-07 1389 .dirtied_ino_d = ALIGN(ui->data_len, 8) };
8c1c5f263833ec Dongsheng Yang 2015-11-07 1390 int err, release;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1391
541d4c798a5988 Jeff Layton 2023-08-07 1392 if (!IS_ENABLED(CONFIG_UBIFS_ATIME_SUPPORT)) {
541d4c798a5988 Jeff Layton 2023-08-07 1393 generic_update_time(inode, flags);
541d4c798a5988 Jeff Layton 2023-08-07 1394 return 0;
541d4c798a5988 Jeff Layton 2023-08-07 1395 }
e3d73dead4988f Sascha Hauer 2019-03-26 1396
8c1c5f263833ec Dongsheng Yang 2015-11-07 1397 err = ubifs_budget_space(c, &req);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1398 if (err)
8c1c5f263833ec Dongsheng Yang 2015-11-07 1399 return err;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1400
8c1c5f263833ec Dongsheng Yang 2015-11-07 1401 mutex_lock(&ui->ui_mutex);
97ebfdb7ad089d Jeff Layton 2023-08-07 1402 inode_update_timestamps(inode, flags);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1403 release = ui->dirty;
ecf84096a526f2 Christoph Hellwig 2020-04-09 1404 __mark_inode_dirty(inode, I_DIRTY_SYNC);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1405 mutex_unlock(&ui->ui_mutex);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1406 if (release)
8c1c5f263833ec Dongsheng Yang 2015-11-07 1407 ubifs_release_budget(c, &req);
8c1c5f263833ec Dongsheng Yang 2015-11-07 1408 return 0;
8c1c5f263833ec Dongsheng Yang 2015-11-07 1409 }
8c1c5f263833ec Dongsheng Yang 2015-11-07 1410
:::::: The code at line 1385 was first introduced by commit
:::::: 8c1c5f263833ec2dc8fd716cf4281265c485d7ad ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs
:::::: TO: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
:::::: CC: Richard Weinberger <richard@nod.at>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
2023-10-28 23:29 [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time' kernel test robot
@ 2023-10-30 2:00 ` Zhihao Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2023-10-30 2:00 UTC (permalink / raw)
To: kernel test robot, Yang Li; +Cc: oe-kbuild-all, Richard Weinberger
在 2023/10/29 7:29, kernel test robot 写道:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
> head: 75690493591fe283e4c92a3ba7c4420e9858abdb
> commit: 48ec6328de6c153a64474d9e5b6ec95f20f4142b [1/18] ubifs: Fix some kernel-doc comments
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290749.EkmBAiIQ-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310290749.EkmBAiIQ-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time'
>
> vim +1385 fs/ubifs/file.c
>
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 1374
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1375 /**
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1376 * ubifs_update_time - update time of inode.
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1377 * @inode: inode to update
> 48ec6328de6c15 Yang Li 2023-07-12 1378 * @time: timespec structure to hold the current time value
> 48ec6328de6c15 Yang Li 2023-07-12 1379 * @flags: time updating control flag determines updating
> 48ec6328de6c15 Yang Li 2023-07-12 1380 * which time fields of @inode
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1381 *
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1382 * This function updates time of the inode.
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1383 */
> 913e99287b98fd Jeff Layton 2023-08-07 1384 int ubifs_update_time(struct inode *inode, int flags)
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 @1385 {
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1386 struct ubifs_inode *ui = ubifs_inode(inode);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1387 struct ubifs_info *c = inode->i_sb->s_fs_info;
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1388 struct ubifs_budget_req req = { .dirtied_ino = 1,
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1389 .dirtied_ino_d = ALIGN(ui->data_len, 8) };
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1390 int err, release;
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1391
> 541d4c798a5988 Jeff Layton 2023-08-07 1392 if (!IS_ENABLED(CONFIG_UBIFS_ATIME_SUPPORT)) {
> 541d4c798a5988 Jeff Layton 2023-08-07 1393 generic_update_time(inode, flags);
> 541d4c798a5988 Jeff Layton 2023-08-07 1394 return 0;
> 541d4c798a5988 Jeff Layton 2023-08-07 1395 }
> e3d73dead4988f Sascha Hauer 2019-03-26 1396
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1397 err = ubifs_budget_space(c, &req);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1398 if (err)
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1399 return err;
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1400
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1401 mutex_lock(&ui->ui_mutex);
> 97ebfdb7ad089d Jeff Layton 2023-08-07 1402 inode_update_timestamps(inode, flags);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1403 release = ui->dirty;
> ecf84096a526f2 Christoph Hellwig 2020-04-09 1404 __mark_inode_dirty(inode, I_DIRTY_SYNC);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1405 mutex_unlock(&ui->ui_mutex);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1406 if (release)
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1407 ubifs_release_budget(c, &req);
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1408 return 0;
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1409 }
> 8c1c5f263833ec Dongsheng Yang 2015-11-07 1410
>
> :::::: The code at line 1385 was first introduced by commit
> :::::: 8c1c5f263833ec2dc8fd716cf4281265c485d7ad ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs
>
> :::::: TO: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> :::::: CC: Richard Weinberger <richard@nod.at>
>
I think the patch [1] should be modified, argument 'time' has been
removed in 913e99287b98fd0("fs: drop the timespec64 argument from
update_time"). Timeline shown as follow:
2023/07/12: [1] was sent out.
2023/08/11: 913e99287b98fd0 is applied into linux-next.
2023/10/29: [1] is applied into ubifs.git next.
[1]
https://patchwork.ozlabs.org/project/linux-mtd/patch/20230712074637.129248-1-yang.lee@linux.alibaba.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-30 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-28 23:29 [rw-ubifs:next 1/18] fs/ubifs/file.c:1385: warning: Excess function parameter 'time' description in 'ubifs_update_time' kernel test robot
2023-10-30 2:00 ` Zhihao Cheng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.