[PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[Dorine Tipo]

Fix multiple blank lines warning
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index a67757c9bb5c..be1e5180d57b 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/
-- 
2.25.1

Re: [PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[Julia Lawall]

The signed off by came out in the place of the subject line.  What did you
do to create the patch?

It could be good to try sending it to yourself first, to be sure that
everything is ok.  Please reread the Submit a patch section of the first
patch tutorial.

thanks,
julia

On Sun, 29 Oct 2023, Dorine Tipo wrote:

> Fix multiple blank lines warning
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
> index a67757c9bb5c..be1e5180d57b 100644
> --- a/drivers/staging/vt6655/rxtx.h
> +++ b/drivers/staging/vt6655/rxtx.h
> @@ -19,7 +19,6 @@
>  #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
>  #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
>
> -
>  /*---------------------  Export Definitions -------------------------*/
>
>  /*---------------------  Export Variables  --------------------------*/
> --
> 2.25.1
>
>
>

Re: [PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[Greg KH]

On Sun, Oct 29, 2023 at 09:47:13AM +0000, Dorine Tipo wrote:
> Fix multiple blank lines warning
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
> index a67757c9bb5c..be1e5180d57b 100644
> --- a/drivers/staging/vt6655/rxtx.h
> +++ b/drivers/staging/vt6655/rxtx.h
> @@ -19,7 +19,6 @@
>  #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
>  #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
>  
> -
>  /*---------------------  Export Definitions -------------------------*/
>  
>  /*---------------------  Export Variables  --------------------------*/
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.

- Your patch was sent privately to Greg.  Kernel development is done in
  public, please always cc: a public mailing list with a patch
  submission.  Using the tool, scripts/get_maintainer.pl on the patch
  will tell you what mailing list to cc.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[Dorine Tipo]

Fix code style issues and improve error handling in ethernet-tx.c

This commit addresses the following issues in the drivers/staging/octeon/ethernet-tx.c file:

1. Removed unnecessary parentheses around conditions:
   - Removed unnecessary parentheses around 'CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1' and 'CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1'.
   - Removed unnecessary parentheses around 'skb->len < 64'.
   - Removed unnecessary parentheses around 'skb->protocol == htons(ETH_P_IP)'.

2. Replaced 'BUG()' with 'WARN_ON_ONCE()' for better error handling:
   - Replaced the use of 'BUG()' with 'WARN_ON_ONCE()' at line 454 to avoid crashing the kernel and provide more graceful error handling.

3. Removed redundant code sections:
   - Removed the code enclosed by the #if 0 and its #endif directives at lines 577, 586, and 599 as they are no longer needed.

These changes improve code readability, reduce unnecessary parentheses, and enhance error handling
while removing redundant code sections. The code is now more in line with coding standards and best practices.
---
 drivers/staging/octeon/ethernet-tx.c | 50 +++-------------------------
 1 file changed, 5 insertions(+), 45 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index bbf33b88bb7c..cdc98ce2e61e 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -153,8 +153,8 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 	 * completely remove "qos" in the event neither interface
 	 * supports multiple queues per port.
 	 */
-	if ((CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1) ||
-	    (CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1)) {
+	if (CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1 ||
+	    CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1) {
 		qos = GET_SKBUFF_QOS(skb);
 		if (qos <= 0)
 			qos = 0;
@@ -224,7 +224,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 	 * no room to add the padding.  The kernel should always give
 	 * us at least a cache line
 	 */
-	if ((skb->len < 64) && OCTEON_IS_MODEL(OCTEON_CN3XXX)) {
+	if (skb->len < 64 && OCTEON_IS_MODEL(OCTEON_CN3XXX)) {
 		union cvmx_gmxx_prtx_cfg gmx_prt_cfg;
 		int interface = INTERFACE(priv->port);
 		int index = INDEX(priv->port);
@@ -360,7 +360,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 dont_put_skbuff_in_hw:
 
 	/* Check if we can use the hardware checksumming */
-	if ((skb->protocol == htons(ETH_P_IP)) &&
+	if (skb->protocol == htons(ETH_P_IP) &&
 	    (ip_hdr(skb)->version == 4) &&
 	    (ip_hdr(skb)->ihl == 5) &&
 	    ((ip_hdr(skb)->frag_off == 0) ||
@@ -451,7 +451,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 		__skb_queue_tail(&priv->tx_free_list[qos], skb);
 		break;
 	default:
-		BUG();
+		WARN_ON_ONCE(1);
 	}
 
 	while (skb_to_free > 0) {
@@ -574,42 +574,14 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
 
 	if (skb->protocol == htons(ETH_P_IP)) {
 		work->word2.s.ip_offset = 14;
-#if 0
-		work->word2.s.vlan_valid = 0;	/* FIXME */
-		work->word2.s.vlan_cfi = 0;	/* FIXME */
-		work->word2.s.vlan_id = 0;	/* FIXME */
-		work->word2.s.dec_ipcomp = 0;	/* FIXME */
-#endif
 		work->word2.s.tcp_or_udp =
 		    (ip_hdr(skb)->protocol == IPPROTO_TCP) ||
 		    (ip_hdr(skb)->protocol == IPPROTO_UDP);
-#if 0
-		/* FIXME */
-		work->word2.s.dec_ipsec = 0;
-		/* We only support IPv4 right now */
-		work->word2.s.is_v6 = 0;
-		/* Hardware would set to zero */
-		work->word2.s.software = 0;
-		/* No error, packet is internal */
-		work->word2.s.L4_error = 0;
-#endif
 		work->word2.s.is_frag = !((ip_hdr(skb)->frag_off == 0) ||
 					  (ip_hdr(skb)->frag_off ==
 					      cpu_to_be16(1 << 14)));
-#if 0
-		/* Assume Linux is sending a good packet */
-		work->word2.s.IP_exc = 0;
-#endif
 		work->word2.s.is_bcast = (skb->pkt_type == PACKET_BROADCAST);
 		work->word2.s.is_mcast = (skb->pkt_type == PACKET_MULTICAST);
-#if 0
-		/* This is an IP packet */
-		work->word2.s.not_IP = 0;
-		/* No error, packet is internal */
-		work->word2.s.rcv_error = 0;
-		/* No error, packet is internal */
-		work->word2.s.err_code = 0;
-#endif
 
 		/*
 		 * When copying the data, include 4 bytes of the
@@ -619,12 +591,6 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
 		memcpy(work->packet_data, skb->data + 10,
 		       sizeof(work->packet_data));
 	} else {
-#if 0
-		work->word2.snoip.vlan_valid = 0;	/* FIXME */
-		work->word2.snoip.vlan_cfi = 0;	/* FIXME */
-		work->word2.snoip.vlan_id = 0;	/* FIXME */
-		work->word2.snoip.software = 0;	/* Hardware would set to zero */
-#endif
 		work->word2.snoip.is_rarp = skb->protocol == htons(ETH_P_RARP);
 		work->word2.snoip.is_arp = skb->protocol == htons(ETH_P_ARP);
 		work->word2.snoip.is_bcast =
@@ -632,12 +598,6 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
 		work->word2.snoip.is_mcast =
 		    (skb->pkt_type == PACKET_MULTICAST);
 		work->word2.snoip.not_IP = 1;	/* IP was done up above */
-#if 0
-		/* No error, packet is internal */
-		work->word2.snoip.rcv_error = 0;
-		/* No error, packet is internal */
-		work->word2.snoip.err_code = 0;
-#endif
 		memcpy(work->packet_data, skb->data, sizeof(work->packet_data));
 	}
 
-- 
2.25.1

Re: [PATCH] Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

[Julia Lawall]

On Sun, 29 Oct 2023, Dorine Tipo wrote:

> Fix code style issues and improve error handling in ethernet-tx.c
>
> This commit addresses the following issues in the drivers/staging/octeon/ethernet-tx.c file:
>
> 1. Removed unnecessary parentheses around conditions:
>    - Removed unnecessary parentheses around 'CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1' and 'CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1'.
>    - Removed unnecessary parentheses around 'skb->len < 64'.
>    - Removed unnecessary parentheses around 'skb->protocol == htons(ETH_P_IP)'.
>
> 2. Replaced 'BUG()' with 'WARN_ON_ONCE()' for better error handling:
>    - Replaced the use of 'BUG()' with 'WARN_ON_ONCE()' at line 454 to avoid crashing the kernel and provide more graceful error handling.
>
> 3. Removed redundant code sections:
>    - Removed the code enclosed by the #if 0 and its #endif directives at lines 577, 586, and 599 as they are no longer needed.
>
> These changes improve code readability, reduce unnecessary parentheses, and enhance error handling
> while removing redundant code sections. The code is now more in line with coding standards and best practices.

This is going better in the right direction.  But it seems that youare
doing multiple things.  Each patch should do only one thing.  Thus you
need to make a patch series.  Please read the tutorial accordingly.

I recall a comment in a mail from Dan Carpenter saying that there should
not no new occurrences of WARN_ON in the kernel.  See if you can find that
mail in the outreachy archives (I'm not sure if I saw it there, but it
seems likely).  Maybe there is an error code that you can return instead.

You are also missing your signed off by.

In any case, I think it would be better to send one single patch that does
ont single thing, and get that accepted, to be sure that you are doing the
whole process correctly, rather than trying to do many things at once.

julia

> ---
>  drivers/staging/octeon/ethernet-tx.c | 50 +++-------------------------
>  1 file changed, 5 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index bbf33b88bb7c..cdc98ce2e61e 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -153,8 +153,8 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  	 * completely remove "qos" in the event neither interface
>  	 * supports multiple queues per port.
>  	 */
> -	if ((CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1) ||
> -	    (CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1)) {
> +	if (CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1 ||
> +	    CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1) {
>  		qos = GET_SKBUFF_QOS(skb);
>  		if (qos <= 0)
>  			qos = 0;
> @@ -224,7 +224,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  	 * no room to add the padding.  The kernel should always give
>  	 * us at least a cache line
>  	 */
> -	if ((skb->len < 64) && OCTEON_IS_MODEL(OCTEON_CN3XXX)) {
> +	if (skb->len < 64 && OCTEON_IS_MODEL(OCTEON_CN3XXX)) {
>  		union cvmx_gmxx_prtx_cfg gmx_prt_cfg;
>  		int interface = INTERFACE(priv->port);
>  		int index = INDEX(priv->port);
> @@ -360,7 +360,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  dont_put_skbuff_in_hw:
>
>  	/* Check if we can use the hardware checksumming */
> -	if ((skb->protocol == htons(ETH_P_IP)) &&
> +	if (skb->protocol == htons(ETH_P_IP) &&
>  	    (ip_hdr(skb)->version == 4) &&
>  	    (ip_hdr(skb)->ihl == 5) &&
>  	    ((ip_hdr(skb)->frag_off == 0) ||
> @@ -451,7 +451,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  		__skb_queue_tail(&priv->tx_free_list[qos], skb);
>  		break;
>  	default:
> -		BUG();
> +		WARN_ON_ONCE(1);
>  	}
>
>  	while (skb_to_free > 0) {
> @@ -574,42 +574,14 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
>
>  	if (skb->protocol == htons(ETH_P_IP)) {
>  		work->word2.s.ip_offset = 14;
> -#if 0
> -		work->word2.s.vlan_valid = 0;	/* FIXME */
> -		work->word2.s.vlan_cfi = 0;	/* FIXME */
> -		work->word2.s.vlan_id = 0;	/* FIXME */
> -		work->word2.s.dec_ipcomp = 0;	/* FIXME */
> -#endif
>  		work->word2.s.tcp_or_udp =
>  		    (ip_hdr(skb)->protocol == IPPROTO_TCP) ||
>  		    (ip_hdr(skb)->protocol == IPPROTO_UDP);
> -#if 0
> -		/* FIXME */
> -		work->word2.s.dec_ipsec = 0;
> -		/* We only support IPv4 right now */
> -		work->word2.s.is_v6 = 0;
> -		/* Hardware would set to zero */
> -		work->word2.s.software = 0;
> -		/* No error, packet is internal */
> -		work->word2.s.L4_error = 0;
> -#endif
>  		work->word2.s.is_frag = !((ip_hdr(skb)->frag_off == 0) ||
>  					  (ip_hdr(skb)->frag_off ==
>  					      cpu_to_be16(1 << 14)));
> -#if 0
> -		/* Assume Linux is sending a good packet */
> -		work->word2.s.IP_exc = 0;
> -#endif
>  		work->word2.s.is_bcast = (skb->pkt_type == PACKET_BROADCAST);
>  		work->word2.s.is_mcast = (skb->pkt_type == PACKET_MULTICAST);
> -#if 0
> -		/* This is an IP packet */
> -		work->word2.s.not_IP = 0;
> -		/* No error, packet is internal */
> -		work->word2.s.rcv_error = 0;
> -		/* No error, packet is internal */
> -		work->word2.s.err_code = 0;
> -#endif
>
>  		/*
>  		 * When copying the data, include 4 bytes of the
> @@ -619,12 +591,6 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
>  		memcpy(work->packet_data, skb->data + 10,
>  		       sizeof(work->packet_data));
>  	} else {
> -#if 0
> -		work->word2.snoip.vlan_valid = 0;	/* FIXME */
> -		work->word2.snoip.vlan_cfi = 0;	/* FIXME */
> -		work->word2.snoip.vlan_id = 0;	/* FIXME */
> -		work->word2.snoip.software = 0;	/* Hardware would set to zero */
> -#endif
>  		work->word2.snoip.is_rarp = skb->protocol == htons(ETH_P_RARP);
>  		work->word2.snoip.is_arp = skb->protocol == htons(ETH_P_ARP);
>  		work->word2.snoip.is_bcast =
> @@ -632,12 +598,6 @@ netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
>  		work->word2.snoip.is_mcast =
>  		    (skb->pkt_type == PACKET_MULTICAST);
>  		work->word2.snoip.not_IP = 1;	/* IP was done up above */
> -#if 0
> -		/* No error, packet is internal */
> -		work->word2.snoip.rcv_error = 0;
> -		/* No error, packet is internal */
> -		work->word2.snoip.err_code = 0;
> -#endif
>  		memcpy(work->packet_data, skb->data, sizeof(work->packet_data));
>  	}
>
> --
> 2.25.1
>
>
>