From: Rob Herring <robh@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>,
Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
Subject: Re: [PATCH 5/7] dt-bindings: trivial-devices: Add IOT2050 Arduino SPI connector
Date: Mon, 30 Oct 2023 11:43:27 -0500 [thread overview]
Message-ID: <20231030164327.GA1242659-robh@kernel.org> (raw)
In-Reply-To: <7838d99a1795337c73f480fafcbf698fc17d16dd.1698413678.git.jan.kiszka@siemens.com>
On Fri, Oct 27, 2023 at 03:34:36PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> On the Siemens IOT2050 devices, the SPI controller wired to the Arduino
> connector is normally driven by userspace. Introduce a binding for use
> by spidev.
What's spidev? Not a h/w device...
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 430a814f64a5..01b9f36afcd5 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -349,6 +349,8 @@ properties:
> - silabs,si3210
> # Relative Humidity and Temperature Sensors
> - silabs,si7020
> + # Siemens IOT2050: SPI interface on Arduino connector
> + - siemens,iot2050-arduino-spi
How is this specific to your board? Presumably, an 'Arduino connector'
is a somewhat standard interface, right? If every board with an Arduino
connector adds a compatible, this doesn't scale.
A connector is what you should be describing, but I imagine it is not
just SPI. Here's some past discussions[1][2] on the need for connector
bindings.
Rob
[1] https://lore.kernel.org/all/20220421094421.288672-1-michael@walle.cc/
[2] https://lore.kernel.org/all/CAL_JsqK2DKPbaFvUPSU2E7oh1_pryrRXPMg8OASmK722jmznwA@mail.gmail.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>,
Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
Subject: Re: [PATCH 5/7] dt-bindings: trivial-devices: Add IOT2050 Arduino SPI connector
Date: Mon, 30 Oct 2023 11:43:27 -0500 [thread overview]
Message-ID: <20231030164327.GA1242659-robh@kernel.org> (raw)
In-Reply-To: <7838d99a1795337c73f480fafcbf698fc17d16dd.1698413678.git.jan.kiszka@siemens.com>
On Fri, Oct 27, 2023 at 03:34:36PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> On the Siemens IOT2050 devices, the SPI controller wired to the Arduino
> connector is normally driven by userspace. Introduce a binding for use
> by spidev.
What's spidev? Not a h/w device...
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 430a814f64a5..01b9f36afcd5 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -349,6 +349,8 @@ properties:
> - silabs,si3210
> # Relative Humidity and Temperature Sensors
> - silabs,si7020
> + # Siemens IOT2050: SPI interface on Arduino connector
> + - siemens,iot2050-arduino-spi
How is this specific to your board? Presumably, an 'Arduino connector'
is a somewhat standard interface, right? If every board with an Arduino
connector adds a compatible, this doesn't scale.
A connector is what you should be describing, but I imagine it is not
just SPI. Here's some past discussions[1][2] on the need for connector
bindings.
Rob
[1] https://lore.kernel.org/all/20220421094421.288672-1-michael@walle.cc/
[2] https://lore.kernel.org/all/CAL_JsqK2DKPbaFvUPSU2E7oh1_pryrRXPMg8OASmK722jmznwA@mail.gmail.com/
next prev parent reply other threads:[~2023-10-30 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 13:34 [PATCH 0/7] arm64: dts: iot2050: DT fixes, cleanups and enhancements Jan Kiszka
2023-10-27 13:34 ` [PATCH 1/7] arm64: dts: ti: iot2050: Re-add aliases Jan Kiszka
2023-10-27 13:34 ` [PATCH 2/7] arm64: dts: ti: iot2050: Drop unused ecap0 PWM Jan Kiszka
2023-10-27 13:34 ` [PATCH 3/7] arm64: dts: ti: iot2050: Definitions for runtime pinmuxing Jan Kiszka
2023-10-27 13:44 ` Nishanth Menon
2023-10-27 13:34 ` [PATCH 4/7] arm64: dts: ti: iot2050: Refactor the m.2 and minipcie power pin Jan Kiszka
2023-10-27 13:43 ` Nishanth Menon
2023-10-27 13:45 ` Jan Kiszka
2023-10-27 13:55 ` Nishanth Menon
2023-10-27 13:34 ` [PATCH 5/7] dt-bindings: trivial-devices: Add IOT2050 Arduino SPI connector Jan Kiszka
2023-10-30 16:43 ` Rob Herring [this message]
2023-10-30 16:43 ` Rob Herring
2023-10-30 17:35 ` Jan Kiszka
2023-10-30 17:35 ` Jan Kiszka
2023-10-27 13:34 ` [PATCH 6/7] arm64: dts: ti: iot2050: Add node for SPI devices on Arduino connector Jan Kiszka
2023-10-27 13:34 ` [PATCH 7/7] arm64: dts: ti: iot2050: Add icssg-prueth nodes for PG2 devices Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030164327.GA1242659-robh@kernel.org \
--to=robh@kernel.org \
--cc=baocheng.su@siemens.com \
--cc=benedikt.niedermayr@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.