* [PATCH] Fix line Length
@ 2023-10-29 13:51 Dorine Tipo
2023-10-29 14:11 ` Bagas Sanjaya
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dorine Tipo @ 2023-10-29 13:51 UTC (permalink / raw)
To: outreachy, gregkh; +Cc: Dorine Tipo
Fix the line lengths of lines 8 and 49
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
index 2bb759165063..d7b779bb7f64 100755
--- a/drivers/gpu/drm/ci/igt_runner.sh
+++ b/drivers/gpu/drm/ci/igt_runner.sh
@@ -5,7 +5,8 @@ set -ex
export IGT_FORCE_DRIVER=${DRIVER_NAME}
export PATH=$PATH:/igt/bin/
-export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
# Uncomment the below to debug problems with driver probing
: '
@@ -46,7 +47,8 @@ else
ARCH="x86_64"
fi
-curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
+curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
+ ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
set +e
igt-runner \
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Fix line Length
2023-10-29 13:51 [PATCH] Fix line Length Dorine Tipo
@ 2023-10-29 14:11 ` Bagas Sanjaya
2023-10-29 14:22 ` Julia Lawall
2023-10-30 6:12 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Bagas Sanjaya @ 2023-10-29 14:11 UTC (permalink / raw)
To: Dorine Tipo, Linux Outreachy, Greg KH, Linux DRI Development,
Linux Kernel Mailing List
Cc: Tomeu Vizoso, Helen Koike, David Airlie, Daniel Vetter,
Nick Terrell, Daniel Stone, Rob Clark
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Sun, Oct 29, 2023 at 01:51:04PM +0000, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
>
Is it checkpatch fix?
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
I'd like the former (single-line) assignment version.
> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
This one LGTM.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix line Length
@ 2023-10-29 14:11 ` Bagas Sanjaya
0 siblings, 0 replies; 5+ messages in thread
From: Bagas Sanjaya @ 2023-10-29 14:11 UTC (permalink / raw)
To: Dorine Tipo, Linux Outreachy, Greg KH, Linux DRI Development,
Linux Kernel Mailing List
Cc: Daniel Stone, Tomeu Vizoso, Helen Koike, Nick Terrell
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Sun, Oct 29, 2023 at 01:51:04PM +0000, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
>
Is it checkpatch fix?
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
I'd like the former (single-line) assignment version.
> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
This one LGTM.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix line Length
2023-10-29 13:51 [PATCH] Fix line Length Dorine Tipo
2023-10-29 14:11 ` Bagas Sanjaya
@ 2023-10-29 14:22 ` Julia Lawall
2023-10-30 6:12 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2023-10-29 14:22 UTC (permalink / raw)
To: Dorine Tipo; +Cc: outreachy, gregkh
On Sun, 29 Oct 2023, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
It's not necessary to provide the numbers of the lines. The reader can
see where the changes rae made in the patch. Since a patch should only do
one thing, all changed places should be related to that thing.
"Fix" is quite vague. Here you could say "Reduce" to be more clear about
what is being done.
julia
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
>
> # Uncomment the below to debug problems with driver probing
> : '
> @@ -46,7 +47,8 @@ else
> ARCH="x86_64"
> fi
>
> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
>
> set +e
> igt-runner \
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix line Length
2023-10-29 13:51 [PATCH] Fix line Length Dorine Tipo
2023-10-29 14:11 ` Bagas Sanjaya
2023-10-29 14:22 ` Julia Lawall
@ 2023-10-30 6:12 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2023-10-30 6:12 UTC (permalink / raw)
To: Dorine Tipo; +Cc: outreachy
On Sun, Oct 29, 2023 at 01:51:04PM +0000, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
outreachy submissions should not be for files like this, please read the
application instructions again. All of your changes are not following
the requirements and as such, I have deleted them all from my review
queue, sorry.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-30 6:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-29 13:51 [PATCH] Fix line Length Dorine Tipo
2023-10-29 14:11 ` Bagas Sanjaya
2023-10-29 14:11 ` Bagas Sanjaya
2023-10-29 14:22 ` Julia Lawall
2023-10-30 6:12 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.