From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Subject: [Nouveau] [PATCH 2/3] nouveau/gsp: fix message signature.
Date: Tue, 31 Oct 2023 15:18:46 +1000 [thread overview]
Message-ID: <20231031051943.1957328-3-airlied@gmail.com> (raw)
In-Reply-To: <20231031051943.1957328-1-airlied@gmail.com>
From: Dave Airlie <airlied@redhat.com>
This original one was backwards, compared to traces from nvidia driver.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
index 47138d797748..b6f6b5e747d4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
@@ -693,7 +693,7 @@ r535_gsp_rpc_get(struct nvkm_gsp *gsp, u32 fn, u32 argc)
return NULL;
rpc->header_version = 0x03000000;
- rpc->signature = ('V' << 24) | ('R' << 16) | ('P' << 8) | 'C';
+ rpc->signature = ('C' << 24) | ('P' << 16) | ('R' << 8) | 'V';
rpc->function = fn;
rpc->rpc_result = 0xffffffff;
rpc->rpc_result_private = 0xffffffff;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Subject: [PATCH 2/3] nouveau/gsp: fix message signature.
Date: Tue, 31 Oct 2023 15:18:46 +1000 [thread overview]
Message-ID: <20231031051943.1957328-3-airlied@gmail.com> (raw)
In-Reply-To: <20231031051943.1957328-1-airlied@gmail.com>
From: Dave Airlie <airlied@redhat.com>
This original one was backwards, compared to traces from nvidia driver.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
index 47138d797748..b6f6b5e747d4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
@@ -693,7 +693,7 @@ r535_gsp_rpc_get(struct nvkm_gsp *gsp, u32 fn, u32 argc)
return NULL;
rpc->header_version = 0x03000000;
- rpc->signature = ('V' << 24) | ('R' << 16) | ('P' << 8) | 'C';
+ rpc->signature = ('C' << 24) | ('P' << 16) | ('R' << 8) | 'V';
rpc->function = fn;
rpc->rpc_result = 0xffffffff;
rpc->rpc_result_private = 0xffffffff;
--
2.41.0
next prev parent reply other threads:[~2023-10-31 5:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 5:18 [Nouveau] nouveau/gsp: move to latest fw and small fixes Dave Airlie
2023-10-31 5:18 ` Dave Airlie
2023-10-31 5:18 ` [Nouveau] [PATCH 1/3] nouveau/gsp: move to 535.113.01 Dave Airlie
2023-10-31 5:18 ` Dave Airlie
2023-10-31 5:18 ` Dave Airlie [this message]
2023-10-31 5:18 ` [PATCH 2/3] nouveau/gsp: fix message signature Dave Airlie
2023-10-31 5:18 ` [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries Dave Airlie
2023-10-31 5:18 ` Dave Airlie
2023-10-31 15:52 ` [Nouveau] " Timur Tabi
2023-10-31 19:29 ` Dave Airlie
2023-10-31 20:02 ` Timur Tabi
2023-11-07 18:51 ` Timur Tabi
2023-11-07 18:54 ` Dave Airlie
2023-11-07 19:02 ` Timur Tabi
2023-11-27 20:47 ` Timur Tabi
2023-11-27 21:32 ` Dave Airlie
2023-11-03 2:03 ` [Nouveau] nouveau/gsp: move to latest fw and small fixes Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031051943.1957328-3-airlied@gmail.com \
--to=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.