From: Rob Herring <robh@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Olliver Schinagl <oliver@schinagl.nl>
Subject: Re: [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions
Date: Tue, 31 Oct 2023 13:03:05 -0500 [thread overview]
Message-ID: <20231031180305.GA1813504-robh@kernel.org> (raw)
In-Reply-To: <TYAP286MB0315235C51DAC7905DE4573EBCA0A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
On Tue, Oct 31, 2023 at 09:29:01PM +0800, Shiji Yang wrote:
> These two types of LEDs are widely used in routers and NICs. The
> RSSI (Received Signal Strength Indicator) LED is used to display
> the Wi-Fi signal strength, and the Internet LED can indicate
> whether the device can access a specific server.
>
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> ---
> include/dt-bindings/leds/common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 9a0d33d02..55a426e39 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -88,11 +88,13 @@
> #define LED_FUNCTION_FLASH "flash"
> #define LED_FUNCTION_HEARTBEAT "heartbeat"
> #define LED_FUNCTION_INDICATOR "indicator"
> +#define LED_FUNCTION_INTERNET "internet"
Duplicate of 'wan'.
> #define LED_FUNCTION_LAN "lan"
> #define LED_FUNCTION_MAIL "mail"
> #define LED_FUNCTION_MTD "mtd"
> #define LED_FUNCTION_PANIC "panic"
> #define LED_FUNCTION_PROGRAMMING "programming"
> +#define LED_FUNCTION_RSSI "rssi"
'rx' or 'wlan'?
Wouldn't you need multiple LEDs to indicate signal strength? Maybe
'signal' or something would be more generic?
> #define LED_FUNCTION_RX "rx"
> #define LED_FUNCTION_SD "sd"
> #define LED_FUNCTION_STANDBY "standby"
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-10-31 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231031132901.11732-1-yangshiji66@outlook.com>
2023-10-31 13:29 ` [PATCH v2 1/2] leds: core: add missing LED color strings Shiji Yang
2023-11-01 11:35 ` Jisheng Zhang
2023-10-31 13:29 ` [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions Shiji Yang
2023-10-31 18:03 ` Rob Herring [this message]
2023-11-01 1:47 ` Shiji Yang
2023-11-01 14:49 ` Rob Herring
2023-11-06 23:34 Rani Hod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031180305.GA1813504-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oliver@schinagl.nl \
--cc=pavel@ucw.cz \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.