From: Jisheng Zhang <jszhang@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Olliver Schinagl <oliver@schinagl.nl>
Subject: Re: [PATCH v2 1/2] leds: core: add missing LED color strings
Date: Wed, 1 Nov 2023 19:35:47 +0800 [thread overview]
Message-ID: <ZUI4E06PYez5Z5LI@xhacker> (raw)
In-Reply-To: <TYAP286MB03159A83A77E6FD59F271D9BBCA0A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
On Tue, Oct 31, 2023 at 09:29:00PM +0800, Shiji Yang wrote:
> Some new monochromatic LEDs have been introduced into DT bindings,
> but they do not have corresponding descriptions on the led_colors
> structure. This patch adds the missing LED color strings.
>
> Fixes: 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID definitions")
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> ---
> drivers/leds/led-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> index 214ed81eb..223023928 100644
> --- a/drivers/leds/led-core.c
> +++ b/drivers/leds/led-core.c
> @@ -36,6 +36,11 @@ const char * const led_colors[LED_COLOR_ID_MAX] = {
> [LED_COLOR_ID_IR] = "ir",
> [LED_COLOR_ID_MULTI] = "multicolor",
> [LED_COLOR_ID_RGB] = "rgb",
> + [LED_COLOR_ID_PURPLE] = "purple",
> + [LED_COLOR_ID_ORANGE] = "orange",
> + [LED_COLOR_ID_PINK] = "pink",
> + [LED_COLOR_ID_CYAN] = "cyan",
> + [LED_COLOR_ID_LIME] = "lime",
A similar patch was sent out two days ago, earlier than yours ;)
https://lore.kernel.org/linux-leds/20231030054757.3476-1-jszhang@kernel.org/
> };
> EXPORT_SYMBOL_GPL(led_colors);
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-11-01 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231031132901.11732-1-yangshiji66@outlook.com>
2023-10-31 13:29 ` [PATCH v2 1/2] leds: core: add missing LED color strings Shiji Yang
2023-11-01 11:35 ` Jisheng Zhang [this message]
2023-10-31 13:29 ` [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions Shiji Yang
2023-10-31 18:03 ` Rob Herring
2023-11-01 1:47 ` Shiji Yang
2023-11-01 14:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUI4E06PYez5Z5LI@xhacker \
--to=jszhang@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oliver@schinagl.nl \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.