All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
Cc: dillon.varone@amd.com, george.shen@amd.com, sunpeng.li@amd.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	alexander.deucher@amd.com, aurabindo.pillai@amd.com,
	samson.tam@amd.com, daniel@ffwll.ch, SyedSaaem.Rizvi@amd.com,
	stable@vger.kernel.org, airlied@gmail.com, Jun.Lei@amd.com,
	harry.wentland@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Tue, 31 Oct 2023 13:20:24 +0100	[thread overview]
Message-ID: <2023103141-clear-scale-897a@gregkh> (raw)
In-Reply-To: <3ab58c1e48447798d7525e7d2f42f1a2@foxhound.fi>

On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
> On 2023-10-31 07:48, Greg KH wrote:
> > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
> > > This patch addresses the following warning spotted by
> > > using coccinelle where the case checked does the same
> > > than the else case.
> > > 
> > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
> > > WARNING: possible condition with no effect (if == else)
> > > 
> > > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in
> > > DCN32")
> > > 
> > > Cc: stable@vger.kernel.org
> > 
> > Why is this relevant for stable?
> 
>     Hi,
> 
>     I was asked to send it for stable because this code
> looks different in amd-staging-drm-next, see here.
> 
> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c#L4661

I don't know what I am looking at, sorry.

>     Feel free to let me know if this is wrong, or if I
> need to review some other guidelines I may have missed.

Please see the list of rules for stable patches:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Does "remove code that does nothing" fit here?

thanks,

greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
Cc: harry.wentland@amd.com, sunpeng.li@amd.com,
	Rodrigo.Siqueira@amd.com, skhan@linuxfoundation.org,
	dillon.varone@amd.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
	linux-kernel@vger.kernel.org, samson.tam@amd.com,
	SyedSaaem.Rizvi@amd.com, aurabindo.pillai@amd.com,
	stable@vger.kernel.org, daniel@ffwll.ch, george.shen@amd.com,
	alexander.deucher@amd.com, Jun.Lei@amd.com, airlied@gmail.com,
	christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Tue, 31 Oct 2023 13:20:24 +0100	[thread overview]
Message-ID: <2023103141-clear-scale-897a@gregkh> (raw)
In-Reply-To: <3ab58c1e48447798d7525e7d2f42f1a2@foxhound.fi>

On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
> On 2023-10-31 07:48, Greg KH wrote:
> > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
> > > This patch addresses the following warning spotted by
> > > using coccinelle where the case checked does the same
> > > than the else case.
> > > 
> > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
> > > WARNING: possible condition with no effect (if == else)
> > > 
> > > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in
> > > DCN32")
> > > 
> > > Cc: stable@vger.kernel.org
> > 
> > Why is this relevant for stable?
> 
>     Hi,
> 
>     I was asked to send it for stable because this code
> looks different in amd-staging-drm-next, see here.
> 
> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c#L4661

I don't know what I am looking at, sorry.

>     Feel free to let me know if this is wrong, or if I
> need to review some other guidelines I may have missed.

Please see the list of rules for stable patches:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Does "remove code that does nothing" fit here?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
Cc: dillon.varone@amd.com, george.shen@amd.com, sunpeng.li@amd.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	alexander.deucher@amd.com, aurabindo.pillai@amd.com,
	samson.tam@amd.com, skhan@linuxfoundation.org,
	SyedSaaem.Rizvi@amd.com, stable@vger.kernel.org, Jun.Lei@amd.com,
	christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Tue, 31 Oct 2023 13:20:24 +0100	[thread overview]
Message-ID: <2023103141-clear-scale-897a@gregkh> (raw)
In-Reply-To: <3ab58c1e48447798d7525e7d2f42f1a2@foxhound.fi>

On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
> On 2023-10-31 07:48, Greg KH wrote:
> > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
> > > This patch addresses the following warning spotted by
> > > using coccinelle where the case checked does the same
> > > than the else case.
> > > 
> > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
> > > WARNING: possible condition with no effect (if == else)
> > > 
> > > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in
> > > DCN32")
> > > 
> > > Cc: stable@vger.kernel.org
> > 
> > Why is this relevant for stable?
> 
>     Hi,
> 
>     I was asked to send it for stable because this code
> looks different in amd-staging-drm-next, see here.
> 
> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c#L4661

I don't know what I am looking at, sorry.

>     Feel free to let me know if this is wrong, or if I
> need to review some other guidelines I may have missed.

Please see the list of rules for stable patches:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Does "remove code that does nothing" fit here?

thanks,

greg k-h

  reply	other threads:[~2023-10-31 12:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 17:17 [PATCH] drm/amd/display: remove redundant check José Pekkarinen
2023-10-30 17:17 ` José Pekkarinen
2023-10-30 17:17 ` José Pekkarinen
2023-10-30 17:39 ` Aurabindo Pillai via Linux-kernel-mentees
2023-10-30 17:39   ` Aurabindo Pillai
2023-10-30 17:39   ` Aurabindo Pillai
2023-10-31  5:48 ` Greg KH
2023-10-31  5:48   ` Greg KH
2023-10-31  5:48   ` Greg KH
2023-10-31 11:42   ` José Pekkarinen
2023-10-31 11:42     ` José Pekkarinen
2023-10-31 11:42     ` José Pekkarinen
2023-10-31 12:20     ` Greg KH [this message]
2023-10-31 12:20       ` Greg KH
2023-10-31 12:20       ` Greg KH
2023-10-31 12:32       ` José Pekkarinen
2023-10-31 12:32         ` José Pekkarinen
2023-10-31 12:32         ` José Pekkarinen
2023-10-31 16:41         ` Aurabindo Pillai via Linux-kernel-mentees
2023-10-31 16:41           ` Aurabindo Pillai
2023-10-31 16:41           ` Aurabindo Pillai
  -- strict thread matches above, loose matches on Subject: below --
2023-10-30 17:04 José Pekkarinen
2023-10-30 17:04 ` José Pekkarinen
2023-10-30 17:04 ` José Pekkarinen
2023-10-30 17:11 ` kernel test robot
2023-10-29 12:44 José Pekkarinen
2023-10-29 12:44 ` José Pekkarinen
2023-10-29 12:44 ` José Pekkarinen
2023-10-29 12:44 ` José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai
2023-10-30 13:52   ` Aurabindo Pillai
2023-10-30 13:52   ` Aurabindo Pillai
2023-10-30 13:52   ` Aurabindo Pillai via Linux-kernel-mentees
2023-10-30 16:26   ` José Pekkarinen
2023-10-30 16:26     ` José Pekkarinen
2023-10-30 16:26     ` José Pekkarinen
2023-10-30 16:26     ` José Pekkarinen
2023-10-30 16:53     ` Aurabindo Pillai
2023-10-30 16:53       ` Aurabindo Pillai
2023-10-30 16:53       ` Aurabindo Pillai
2023-10-30 16:53       ` Aurabindo Pillai via Linux-kernel-mentees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023103141-clear-scale-897a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Jun.Lei@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=SyedSaaem.Rizvi@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=aurabindo.pillai@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dillon.varone@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=george.shen@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=jose.pekkarinen@foxhound.fi \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samson.tam@amd.com \
    --cc=stable@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.