From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/monit: fix build without SSP
Date: Wed, 1 Nov 2023 23:40:57 +0100 [thread overview]
Message-ID: <20231101234057.5f792112@windsurf> (raw)
In-Reply-To: <20231015210027.1587075-1-fontaine.fabrice@gmail.com>
On Sun, 15 Oct 2023 23:00:27 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix build without SSP raised since bump to version 5.33.0 in commit
> 8cedb39764f70f9d467bf0cc1acc99a8bbb963d6:
>
> configure:10524: checking for pthread_create in -lpthread
> configure:10547: /home/thomas/autobuild/instance-1/output-1/host/bin/arceb-buildroot-linux-uclibc-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Ofast -g0 -static -Wextra -fstack-protector-all -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -lpthread >&5
> /home/thomas/autobuild/instance-1/output-1/host/lib/gcc/arceb-buildroot-linux-uclibc/10.2.0/../../../../arceb-buildroot-linux-uclibc/bin/ld: cannot find -lssp_nonshared
>
> [...]
>
> checking for pthread_create in -lpthread... no
> configure: error: POSIX thread library is required
>
> Fixes:
> - http://autobuild.buildroot.org/results/ce0f9f62d60f801b03a079135941424ad147cf45
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/monit/monit.mk | 1 +
> 1 file changed, 1 insertion(+)
I've applied, because we do the same in other packages, but I'm not
sure that what we're doing is correct. Indeed, BR2_TOOLCHAIN_HAS_SPP
only says whether the toolchain has SSP support, not whether we want to
use as part of the Buildroot build, which is controlled by the
BR2_SSP_NONE, BR2_SSP_REGULAR, BR2_SSP_STRONG, BR2_SSP_ALL options. So
should we switch to looking at those options instead?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-01 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 21:00 [Buildroot] [PATCH 1/1] package/monit: fix build without SSP Fabrice Fontaine
2023-11-01 22:40 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101234057.5f792112@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.