[Buildroot] [PATCH 1/1] package/monit: fix build without SSP

[Buildroot] [PATCH 1/1] package/monit: fix build without SSP

[Fabrice Fontaine]

Fix build without SSP raised since bump to version 5.33.0 in commit
8cedb39764f70f9d467bf0cc1acc99a8bbb963d6:

configure:10524: checking for pthread_create in -lpthread
configure:10547: /home/thomas/autobuild/instance-1/output-1/host/bin/arceb-buildroot-linux-uclibc-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Ofast -g0  -static -Wextra -fstack-protector-all -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static conftest.c -lpthread   >&5
/home/thomas/autobuild/instance-1/output-1/host/lib/gcc/arceb-buildroot-linux-uclibc/10.2.0/../../../../arceb-buildroot-linux-uclibc/bin/ld: cannot find -lssp_nonshared

[...]

checking for pthread_create in -lpthread... no
configure: error: POSIX thread library is required

Fixes:
 - http://autobuild.buildroot.org/results/ce0f9f62d60f801b03a079135941424ad147cf45

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/monit/monit.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/monit/monit.mk b/package/monit/monit.mk
index f9d6617a54..4766ce3d9e 100644
--- a/package/monit/monit.mk
+++ b/package/monit/monit.mk
@@ -18,6 +18,7 @@ MONIT_AUTORECONF = YES
 MONIT_CONF_ENV = \
 	libmonit_cv_setjmp_available=yes \
 	libmonit_cv_vsnprintf_c99_conformant=yes \
+	ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) \
 	ac_cv_ipv6=yes
 
 MONIT_CONF_OPTS += \
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/monit: fix build without SSP

[Thomas Petazzoni via buildroot]

On Sun, 15 Oct 2023 23:00:27 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix build without SSP raised since bump to version 5.33.0 in commit
> 8cedb39764f70f9d467bf0cc1acc99a8bbb963d6:
> 
> configure:10524: checking for pthread_create in -lpthread
> configure:10547: /home/thomas/autobuild/instance-1/output-1/host/bin/arceb-buildroot-linux-uclibc-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Ofast -g0  -static -Wextra -fstack-protector-all -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static conftest.c -lpthread   >&5
> /home/thomas/autobuild/instance-1/output-1/host/lib/gcc/arceb-buildroot-linux-uclibc/10.2.0/../../../../arceb-buildroot-linux-uclibc/bin/ld: cannot find -lssp_nonshared
> 
> [...]
> 
> checking for pthread_create in -lpthread... no
> configure: error: POSIX thread library is required
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/ce0f9f62d60f801b03a079135941424ad147cf45
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/monit/monit.mk | 1 +
>  1 file changed, 1 insertion(+)

I've applied, because we do the same in other packages, but I'm not
sure that what we're doing is correct. Indeed, BR2_TOOLCHAIN_HAS_SPP
only says whether the toolchain has SSP support, not whether we want to
use as part of the Buildroot build, which is controlled by the
BR2_SSP_NONE, BR2_SSP_REGULAR, BR2_SSP_STRONG, BR2_SSP_ALL options. So
should we switch to looking at those options instead?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot