* [djwong-xfs:file-force-align 506/507] fs/xfs/xfs_bmap_util.c:1450:9: error: implicit declaration of function 'trace_xfs_convert_bigalloc_file_space'; did you mean 'xfs_convert_bigalloc_file_space'?
@ 2023-11-02 13:23 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-11-02 13:23 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git file-force-align
head: 2f5d0685694a329d50ad1988293dc3f838d798ed
commit: 9560af7afefad8ce14877a40e356fb869ca7c785 [506/507] xfs: support reflink with force align enabled
config: powerpc64-randconfig-002-20231102 (https://download.01.org/0day-ci/archive/20231102/202311022124.PIIRVz7e-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311022124.PIIRVz7e-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311022124.PIIRVz7e-lkp@intel.com/
All errors (new ones prefixed by >>):
fs/xfs/xfs_bmap_util.c: In function 'xfs_convert_bigalloc_file_space':
>> fs/xfs/xfs_bmap_util.c:1450:9: error: implicit declaration of function 'trace_xfs_convert_bigalloc_file_space'; did you mean 'xfs_convert_bigalloc_file_space'? [-Werror=implicit-function-declaration]
1450 | trace_xfs_convert_bigalloc_file_space(ip, pos, len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| xfs_convert_bigalloc_file_space
cc1: some warnings being treated as errors
vim +1450 fs/xfs/xfs_bmap_util.c
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1415
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1416 /*
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1417 * Prepare a file with multi-fsblock allocation units for a remapping.
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1418 *
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1419 * File allocation units (AU) must be fully mapped to the data fork. If the
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1420 * space in an AU have not been fully written, there can be multiple extent
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1421 * mappings (e.g. mixed written and unwritten blocks) to the AU. If the log
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1422 * does not have a means to ensure that all remappings for a given AU will be
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1423 * completed even if the fs goes down, we must maintain the above constraint in
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1424 * another way.
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1425 *
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1426 * Convert the unwritten parts of an AU to written by writing zeroes to the
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1427 * storage and flipping the mapping. Once this completes, there will be a
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1428 * single mapping for the entire AU, and we can proceed with the remapping
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1429 * operation.
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1430 *
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1431 * Callers must ensure that there are no dirty pages in the given range.
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1432 */
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1433 int
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1434 xfs_convert_bigalloc_file_space(
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1435 struct xfs_inode *ip,
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1436 loff_t pos,
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1437 uint64_t len)
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1438 {
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1439 struct xfs_mount *mp = ip->i_mount;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1440 xfs_fileoff_t off;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1441 xfs_fileoff_t endoff;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1442 int error;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1443
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1444 if (!xfs_inode_has_bigallocunit(ip))
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1445 return 0;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1446
f05b39e060631e Darrick J. Wong 2023-03-06 1447 off = xfs_rtb_rounddown_rtx(mp, XFS_B_TO_FSBT(mp, pos));
f05b39e060631e Darrick J. Wong 2023-03-06 1448 endoff = xfs_rtb_roundup_rtx(mp, XFS_B_TO_FSB(mp, pos + len));
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1449
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 @1450 trace_xfs_convert_bigalloc_file_space(ip, pos, len);
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1451
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1452 while (off < endoff) {
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1453 if (fatal_signal_pending(current))
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1454 return -EINTR;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1455
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1456 error = xfs_convert_bigalloc_mapping(ip, &off, endoff);
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1457 if (error)
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1458 return error;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1459 }
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1460
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1461 return 0;
d0c6e4b2d648b8 Darrick J. Wong 2023-03-06 1462 }
2f1c2bb5cdbcf6 Darrick J. Wong 2023-03-06 1463
:::::: The code at line 1450 was first introduced by commit
:::::: d0c6e4b2d648b8ae0382bb9e56bbf8c88e438646 xfs: make atomic extent swapping support realtime files
:::::: TO: Darrick J. Wong <djwong@kernel.org>
:::::: CC: Darrick J. Wong <djwong@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-02 13:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02 13:23 [djwong-xfs:file-force-align 506/507] fs/xfs/xfs_bmap_util.c:1450:9: error: implicit declaration of function 'trace_xfs_convert_bigalloc_file_space'; did you mean 'xfs_convert_bigalloc_file_space'? kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.