From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.
Date: Sat, 4 Nov 2023 14:44:42 +0800 [thread overview]
Message-ID: <202311041422.GVJSFjzN-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Ard Biesheuvel <ardb@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90b0c2b2edd1adff742c621e246562fbefa11b70
commit: b7a1cd243839cc1459fbc83a7a62e3b57f29f497 efi/earlycon: Replace open coded strnchrnul()
date: 10 months ago
:::::: branch date: 82 minutes ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-161-20231102 (https://download.01.org/0day-ci/archive/20231104/202311041422.GVJSFjzN-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20231104/202311041422.GVJSFjzN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311041422.GVJSFjzN-lkp@intel.com/
smatch warnings:
drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.
vim +/s +178 drivers/firmware/efi/earlycon.c
69c1f396f25b80 Ard Biesheuvel 2019-02-02 134
69c1f396f25b80 Ard Biesheuvel 2019-02-02 135 static void
69c1f396f25b80 Ard Biesheuvel 2019-02-02 136 efi_earlycon_write(struct console *con, const char *str, unsigned int num)
69c1f396f25b80 Ard Biesheuvel 2019-02-02 137 {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 138 struct screen_info *si;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 139 unsigned int len;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 140 const char *s;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 141 void *dst;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 142
69c1f396f25b80 Ard Biesheuvel 2019-02-02 143 si = &screen_info;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 144 len = si->lfb_linelength;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 145
69c1f396f25b80 Ard Biesheuvel 2019-02-02 146 while (num) {
b7a1cd243839cc Andy Shevchenko 2022-12-09 147 unsigned int linemax = (si->lfb_width - efi_x) / font->width;
b7a1cd243839cc Andy Shevchenko 2022-12-09 148 unsigned int h, count;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 149
b7a1cd243839cc Andy Shevchenko 2022-12-09 150 count = strnchrnul(str, num, '\n') - str;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 151 if (count > linemax)
69c1f396f25b80 Ard Biesheuvel 2019-02-02 152 count = linemax;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 153
69c1f396f25b80 Ard Biesheuvel 2019-02-02 154 for (h = 0; h < font->height; h++) {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 155 unsigned int n, x;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 156
69c1f396f25b80 Ard Biesheuvel 2019-02-02 157 dst = efi_earlycon_map((efi_y + h) * len, len);
69c1f396f25b80 Ard Biesheuvel 2019-02-02 158 if (!dst)
69c1f396f25b80 Ard Biesheuvel 2019-02-02 159 return;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 160
69c1f396f25b80 Ard Biesheuvel 2019-02-02 161 s = str;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 162 n = count;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 163 x = efi_x;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 164
69c1f396f25b80 Ard Biesheuvel 2019-02-02 165 while (n-- > 0) {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 166 efi_earlycon_write_char(dst + x*4, *s, h);
69c1f396f25b80 Ard Biesheuvel 2019-02-02 167 x += font->width;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 168 s++;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 169 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 170
69c1f396f25b80 Ard Biesheuvel 2019-02-02 171 efi_earlycon_unmap(dst, len);
69c1f396f25b80 Ard Biesheuvel 2019-02-02 172 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 173
69c1f396f25b80 Ard Biesheuvel 2019-02-02 174 num -= count;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 175 efi_x += count * font->width;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 176 str += count;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 177
69c1f396f25b80 Ard Biesheuvel 2019-02-02 @178 if (num > 0 && *s == '\n') {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 179 efi_x = 0;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 180 efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 181 str++;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 182 num--;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 183 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 184
69c1f396f25b80 Ard Biesheuvel 2019-02-02 185 if (efi_x + font->width > si->lfb_width) {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 186 efi_x = 0;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 187 efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 188 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 189
69c1f396f25b80 Ard Biesheuvel 2019-02-02 190 if (efi_y + font->height > si->lfb_height) {
69c1f396f25b80 Ard Biesheuvel 2019-02-02 191 u32 i;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 192
69c1f396f25b80 Ard Biesheuvel 2019-02-02 193 efi_y -= font->height;
69c1f396f25b80 Ard Biesheuvel 2019-02-02 194 efi_earlycon_scroll_up();
69c1f396f25b80 Ard Biesheuvel 2019-02-02 195
69c1f396f25b80 Ard Biesheuvel 2019-02-02 196 for (i = 0; i < font->height; i++)
69c1f396f25b80 Ard Biesheuvel 2019-02-02 197 efi_earlycon_clear_scanline(efi_y + i);
69c1f396f25b80 Ard Biesheuvel 2019-02-02 198 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 199 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 200 }
69c1f396f25b80 Ard Biesheuvel 2019-02-02 201
:::::: The code at line 178 was first introduced by commit
:::::: 69c1f396f25b805aeff08f06d2e992c315ee5b1e efi/x86: Convert x86 EFI earlyprintk into generic earlycon implementation
:::::: TO: Ard Biesheuvel <ard.biesheuvel@linaro.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-11-04 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 6:44 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-05 12:02 drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's' kernel test robot
2023-02-26 12:27 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311041422.GVJSFjzN-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.