All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.
@ 2023-02-26 12:27 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-02-26 12:27 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Ard Biesheuvel <ardb@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
commit: b7a1cd243839cc1459fbc83a7a62e3b57f29f497 efi/earlycon: Replace open coded strnchrnul()
date:   7 weeks ago
:::::: branch date: 8 hours ago
:::::: commit date: 7 weeks ago
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20230226/202302262047.z95WyxLH-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302262047.z95WyxLH-lkp@intel.com/

smatch warnings:
drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.

vim +/s +178 drivers/firmware/efi/earlycon.c

69c1f396f25b80 Ard Biesheuvel  2019-02-02  134  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  135  static void
69c1f396f25b80 Ard Biesheuvel  2019-02-02  136  efi_earlycon_write(struct console *con, const char *str, unsigned int num)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  137  {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  138  	struct screen_info *si;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  139  	unsigned int len;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  140  	const char *s;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  141  	void *dst;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  142  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  143  	si = &screen_info;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  144  	len = si->lfb_linelength;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  145  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  146  	while (num) {
b7a1cd243839cc Andy Shevchenko 2022-12-09  147  		unsigned int linemax = (si->lfb_width - efi_x) / font->width;
b7a1cd243839cc Andy Shevchenko 2022-12-09  148  		unsigned int h, count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  149  
b7a1cd243839cc Andy Shevchenko 2022-12-09  150  		count = strnchrnul(str, num, '\n') - str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  151  		if (count > linemax)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  152  			count = linemax;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  153  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  154  		for (h = 0; h < font->height; h++) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  155  			unsigned int n, x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  156  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  157  			dst = efi_earlycon_map((efi_y + h) * len, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  158  			if (!dst)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  159  				return;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  160  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  161  			s = str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  162  			n = count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  163  			x = efi_x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  164  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  165  			while (n-- > 0) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  166  				efi_earlycon_write_char(dst + x*4, *s, h);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  167  				x += font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  168  				s++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  169  			}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  170  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  171  			efi_earlycon_unmap(dst, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  172  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  173  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  174  		num -= count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  175  		efi_x += count * font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  176  		str += count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  177  
69c1f396f25b80 Ard Biesheuvel  2019-02-02 @178  		if (num > 0 && *s == '\n') {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  179  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  180  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  181  			str++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  182  			num--;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  183  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  184  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  185  		if (efi_x + font->width > si->lfb_width) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  186  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  187  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  188  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  189  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  190  		if (efi_y + font->height > si->lfb_height) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  191  			u32 i;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  192  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  193  			efi_y -= font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  194  			efi_earlycon_scroll_up();
69c1f396f25b80 Ard Biesheuvel  2019-02-02  195  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  196  			for (i = 0; i < font->height; i++)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  197  				efi_earlycon_clear_scanline(efi_y + i);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  198  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  199  	}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  200  }
69c1f396f25b80 Ard Biesheuvel  2019-02-02  201  

:::::: The code at line 178 was first introduced by commit
:::::: 69c1f396f25b805aeff08f06d2e992c315ee5b1e efi/x86: Convert x86 EFI earlyprintk into generic earlycon implementation

:::::: TO: Ard Biesheuvel <ard.biesheuvel@linaro.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 3+ messages in thread

* drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.
@ 2023-11-04  6:44 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-11-04  6:44 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Ard Biesheuvel <ardb@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   90b0c2b2edd1adff742c621e246562fbefa11b70
commit: b7a1cd243839cc1459fbc83a7a62e3b57f29f497 efi/earlycon: Replace open coded strnchrnul()
date:   10 months ago
:::::: branch date: 82 minutes ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-161-20231102 (https://download.01.org/0day-ci/archive/20231104/202311041422.GVJSFjzN-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20231104/202311041422.GVJSFjzN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311041422.GVJSFjzN-lkp@intel.com/

smatch warnings:
drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.

vim +/s +178 drivers/firmware/efi/earlycon.c

69c1f396f25b80 Ard Biesheuvel  2019-02-02  134  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  135  static void
69c1f396f25b80 Ard Biesheuvel  2019-02-02  136  efi_earlycon_write(struct console *con, const char *str, unsigned int num)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  137  {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  138  	struct screen_info *si;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  139  	unsigned int len;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  140  	const char *s;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  141  	void *dst;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  142  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  143  	si = &screen_info;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  144  	len = si->lfb_linelength;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  145  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  146  	while (num) {
b7a1cd243839cc Andy Shevchenko 2022-12-09  147  		unsigned int linemax = (si->lfb_width - efi_x) / font->width;
b7a1cd243839cc Andy Shevchenko 2022-12-09  148  		unsigned int h, count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  149  
b7a1cd243839cc Andy Shevchenko 2022-12-09  150  		count = strnchrnul(str, num, '\n') - str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  151  		if (count > linemax)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  152  			count = linemax;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  153  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  154  		for (h = 0; h < font->height; h++) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  155  			unsigned int n, x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  156  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  157  			dst = efi_earlycon_map((efi_y + h) * len, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  158  			if (!dst)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  159  				return;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  160  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  161  			s = str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  162  			n = count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  163  			x = efi_x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  164  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  165  			while (n-- > 0) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  166  				efi_earlycon_write_char(dst + x*4, *s, h);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  167  				x += font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  168  				s++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  169  			}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  170  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  171  			efi_earlycon_unmap(dst, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  172  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  173  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  174  		num -= count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  175  		efi_x += count * font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  176  		str += count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  177  
69c1f396f25b80 Ard Biesheuvel  2019-02-02 @178  		if (num > 0 && *s == '\n') {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  179  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  180  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  181  			str++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  182  			num--;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  183  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  184  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  185  		if (efi_x + font->width > si->lfb_width) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  186  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  187  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  188  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  189  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  190  		if (efi_y + font->height > si->lfb_height) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  191  			u32 i;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  192  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  193  			efi_y -= font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  194  			efi_earlycon_scroll_up();
69c1f396f25b80 Ard Biesheuvel  2019-02-02  195  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  196  			for (i = 0; i < font->height; i++)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  197  				efi_earlycon_clear_scanline(efi_y + i);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  198  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  199  	}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  200  }
69c1f396f25b80 Ard Biesheuvel  2019-02-02  201  

:::::: The code at line 178 was first introduced by commit
:::::: 69c1f396f25b805aeff08f06d2e992c315ee5b1e efi/x86: Convert x86 EFI earlyprintk into generic earlycon implementation

:::::: TO: Ard Biesheuvel <ard.biesheuvel@linaro.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread

* drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.
@ 2023-11-05 12:02 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-11-05 12:02 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Ard Biesheuvel <ardb@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1c41041124bd14dd6610da256a3da4e5b74ce6b1
commit: b7a1cd243839cc1459fbc83a7a62e3b57f29f497 efi/earlycon: Replace open coded strnchrnul()
date:   10 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-161-20231102 (https://download.01.org/0day-ci/archive/20231105/202311051902.SLvPrO9f-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20231105/202311051902.SLvPrO9f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311051902.SLvPrO9f-lkp@intel.com/

smatch warnings:
drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's'.

vim +/s +178 drivers/firmware/efi/earlycon.c

69c1f396f25b80 Ard Biesheuvel  2019-02-02  134  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  135  static void
69c1f396f25b80 Ard Biesheuvel  2019-02-02  136  efi_earlycon_write(struct console *con, const char *str, unsigned int num)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  137  {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  138  	struct screen_info *si;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  139  	unsigned int len;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  140  	const char *s;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  141  	void *dst;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  142  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  143  	si = &screen_info;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  144  	len = si->lfb_linelength;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  145  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  146  	while (num) {
b7a1cd243839cc Andy Shevchenko 2022-12-09  147  		unsigned int linemax = (si->lfb_width - efi_x) / font->width;
b7a1cd243839cc Andy Shevchenko 2022-12-09  148  		unsigned int h, count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  149  
b7a1cd243839cc Andy Shevchenko 2022-12-09  150  		count = strnchrnul(str, num, '\n') - str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  151  		if (count > linemax)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  152  			count = linemax;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  153  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  154  		for (h = 0; h < font->height; h++) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  155  			unsigned int n, x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  156  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  157  			dst = efi_earlycon_map((efi_y + h) * len, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  158  			if (!dst)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  159  				return;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  160  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  161  			s = str;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  162  			n = count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  163  			x = efi_x;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  164  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  165  			while (n-- > 0) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  166  				efi_earlycon_write_char(dst + x*4, *s, h);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  167  				x += font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  168  				s++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  169  			}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  170  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  171  			efi_earlycon_unmap(dst, len);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  172  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  173  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  174  		num -= count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  175  		efi_x += count * font->width;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  176  		str += count;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  177  
69c1f396f25b80 Ard Biesheuvel  2019-02-02 @178  		if (num > 0 && *s == '\n') {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  179  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  180  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  181  			str++;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  182  			num--;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  183  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  184  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  185  		if (efi_x + font->width > si->lfb_width) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  186  			efi_x = 0;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  187  			efi_y += font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  188  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  189  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  190  		if (efi_y + font->height > si->lfb_height) {
69c1f396f25b80 Ard Biesheuvel  2019-02-02  191  			u32 i;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  192  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  193  			efi_y -= font->height;
69c1f396f25b80 Ard Biesheuvel  2019-02-02  194  			efi_earlycon_scroll_up();
69c1f396f25b80 Ard Biesheuvel  2019-02-02  195  
69c1f396f25b80 Ard Biesheuvel  2019-02-02  196  			for (i = 0; i < font->height; i++)
69c1f396f25b80 Ard Biesheuvel  2019-02-02  197  				efi_earlycon_clear_scanline(efi_y + i);
69c1f396f25b80 Ard Biesheuvel  2019-02-02  198  		}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  199  	}
69c1f396f25b80 Ard Biesheuvel  2019-02-02  200  }
69c1f396f25b80 Ard Biesheuvel  2019-02-02  201  

:::::: The code at line 178 was first introduced by commit
:::::: 69c1f396f25b805aeff08f06d2e992c315ee5b1e efi/x86: Convert x86 EFI earlyprintk into generic earlycon implementation

:::::: TO: Ard Biesheuvel <ard.biesheuvel@linaro.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-05 12:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-04  6:44 drivers/firmware/efi/earlycon.c:178 efi_earlycon_write() error: potentially dereferencing uninitialized 's' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-11-05 12:02 kernel test robot
2023-02-26 12:27 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.