[Intel-xe] [PATCH 0/5] mei: hdcp/pxp: adapt for Xe driver

All of lore.kernel.org
 help / color / mirror / Atom feed

* [Intel-xe] [PATCH 0/5] mei: hdcp/pxp: adapt for Xe driver
@ 2023-11-07 13:46 ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

Update mei-hdcp and mei-pxp drivers to work with Xe driver
alongside with i195 driver.
Revert previous partial attempt.
Update match functions to match without driver name
and update module dependencies to optionally depend on Xe.

Alexander Usyskin (5):
  Revert "mei/hdcp: Also enable for XE"
  mei: hdcp: match without driver name
  mei: pxp: match without driver name
  mei: hdcp: add dependency on Xe driver
  mei: pxp: add dependency on Xe driver

 drivers/misc/mei/hdcp/mei_hdcp.c | 15 ++++++++++++---
 drivers/misc/mei/pxp/Kconfig     |  3 +--
 drivers/misc/mei/pxp/mei_pxp.c   | 14 ++++++++++++--
 3 files changed, 25 insertions(+), 7 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] mei: hdcp/pxp: adapt for Xe driver
@ 2023-11-07 13:46 ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

Update mei-hdcp and mei-pxp drivers to work with Xe driver
alongside with i195 driver.
Revert previous partial attempt.
Update match functions to match without driver name
and update module dependencies to optionally depend on Xe.

Alexander Usyskin (5):
  Revert "mei/hdcp: Also enable for XE"
  mei: hdcp: match without driver name
  mei: pxp: match without driver name
  mei: hdcp: add dependency on Xe driver
  mei: pxp: add dependency on Xe driver

 drivers/misc/mei/hdcp/mei_hdcp.c | 15 ++++++++++++---
 drivers/misc/mei/pxp/Kconfig     |  3 +--
 drivers/misc/mei/pxp/mei_pxp.c   | 14 ++++++++++++--
 3 files changed, 25 insertions(+), 7 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [Intel-xe] [PATCH 1/5] Revert "mei/hdcp: Also enable for XE"
  2023-11-07 13:46 ` Alexander Usyskin
@ 2023-11-07 13:46   ` Alexander Usyskin
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

This reverts commit 62db7d00efe48c614b006086f306d5addedf8f83.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/Kconfig    | 2 +-
 drivers/misc/mei/hdcp/mei_hdcp.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 2ac9148988d4..54e1c9526909 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -4,7 +4,7 @@
 config INTEL_MEI_HDCP
 	tristate "Intel HDCP2.2 services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915 || DRM_XE
+	depends on DRM_I915
 	help
 	  MEI Support for HDCP2.2 Services on Intel platforms.
 
diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 94beb5667faa..51359cc5ece9 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -782,8 +782,7 @@ static int mei_hdcp_component_match(struct device *dev, int subcomponent,
 {
 	struct device *base = data;
 
-	if (!dev->driver ||
-	    (strcmp(dev->driver->name, "i915") && strcmp(dev->driver->name, "xe")) ||
+	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
 	    subcomponent != I915_COMPONENT_HDCP)
 		return 0;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 1/5] Revert "mei/hdcp: Also enable for XE"
@ 2023-11-07 13:46   ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

This reverts commit 62db7d00efe48c614b006086f306d5addedf8f83.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/Kconfig    | 2 +-
 drivers/misc/mei/hdcp/mei_hdcp.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 2ac9148988d4..54e1c9526909 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -4,7 +4,7 @@
 config INTEL_MEI_HDCP
 	tristate "Intel HDCP2.2 services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915 || DRM_XE
+	depends on DRM_I915
 	help
 	  MEI Support for HDCP2.2 Services on Intel platforms.
 
diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 94beb5667faa..51359cc5ece9 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -782,8 +782,7 @@ static int mei_hdcp_component_match(struct device *dev, int subcomponent,
 {
 	struct device *base = data;
 
-	if (!dev->driver ||
-	    (strcmp(dev->driver->name, "i915") && strcmp(dev->driver->name, "xe")) ||
+	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
 	    subcomponent != I915_COMPONENT_HDCP)
 		return 0;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [Intel-xe] [PATCH 1/5] Revert "mei/hdcp: Also enable for XE"
  2023-11-07 13:46   ` Alexander Usyskin
@ 2023-11-07 14:10     ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:10 UTC (permalink / raw)
  To: Alexander Usyskin
  Cc: Lucas De Marchi, linux-kernel, Rodrigo Vivi, Tomas Winkler,
	intel-xe

On Tue, Nov 07, 2023 at 03:46:02PM +0200, Alexander Usyskin wrote:
> This reverts commit 62db7d00efe48c614b006086f306d5addedf8f83.

That says what you did, but not why you did it, which means I can't take
this, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/5] Revert "mei/hdcp: Also enable for XE"
@ 2023-11-07 14:10     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:10 UTC (permalink / raw)
  To: Alexander Usyskin
  Cc: Lucas De Marchi, Daniele Ceraolo Spurio, Rodrigo Vivi,
	Tomas Winkler, Vitaly Lubart, intel-xe, linux-kernel

On Tue, Nov 07, 2023 at 03:46:02PM +0200, Alexander Usyskin wrote:
> This reverts commit 62db7d00efe48c614b006086f306d5addedf8f83.

That says what you did, but not why you did it, which means I can't take
this, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [Intel-xe] [PATCH 2/5] mei: hdcp: match without driver name
  2023-11-07 13:46 ` Alexander Usyskin
@ 2023-11-07 13:46   ` Alexander Usyskin
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

Remove dependency on i915 driver name in component_match function.
Use PCI header information to match Intel graphics device.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/mei_hdcp.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 51359cc5ece9..f8759a6c9ed3 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -17,6 +17,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/mei.h>
 #include <linux/mei_cl_bus.h>
@@ -781,9 +782,18 @@ static int mei_hdcp_component_match(struct device *dev, int subcomponent,
 				    void *data)
 {
 	struct device *base = data;
+	struct pci_dev *pdev;
 
-	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
-	    subcomponent != I915_COMPONENT_HDCP)
+	if (!dev_is_pci(dev))
+		return 0;
+
+	pdev = to_pci_dev(dev);
+
+	if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) ||
+	    pdev->vendor != PCI_VENDOR_ID_INTEL)
+		return 0;
+
+	if (subcomponent != I915_COMPONENT_HDCP)
 		return 0;
 
 	base = base->parent;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/5] mei: hdcp: match without driver name
@ 2023-11-07 13:46   ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

Remove dependency on i915 driver name in component_match function.
Use PCI header information to match Intel graphics device.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/mei_hdcp.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 51359cc5ece9..f8759a6c9ed3 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -17,6 +17,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/mei.h>
 #include <linux/mei_cl_bus.h>
@@ -781,9 +782,18 @@ static int mei_hdcp_component_match(struct device *dev, int subcomponent,
 				    void *data)
 {
 	struct device *base = data;
+	struct pci_dev *pdev;
 
-	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
-	    subcomponent != I915_COMPONENT_HDCP)
+	if (!dev_is_pci(dev))
+		return 0;
+
+	pdev = to_pci_dev(dev);
+
+	if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) ||
+	    pdev->vendor != PCI_VENDOR_ID_INTEL)
+		return 0;
+
+	if (subcomponent != I915_COMPONENT_HDCP)
 		return 0;
 
 	base = base->parent;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Intel-xe] [PATCH 3/5] mei: pxp: match without driver name
  2023-11-07 13:46 ` Alexander Usyskin
@ 2023-11-07 13:46   ` Alexander Usyskin
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

Remove dependency on i915 driver name in component_match function.
Use PCI header information to match Intel graphics device.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/pxp/mei_pxp.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/pxp/mei_pxp.c b/drivers/misc/mei/pxp/mei_pxp.c
index 2dcb9169e404..e74b2facfdf9 100644
--- a/drivers/misc/mei/pxp/mei_pxp.c
+++ b/drivers/misc/mei/pxp/mei_pxp.c
@@ -12,6 +12,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/mei.h>
 #include <linux/mei_cl_bus.h>
@@ -154,12 +155,21 @@ static int mei_pxp_component_match(struct device *dev, int subcomponent,
 				   void *data)
 {
 	struct device *base = data;
+	struct pci_dev *pdev;
 
 	if (!dev)
 		return 0;
 
-	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
-	    subcomponent != I915_COMPONENT_PXP)
+	if (!dev_is_pci(dev))
+		return 0;
+
+	pdev = to_pci_dev(dev);
+
+	if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) ||
+	    pdev->vendor != PCI_VENDOR_ID_INTEL)
+		return 0;
+
+	if (subcomponent != I915_COMPONENT_PXP)
 		return 0;
 
 	base = base->parent;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/5] mei: pxp: match without driver name
@ 2023-11-07 13:46   ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

Remove dependency on i915 driver name in component_match function.
Use PCI header information to match Intel graphics device.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/pxp/mei_pxp.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/pxp/mei_pxp.c b/drivers/misc/mei/pxp/mei_pxp.c
index 2dcb9169e404..e74b2facfdf9 100644
--- a/drivers/misc/mei/pxp/mei_pxp.c
+++ b/drivers/misc/mei/pxp/mei_pxp.c
@@ -12,6 +12,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/mei.h>
 #include <linux/mei_cl_bus.h>
@@ -154,12 +155,21 @@ static int mei_pxp_component_match(struct device *dev, int subcomponent,
 				   void *data)
 {
 	struct device *base = data;
+	struct pci_dev *pdev;
 
 	if (!dev)
 		return 0;
 
-	if (!dev->driver || strcmp(dev->driver->name, "i915") ||
-	    subcomponent != I915_COMPONENT_PXP)
+	if (!dev_is_pci(dev))
+		return 0;
+
+	pdev = to_pci_dev(dev);
+
+	if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) ||
+	    pdev->vendor != PCI_VENDOR_ID_INTEL)
+		return 0;
+
+	if (subcomponent != I915_COMPONENT_PXP)
 		return 0;
 
 	base = base->parent;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Intel-xe] [PATCH 4/5] mei: hdcp: add dependency on Xe driver
  2023-11-07 13:46 ` Alexander Usyskin
@ 2023-11-07 13:46   ` Alexander Usyskin
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

Optionally depend on either i915 or Xe drivers.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 54e1c9526909..2ac9148988d4 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -4,7 +4,7 @@
 config INTEL_MEI_HDCP
 	tristate "Intel HDCP2.2 services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915
+	depends on DRM_I915 || DRM_XE
 	help
 	  MEI Support for HDCP2.2 Services on Intel platforms.
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/5] mei: hdcp: add dependency on Xe driver
@ 2023-11-07 13:46   ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

Optionally depend on either i915 or Xe drivers.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hdcp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 54e1c9526909..2ac9148988d4 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -4,7 +4,7 @@
 config INTEL_MEI_HDCP
 	tristate "Intel HDCP2.2 services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915
+	depends on DRM_I915 || DRM_XE
 	help
 	  MEI Support for HDCP2.2 Services on Intel platforms.
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Intel-xe] [PATCH 5/5] mei: pxp: add dependency on Xe driver
  2023-11-07 13:46 ` Alexander Usyskin
@ 2023-11-07 13:46   ` Alexander Usyskin
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: linux-kernel, Tomas Winkler, Alexander Usyskin, intel-xe

Optionally depend on either i915 or Xe drivers.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/pxp/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
index 4029b96afc04..d9ae5483567f 100644
--- a/drivers/misc/mei/pxp/Kconfig
+++ b/drivers/misc/mei/pxp/Kconfig
@@ -1,11 +1,10 @@
-
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2020, Intel Corporation. All rights reserved.
 #
 config INTEL_MEI_PXP
 	tristate "Intel PXP services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915
+	depends on DRM_I915 || DRM_XE
 	help
 	  MEI Support for PXP Services on Intel platforms.
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/5] mei: pxp: add dependency on Xe driver
@ 2023-11-07 13:46   ` Alexander Usyskin
  0 siblings, 0 replies; 23+ messages in thread
From: Alexander Usyskin @ 2023-11-07 13:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lucas De Marchi, Daniele Ceraolo Spurio,
	Rodrigo Vivi
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-xe,
	linux-kernel

Optionally depend on either i915 or Xe drivers.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/pxp/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
index 4029b96afc04..d9ae5483567f 100644
--- a/drivers/misc/mei/pxp/Kconfig
+++ b/drivers/misc/mei/pxp/Kconfig
@@ -1,11 +1,10 @@
-
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2020, Intel Corporation. All rights reserved.
 #
 config INTEL_MEI_PXP
 	tristate "Intel PXP services of ME Interface"
 	select INTEL_MEI_ME
-	depends on DRM_I915
+	depends on DRM_I915 || DRM_XE
 	help
 	  MEI Support for PXP Services on Intel platforms.
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [Intel-xe] [PATCH 5/5] mei: pxp: add dependency on Xe driver
  2023-11-07 13:46   ` Alexander Usyskin
@ 2023-11-07 14:11     ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:11 UTC (permalink / raw)
  To: Alexander Usyskin
  Cc: Lucas De Marchi, linux-kernel, Rodrigo Vivi, Tomas Winkler,
	intel-xe

On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> Optionally depend on either i915 or Xe drivers.
> 
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
>  drivers/misc/mei/pxp/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> index 4029b96afc04..d9ae5483567f 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -1,11 +1,10 @@
> -

Why this change here?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver
@ 2023-11-07 14:11     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:11 UTC (permalink / raw)
  To: Alexander Usyskin
  Cc: Lucas De Marchi, Daniele Ceraolo Spurio, Rodrigo Vivi,
	Tomas Winkler, Vitaly Lubart, intel-xe, linux-kernel

On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> Optionally depend on either i915 or Xe drivers.
> 
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
>  drivers/misc/mei/pxp/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> index 4029b96afc04..d9ae5483567f 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -1,11 +1,10 @@
> -

Why this change here?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Intel-xe] [PATCH 5/5] mei: pxp: add dependency on Xe driver
  2023-11-07 14:11     ` Greg Kroah-Hartman
@ 2023-11-07 14:26       ` Usyskin, Alexander
  -1 siblings, 0 replies; 23+ messages in thread
From: Usyskin, Alexander @ 2023-11-07 14:26 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: De Marchi, Lucas, linux-kernel@vger.kernel.org, Vivi, Rodrigo,
	Winkler, Tomas, intel-xe@lists.freedesktop.org

> 
> On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > Optionally depend on either i915 or Xe drivers.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > ---
> >  drivers/misc/mei/pxp/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > index 4029b96afc04..d9ae5483567f 100644
> > --- a/drivers/misc/mei/pxp/Kconfig
> > +++ b/drivers/misc/mei/pxp/Kconfig
> > @@ -1,11 +1,10 @@
> > -
> 
> Why this change here?

I've been told that SPDX should be the first line in the file,
but here fist line is an empty line.
I can drop this change if it is inappropriate to put it in this patch.

-- 
Thanks,
Sasha


> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* RE: [PATCH 5/5] mei: pxp: add dependency on Xe driver
@ 2023-11-07 14:26       ` Usyskin, Alexander
  0 siblings, 0 replies; 23+ messages in thread
From: Usyskin, Alexander @ 2023-11-07 14:26 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: De Marchi, Lucas, Ceraolo Spurio, Daniele, Vivi, Rodrigo,
	Winkler, Tomas, Lubart, Vitaly, intel-xe@lists.freedesktop.org,
	linux-kernel@vger.kernel.org

> 
> On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > Optionally depend on either i915 or Xe drivers.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > ---
> >  drivers/misc/mei/pxp/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > index 4029b96afc04..d9ae5483567f 100644
> > --- a/drivers/misc/mei/pxp/Kconfig
> > +++ b/drivers/misc/mei/pxp/Kconfig
> > @@ -1,11 +1,10 @@
> > -
> 
> Why this change here?

I've been told that SPDX should be the first line in the file,
but here fist line is an empty line.
I can drop this change if it is inappropriate to put it in this patch.

-- 
Thanks,
Sasha


> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Intel-xe] [PATCH 5/5] mei: pxp: add dependency on Xe driver
  2023-11-07 14:26       ` Usyskin, Alexander
@ 2023-11-07 14:35         ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:35 UTC (permalink / raw)
  To: Usyskin, Alexander
  Cc: De Marchi, Lucas, linux-kernel@vger.kernel.org, Vivi, Rodrigo,
	Winkler, Tomas, intel-xe@lists.freedesktop.org

On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> > 
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > >  drivers/misc/mei/pxp/Kconfig | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> > 
> > Why this change here?
> 
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.

That is correct, and should be fixed up, but you didn't say that you
made this change in your changelog text so I didn't know why it was
there.

> I can drop this change if it is inappropriate to put it in this patch.

It should go in a separate patch please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver
@ 2023-11-07 14:35         ` Greg Kroah-Hartman
  0 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-07 14:35 UTC (permalink / raw)
  To: Usyskin, Alexander
  Cc: De Marchi, Lucas, Ceraolo Spurio, Daniele, Vivi, Rodrigo,
	Winkler, Tomas, Lubart, Vitaly, intel-xe@lists.freedesktop.org,
	linux-kernel@vger.kernel.org

On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> > 
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > >  drivers/misc/mei/pxp/Kconfig | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> > 
> > Why this change here?
> 
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.

That is correct, and should be fixed up, but you didn't say that you
made this change in your changelog text so I didn't know why it was
there.

> I can drop this change if it is inappropriate to put it in this patch.

It should go in a separate patch please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Intel-xe] [PATCH 5/5] mei: pxp: add dependency on Xe driver
  2023-11-07 14:26       ` Usyskin, Alexander
@ 2023-11-27 13:32         ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-27 13:32 UTC (permalink / raw)
  To: Usyskin, Alexander
  Cc: De Marchi, Lucas, linux-kernel@vger.kernel.org, Vivi, Rodrigo,
	Winkler, Tomas, intel-xe@lists.freedesktop.org

On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> > 
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > >  drivers/misc/mei/pxp/Kconfig | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> > 
> > Why this change here?
> 
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.
> I can drop this change if it is inappropriate to put it in this patch.

It should not go into this patch.  Remember, each patch should only do
"one thing".

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver
@ 2023-11-27 13:32         ` Greg Kroah-Hartman
  0 siblings, 0 replies; 23+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-27 13:32 UTC (permalink / raw)
  To: Usyskin, Alexander
  Cc: De Marchi, Lucas, Ceraolo Spurio, Daniele, Vivi, Rodrigo,
	Winkler, Tomas, Lubart, Vitaly, intel-xe@lists.freedesktop.org,
	linux-kernel@vger.kernel.org

On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> > 
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > >  drivers/misc/mei/pxp/Kconfig | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> > 
> > Why this change here?
> 
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.
> I can drop this change if it is inappropriate to put it in this patch.

It should not go into this patch.  Remember, each patch should only do
"one thing".

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [Intel-xe] ✗ CI.Patch_applied: failure for mei: hdcp/pxp: adapt for Xe driver
  2023-11-07 13:46 ` Alexander Usyskin
                   ` (5 preceding siblings ...)
  (?)
@ 2023-11-07 14:18 ` Patchwork
  -1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2023-11-07 14:18 UTC (permalink / raw)
  To: Alexander Usyskin; +Cc: intel-xe

== Series Details ==

Series: mei: hdcp/pxp: adapt for Xe driver
URL   : https://patchwork.freedesktop.org/series/126075/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 17fc56818 drm/xe/xelpmp: Add Wa_16021867713
=== git am output follows ===
Applying: Revert "mei/hdcp: Also enable for XE"
Applying: mei: hdcp: match without driver name
Applying: mei: pxp: match without driver name
Applying: mei: hdcp: add dependency on Xe driver
Applying: mei: pxp: add dependency on Xe driver



^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2023-11-27 13:54 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 13:46 [Intel-xe] [PATCH 0/5] mei: hdcp/pxp: adapt for Xe driver Alexander Usyskin
2023-11-07 13:46 ` Alexander Usyskin
2023-11-07 13:46 ` [Intel-xe] [PATCH 1/5] Revert "mei/hdcp: Also enable for XE" Alexander Usyskin
2023-11-07 13:46   ` Alexander Usyskin
2023-11-07 14:10   ` [Intel-xe] " Greg Kroah-Hartman
2023-11-07 14:10     ` Greg Kroah-Hartman
2023-11-07 13:46 ` [Intel-xe] [PATCH 2/5] mei: hdcp: match without driver name Alexander Usyskin
2023-11-07 13:46   ` Alexander Usyskin
2023-11-07 13:46 ` [Intel-xe] [PATCH 3/5] mei: pxp: " Alexander Usyskin
2023-11-07 13:46   ` Alexander Usyskin
2023-11-07 13:46 ` [Intel-xe] [PATCH 4/5] mei: hdcp: add dependency on Xe driver Alexander Usyskin
2023-11-07 13:46   ` Alexander Usyskin
2023-11-07 13:46 ` [Intel-xe] [PATCH 5/5] mei: pxp: " Alexander Usyskin
2023-11-07 13:46   ` Alexander Usyskin
2023-11-07 14:11   ` [Intel-xe] " Greg Kroah-Hartman
2023-11-07 14:11     ` Greg Kroah-Hartman
2023-11-07 14:26     ` [Intel-xe] " Usyskin, Alexander
2023-11-07 14:26       ` Usyskin, Alexander
2023-11-07 14:35       ` [Intel-xe] " Greg Kroah-Hartman
2023-11-07 14:35         ` Greg Kroah-Hartman
2023-11-27 13:32       ` [Intel-xe] " Greg Kroah-Hartman
2023-11-27 13:32         ` Greg Kroah-Hartman
2023-11-07 14:18 ` [Intel-xe] ✗ CI.Patch_applied: failure for mei: hdcp/pxp: adapt for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.