[LTP] [PATCH v2 1/2] link05: Convert docs to docparse

[LTP] [PATCH v2 1/2] link05: Convert docs to docparse

[Yang Xu]

The description of link05's test has no relevance to the test code,
I've changed the description.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 testcases/kernel/syscalls/link/link05.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c
index 95787ec24..f255bc13b 100644
--- a/testcases/kernel/syscalls/link/link05.c
+++ b/testcases/kernel/syscalls/link/link05.c
@@ -1,13 +1,15 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
- *  AUTHOR		: Richard Logan
- *  CO-PILOT		: William Roske
+ * Authors: Richard Logan, William Roske
  * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
+ * Copyright (c) Linux Test Project, 2001-2023
  */
 
-/*
- * Test if link(2) fails with EMLINK.
+/*\
+ * [Description]
+ *
+ * Tests that link(2) succeeds with creating n links.
  */
 
 #include <stdio.h>
-- 
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 2/2] link08: Convert docs to docparse

[Yang Xu]

update copyright, fix grammar

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 testcases/kernel/syscalls/link/link08.c | 31 ++++++++++++++-----------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/testcases/kernel/syscalls/link/link08.c b/testcases/kernel/syscalls/link/link08.c
index d3e33d077..9cc468f58 100644
--- a/testcases/kernel/syscalls/link/link08.c
+++ b/testcases/kernel/syscalls/link/link08.c
@@ -1,23 +1,26 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * Copyright (c) 2014 Fujitsu Ltd.
+ * Copyright (c) Linux Test Project, 2014-2023
  * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
  */
-/*
- * Test Description:
- *  Verify that,
- *   1. link() fails with -1 return value and sets errno to EPERM
- *      if oldpath is a directory.
- *   2. link() fails with -1 return value and sets errno to EXDEV
- *      if oldpath and newpath are not on the same mounted file system( Linux
- *      permits a file system to be mounted at multiple points, but link()
- *      does not work across different mount points, even if the same
- *      file system is mounted on both. ).
- *   3. link() fails with -1 return value and sets errno to EROFS
- *      if the file is on a read-only file system.
- *   4. link() fails with -1 return value and sets errno to ELOOP
- *      if too many symbolic links were encountered in resolving path.
+
+/*\
+ * [Description]
+ *
+ * Verify that,
+ *
+ * - link() fails with EPERM if the old path is a directory.
+ * - link() fails with EXDEV if the old path and the new path
+ *   are not on the same mounted file system(Linux permits
+ *   a file system to be mounted at multiple points, but link()
+ *   does not work across different mount points, even if the same
+ *   file system is mounted on both).
+ * - link() fails with EROFS if the file is on a read-only file system.
+ * - link() fails with ELOOP if too many symbolic links were encountered
+ *   in resolving path.
  */
+
 #include <errno.h>
 #include "tst_test.h"
 
-- 
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/2] link05: Convert docs to docparse

[Petr Vorel]

Hi Xu,

> The description of link05's test has no relevance to the test code,
> I've changed the description.

> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  testcases/kernel/syscalls/link/link05.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

> diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c
> index 95787ec24..f255bc13b 100644
> --- a/testcases/kernel/syscalls/link/link05.c
> +++ b/testcases/kernel/syscalls/link/link05.c
> @@ -1,13 +1,15 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
> - *  AUTHOR		: Richard Logan
> - *  CO-PILOT		: William Roske
> + * Authors: Richard Logan, William Roske
>   * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
> + * Copyright (c) Linux Test Project, 2001-2023
>   */
+1

> -/*
> - * Test if link(2) fails with EMLINK.
> +/*\
> + * [Description]
> + *
> + * Tests that link(2) succeeds with creating n links.
+1. I'd just instead of "n links" mention either "1000 links" or "high number of
links" (to be more obvious).

Kind regards,
Petr

>   */


>  #include <stdio.h>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 2/2] link08: Convert docs to docparse

[Petr Vorel]

Hi Xu,

> update copyright, fix grammar
...
> +++ b/testcases/kernel/syscalls/link/link08.c
> @@ -1,23 +1,26 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * Copyright (c) 2014 Fujitsu Ltd.
> + * Copyright (c) Linux Test Project, 2014-2023
>   * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
>   */
> -/*
> - * Test Description:
> - *  Verify that,
> - *   1. link() fails with -1 return value and sets errno to EPERM
> - *      if oldpath is a directory.
> - *   2. link() fails with -1 return value and sets errno to EXDEV
> - *      if oldpath and newpath are not on the same mounted file system( Linux
> - *      permits a file system to be mounted at multiple points, but link()
> - *      does not work across different mount points, even if the same
> - *      file system is mounted on both. ).
> - *   3. link() fails with -1 return value and sets errno to EROFS
> - *      if the file is on a read-only file system.
> - *   4. link() fails with -1 return value and sets errno to ELOOP
> - *      if too many symbolic links were encountered in resolving path.
> +
> +/*\
> + * [Description]
> + *
> + * Verify that,
nit: * Verify that:

Thanks!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/2] link05: Convert docs to docparse

[Yang Xu (Fujitsu)]

Hi Petr

>Hi Xu,

>> The description of link05's test has no relevance to the test code,
>> I've changed the description.

>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>>  testcases/kernel/syscalls/link/link05.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)

>> diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c
>> index 95787ec24..f255bc13b 100644
>> --- a/testcases/kernel/syscalls/link/link05.c
>> +++ b/testcases/kernel/syscalls/link/link05.c
>> @@ -1,13 +1,15 @@
>>  // SPDX-License-Identifier: GPL-2.0-or-later
>>  /*
>>   * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
>> - *  AUTHOR           : Richard Logan
>> - *  CO-PILOT         : William Roske
>> + * Authors: Richard Logan, William Roske
>>   * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
>> + * Copyright (c) Linux Test Project, 2001-2023
>>   */
>+1

>> -/*
>> - * Test if link(2) fails with EMLINK.
>> +/*\
>> + * [Description]
>> + *
>> + * Tests that link(2) succeeds with creating n links.
>+1. I'd just instead of "n links" mention either "1000 links" or "high number of
>links" (to be more obvious).

Thanks for your suggestion, merged!

>Kind regards,
>Petr

>>   */


>>  #include <stdio.h>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 2/2] link08: Convert docs to docparse

[Yang Xu (Fujitsu)]

Hi Petr,

>Hi Xu,

>> update copyright, fix grammar
>...
>> +++ b/testcases/kernel/syscalls/link/link08.c
>> @@ -1,23 +1,26 @@
>>  // SPDX-License-Identifier: GPL-2.0-or-later
>>  /*
>>   * Copyright (c) 2014 Fujitsu Ltd.
>> + * Copyright (c) Linux Test Project, 2014-2023
>>   * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
>>   */
>> -/*
>> - * Test Description:
>> - *  Verify that,
>> - *   1. link() fails with -1 return value and sets errno to EPERM
>> - *      if oldpath is a directory.
>> - *   2. link() fails with -1 return value and sets errno to EXDEV
>> - *      if oldpath and newpath are not on the same mounted file system( Linux
>> - *      permits a file system to be mounted at multiple points, but link()
>> - *      does not work across different mount points, even if the same
>> - *      file system is mounted on both. ).
>> - *   3. link() fails with -1 return value and sets errno to EROFS
>> - *      if the file is on a read-only file system.
>> - *   4. link() fails with -1 return value and sets errno to ELOOP
>> - *      if too many symbolic links were encountered in resolving path.
>> +
>> +/*\
>> + * [Description]
>> + *
>> + * Verify that,
>nit: * Verify that:

>Thanks!

>Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks for your suggestion, merged!

Best Regards,
Yang Xu

>Kind regards,
>Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp