All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling
Date: Wed, 8 Nov 2023 11:32:19 +0000	[thread overview]
Message-ID: <20231108113219.GA1345456@bogus> (raw)
In-Reply-To: <20231108111549.155974-1-lpieralisi@kernel.org>

On Wed, Nov 08, 2023 at 12:15:49PM +0100, Lorenzo Pieralisi wrote:
> To parse the retrieved ID lists appropriately in
> ffa_notification_info_get() the ids_processed variable should not
> be pre-incremented - we are dropping an identifier at the
> beginning of the list.
> 
> Fix it by using the post-increment operator to increment the number
> of processed IDs.
> 
> Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface")

Thanks for spotting and fixing this. Much appreciated!
I will queue at -rc1.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling
Date: Wed, 8 Nov 2023 11:32:19 +0000	[thread overview]
Message-ID: <20231108113219.GA1345456@bogus> (raw)
In-Reply-To: <20231108111549.155974-1-lpieralisi@kernel.org>

On Wed, Nov 08, 2023 at 12:15:49PM +0100, Lorenzo Pieralisi wrote:
> To parse the retrieved ID lists appropriately in
> ffa_notification_info_get() the ids_processed variable should not
> be pre-incremented - we are dropping an identifier at the
> beginning of the list.
> 
> Fix it by using the post-increment operator to increment the number
> of processed IDs.
> 
> Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface")

Thanks for spotting and fixing this. Much appreciated!
I will queue at -rc1.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-08 11:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 11:15 [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling Lorenzo Pieralisi
2023-11-08 11:15 ` Lorenzo Pieralisi
2023-11-08 11:32 ` Sudeep Holla [this message]
2023-11-08 11:32   ` Sudeep Holla
2023-11-13 12:24 ` Sudeep Holla
2023-11-13 12:24   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231108113219.GA1345456@bogus \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.