All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Jason Wang <jasowang@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"sburla@marvell.com" <sburla@marvell.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Maor Gottlieb <maorg@nvidia.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	"lingshan.zhu@intel.com" <lingshan.zhu@intel.com>
Subject: [virtio-comment] Re: [PATCH v3 6/8] admin: Add theory of operation for write recording commands
Date: Wed, 8 Nov 2023 12:16:14 -0500	[thread overview]
Message-ID: <20231108120828-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB54819D42D98DB9BB95800947DCA8A@PH0PR12MB5481.namprd12.prod.outlook.com>

On Wed, Nov 08, 2023 at 09:00:00AM +0000, Parav Pandit wrote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, November 8, 2023 1:47 PM
> 
> > Only for TX, and I'm pretty sure they had the foresight to test RX not just TX but
> > let's confirm. Parav did you test both directions?
> Rx is the main part to test for the dirty page tracking.
> Tx only is around ring updates, so not very interesting test.
> 
> When page tracking is started, there is impact on Rx as natural throttle by slowing down rx packet rate.

Wait a sec sounds kind of like what we see with SVQ as well?

> And devices have implementation choice to covering the spectrum on amount of drop rate.

What does this mean practically?

> And has implementations evolve, it will improve as well.

Maybe, or maybe not.

> PRI for sure is out of question. Most workload won't use it at all given other limitations of virtio on PCI front and existing PRI behaviors.

Out of curiousity what do you refer to?

> There is also a test with platform IOMMU dirty page tracking done as well but it is very early stage to comment in this forum.

Interesting. That's a very important test I'd say - if platform based
dirty page tracking is just as good we can avoid adding it to virtio.


And I'm rather confused at this point - I was under the impression you
already have a prototype which shows negligeable performance impact
with on device tracking.

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  reply	other threads:[~2023-11-08 17:16 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 13:19 [virtio-comment] [PATCH v3 0/8] Introduce device migration support commands Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 1/8] admin: Add theory of operation for device migration Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 2/8] admin: Redefine reserved2 as command specific output Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 3/8] device-context: Define the device context fields for device migration Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 4/8] admin: Add device migration admin commands Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 5/8] admin: Add requirements of device migration commands Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 6/8] admin: Add theory of operation for write recording commands Parav Pandit
2023-10-31  1:43   ` [virtio-comment] " Jason Wang
2023-10-31  3:27     ` [virtio-comment] " Parav Pandit
2023-10-31  7:45       ` [virtio-comment] " Michael S. Tsirkin
2023-10-31  9:32         ` Zhu, Lingshan
2023-10-31  9:41           ` Michael S. Tsirkin
2023-10-31  9:47             ` Zhu, Lingshan
2023-11-01  0:29       ` Jason Wang
2023-11-01  3:02         ` [virtio-comment] " Parav Pandit
2023-11-02  4:24           ` [virtio-comment] " Jason Wang
2023-11-02  6:10             ` [virtio-comment] " Parav Pandit
2023-11-06  6:34               ` [virtio-comment] " Jason Wang
2023-11-06  6:53                 ` [virtio-comment] " Parav Pandit
2023-11-07  4:04                   ` [virtio-comment] " Jason Wang
2023-11-07  7:05                     ` Michael S. Tsirkin
2023-11-08  4:28                       ` Jason Wang
2023-11-08  8:17                         ` Michael S. Tsirkin
2023-11-08  9:00                           ` [virtio-comment] " Parav Pandit
2023-11-08 17:16                             ` Michael S. Tsirkin [this message]
2023-11-09  6:27                               ` [virtio-comment] " Parav Pandit
2023-11-09  3:31                           ` Jason Wang
2023-11-09  7:59                             ` Michael S. Tsirkin
2023-11-10  6:46                               ` [virtio-comment] " Parav Pandit
2023-11-13  3:41                                 ` [virtio-comment] " Jason Wang
2023-11-13 14:30                                   ` Michael S. Tsirkin
2023-11-14  2:03                                     ` Zhu, Lingshan
2023-11-14  7:52                                       ` Jason Wang
2023-11-15 17:37                                   ` [virtio-comment] " Parav Pandit
2023-11-16  4:24                                     ` [virtio-comment] " Jason Wang
2023-11-16  6:49                                       ` Michael S. Tsirkin
2023-11-21  4:21                                         ` Jason Wang
2023-11-21 16:24                                           ` [virtio-comment] " Parav Pandit
2023-11-22  4:11                                             ` [virtio-comment] " Jason Wang
2023-11-16  6:50                                     ` Michael S. Tsirkin
2023-11-13  3:31                               ` Jason Wang
2023-11-13  6:57                                 ` Michael S. Tsirkin
2023-11-14  7:34                                   ` Zhu, Lingshan
2023-11-14  7:59                                     ` Jason Wang
2023-11-14  8:27                                     ` Michael S. Tsirkin
2023-11-15  4:05                                       ` Zhu, Lingshan
2023-11-15  7:51                                         ` Michael S. Tsirkin
2023-11-15  7:59                                           ` Zhu, Lingshan
2023-11-15  8:05                                             ` Michael S. Tsirkin
2023-11-15  8:42                                               ` Zhu, Lingshan
2023-11-15 11:52                                                 ` Michael S. Tsirkin
2023-11-16  9:38                                                   ` Zhu, Lingshan
2023-11-16 12:18                                                     ` Michael S. Tsirkin
2023-11-17  9:50                                                       ` Zhu, Lingshan
2023-11-17  9:55                                                         ` Michael S. Tsirkin
2023-11-14  7:57                                   ` Jason Wang
2023-11-14  9:16                                     ` Michael S. Tsirkin
2023-11-15 17:42                                 ` [virtio-comment] " Parav Pandit
2023-11-16  4:18                                   ` [virtio-comment] " Jason Wang
2023-11-16  5:27                                     ` [virtio-comment] " Parav Pandit
2023-11-17 10:15                                   ` [virtio-comment] " Michael S. Tsirkin
2023-11-17 10:48                                     ` Parav Pandit
2023-11-17 11:19                                       ` Michael S. Tsirkin
2023-11-17 11:32                                         ` Parav Pandit
2023-11-17 11:49                                           ` Michael S. Tsirkin
2023-11-17 12:15                                             ` Parav Pandit
2023-11-17 12:37                                               ` Michael S. Tsirkin
2023-11-17 12:49                                                 ` Parav Pandit
2023-11-17 13:58                                                   ` Michael S. Tsirkin
2023-11-17 14:49                                                     ` Parav Pandit
2023-11-17 15:00                                                       ` Michael S. Tsirkin
2023-11-09  6:26                         ` [virtio-comment] " Parav Pandit
2023-11-15  7:59                           ` [virtio-comment] " Michael S. Tsirkin
2023-11-15 17:42                             ` [virtio-comment] " Parav Pandit
2023-11-09  6:24                     ` Parav Pandit
2023-11-13  3:37                       ` [virtio-comment] " Jason Wang
2023-11-15 17:38                         ` [virtio-comment] " Parav Pandit
2023-11-16  4:23                           ` [virtio-comment] " Jason Wang
2023-11-16  5:29                             ` [virtio-comment] " Parav Pandit
2023-11-16  5:51                               ` [virtio-comment] " Michael S. Tsirkin
2023-11-16  7:35                                 ` Michael S. Tsirkin
2023-11-16  7:40                                   ` [virtio-comment] " Parav Pandit
2023-11-16 11:48                                     ` [virtio-comment] " Michael S. Tsirkin
2023-11-16 16:26                                       ` [virtio-comment] " Parav Pandit
2023-11-16 17:25                                         ` [virtio-comment] " Michael S. Tsirkin
2023-11-16 17:29                                           ` [virtio-comment] " Parav Pandit
2023-11-16 18:20                                             ` [virtio-comment] " Michael S. Tsirkin
2023-11-17  3:02                                               ` [virtio-comment] " Parav Pandit
2023-11-17  8:46                                                 ` [virtio-comment] " Michael S. Tsirkin
2023-11-17  9:14                                                   ` [virtio-comment] " Parav Pandit
2023-11-17  9:37                                                     ` [virtio-comment] " Michael S. Tsirkin
2023-11-17  9:41                                                       ` [virtio-comment] " Parav Pandit
2023-11-17  9:44                                                         ` Parav Pandit
2023-11-17  9:51                                                         ` [virtio-comment] " Michael S. Tsirkin
2023-11-17  9:54                                                           ` Zhu, Lingshan
2023-11-17 10:02                                                             ` Michael S. Tsirkin
2023-11-17 10:10                                                               ` Parav Pandit
2023-11-17  9:57                                                           ` Parav Pandit
2023-11-17 10:37                                                             ` Michael S. Tsirkin
2023-11-17 10:52                                                               ` Parav Pandit
2023-11-17 11:32                                                                 ` Michael S. Tsirkin
2023-11-17 12:22                                                                   ` Parav Pandit
2023-11-17 12:40                                                                     ` Michael S. Tsirkin
2023-11-17 12:51                                                                       ` Parav Pandit
2023-11-21  5:16                                                                         ` Jason Wang
2023-11-21 16:29                                                                           ` Parav Pandit
2023-11-21 21:00                                                                             ` Michael S. Tsirkin
2023-11-22  3:46                                                                               ` Parav Pandit
2023-11-22  7:44                                                                                 ` Michael S. Tsirkin
2023-11-22  4:17                                                                             ` Jason Wang
2023-11-22  4:34                                                                               ` Parav Pandit
2023-11-24  3:15                                                                                 ` Jason Wang
2023-11-17  9:52                                                         ` Zhu, Lingshan
2023-11-17  9:59                                                           ` [virtio-comment] " Parav Pandit
2023-11-17 10:00                                                             ` [virtio-comment] " Zhu, Lingshan
2023-11-21  4:24                                                 ` Jason Wang
2023-11-21 16:26                                                   ` [virtio-comment] " Parav Pandit
2023-11-22  4:14                                                     ` [virtio-comment] " Jason Wang
2023-11-22  4:19                                                       ` [virtio-comment] " Parav Pandit
2023-11-24  3:09                                                         ` [virtio-comment] " Jason Wang
2023-11-16 10:28                                 ` Zhu, Lingshan
2023-11-16 11:59                                   ` Michael S. Tsirkin
2023-11-17  9:59                                     ` Zhu, Lingshan
2023-11-17 10:03                                       ` Parav Pandit
2023-11-17 11:00                                         ` Michael S. Tsirkin
2023-11-17 11:05                                           ` Parav Pandit
2023-11-17 11:33                                             ` Michael S. Tsirkin
2023-11-17 11:45                                               ` Parav Pandit
2023-11-17 12:04                                                 ` Michael S. Tsirkin
2023-11-17 12:11                                                   ` Parav Pandit
2023-11-17 12:32                                                     ` Michael S. Tsirkin
2023-11-17 13:03                                                       ` Parav Pandit
2023-11-17 14:00                                                         ` Michael S. Tsirkin
2023-11-17 14:48                                                           ` Parav Pandit
2023-11-17 14:59                                                             ` Michael S. Tsirkin
2023-11-21  6:55                                                             ` Jason Wang
2023-11-21 16:30                                                               ` Parav Pandit
2023-11-22  4:19                                                                 ` Jason Wang
2023-11-22  4:28                                                                   ` Parav Pandit
2023-11-24  3:08                                                                     ` Jason Wang
2023-11-22  2:31                                                               ` Si-Wei Liu
2023-11-22  5:31                                                                 ` Jason Wang
2023-11-23 13:19                                                                   ` Si-Wei Liu
2023-11-23 14:39                                                                     ` Michael S. Tsirkin
2023-11-24  2:29                                                                     ` Jason Wang
2023-11-28  3:00                                                                       ` Si-Wei Liu
2023-11-29  5:12                                                                         ` Jason Wang
2023-11-17 10:40                                       ` Michael S. Tsirkin
2023-11-21  4:23                                 ` Jason Wang
2023-11-21  7:14                               ` Jason Wang
2023-11-21 16:31                                 ` [virtio-comment] " Parav Pandit
2023-11-22  4:28                                   ` [virtio-comment] " Jason Wang
2023-11-22  6:41                                     ` [virtio-comment] " Parav Pandit
2023-11-24  3:06                                       ` [virtio-comment] " Jason Wang
2023-11-15  7:58                       ` Michael S. Tsirkin
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 7/8] admin: Add " Parav Pandit
2023-10-30 13:19 ` [virtio-comment] [PATCH v3 8/8] admin: Add requirements of write reporting commands Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231108120828-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=maorg@nvidia.com \
    --cc=parav@nvidia.com \
    --cc=sburla@marvell.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.