From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 3/3] net: ethernet: cortina: Fix MTU max setting
Date: Thu, 9 Nov 2023 12:47:23 +0200 [thread overview]
Message-ID: <20231109104723.2f47d2slwkbmqctt@skbuf> (raw)
In-Reply-To: <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org>
On Thu, Nov 09, 2023 at 10:03:14AM +0100, Linus Walleij wrote:
> The RX max frame size is over 10000 for the Gemini ethernet,
> but the TX max frame size is actually just 2047 (0x7ff after
> checking the datasheet). Reflect this in what we offer to Linux,
> cap the MTU at the TX max frame minus ethernet headers.
>
> We delete the code disabling the hardware checksum for large
> MTUs as netdev->mtu can no longer be larger than
> netdev->max_mtu meaning the if()-clause in gmac_fix_features()
> is never true.
>
> Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 3/3] net: ethernet: cortina: Fix MTU max setting
Date: Thu, 9 Nov 2023 12:47:23 +0200 [thread overview]
Message-ID: <20231109104723.2f47d2slwkbmqctt@skbuf> (raw)
In-Reply-To: <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org>
On Thu, Nov 09, 2023 at 10:03:14AM +0100, Linus Walleij wrote:
> The RX max frame size is over 10000 for the Gemini ethernet,
> but the TX max frame size is actually just 2047 (0x7ff after
> checking the datasheet). Reflect this in what we offer to Linux,
> cap the MTU at the TX max frame minus ethernet headers.
>
> We delete the code disabling the hardware checksum for large
> MTUs as netdev->mtu can no longer be larger than
> netdev->max_mtu meaning the if()-clause in gmac_fix_features()
> is never true.
>
> Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2023-11-09 10:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 9:03 [PATCH net v4 0/3] Fix large frames in the Gemini ethernet driver Linus Walleij
2023-11-09 9:03 ` Linus Walleij
2023-11-09 9:03 ` [PATCH net v4 1/3] net: ethernet: cortina: Fix max RX frame define Linus Walleij
2023-11-09 9:03 ` Linus Walleij
2023-11-09 10:42 ` Vladimir Oltean
2023-11-09 10:42 ` Vladimir Oltean
2023-11-09 9:03 ` [PATCH net v4 2/3] net: ethernet: cortina: Handle large frames Linus Walleij
2023-11-09 9:03 ` Linus Walleij
2023-11-09 10:46 ` Vladimir Oltean
2023-11-09 10:46 ` Vladimir Oltean
2023-11-09 9:03 ` [PATCH net v4 3/3] net: ethernet: cortina: Fix MTU max setting Linus Walleij
2023-11-09 9:03 ` Linus Walleij
2023-11-09 10:47 ` Vladimir Oltean [this message]
2023-11-09 10:47 ` Vladimir Oltean
2023-11-09 10:50 ` [PATCH net v4 0/3] Fix large frames in the Gemini ethernet driver Vladimir Oltean
2023-11-09 10:50 ` Vladimir Oltean
2023-11-09 12:26 ` Paolo Abeni
2023-11-09 12:26 ` Paolo Abeni
2023-11-09 17:13 ` Vladimir Oltean
2023-11-09 17:13 ` Vladimir Oltean
2023-11-09 12:46 ` Linus Walleij
2023-11-09 12:46 ` Linus Walleij
2023-11-14 5:00 ` patchwork-bot+netdevbpf
2023-11-14 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109104723.2f47d2slwkbmqctt@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.