Re: [RFC 3/6] misc: introduce misc_cg_charge()

[kernel test robot <lkp@intel.com>]

Hi Tycho,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 13d88ac54ddd1011b6e94443958e798aa06eb835]

url:    https://github.com/intel-lab-lkp/linux/commits/Tycho-Andersen/fs-count_open_files-count_possible_open_files/20231108-083733
base:   13d88ac54ddd1011b6e94443958e798aa06eb835
patch link:    https://lore.kernel.org/r/20231108002647.73784-4-tycho%40tycho.pizza
patch subject: [RFC 3/6] misc: introduce misc_cg_charge()
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20231110/202311100146.ydtzwawu-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311100146.ydtzwawu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311100146.ydtzwawu-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/cgroup/misc.c: In function 'misc_cg_charge':
>> kernel/cgroup/misc.c:151:41: error: passing argument 2 of 'atomic_long_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
     151 |                 atomic_long_add(amount, &res->usage);
         |                                         ^~~~~~~~~~~
         |                                         |
         |                                         atomic64_t *
   In file included from include/linux/atomic.h:82,
                    from include/linux/rcupdate.h:25,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/cgroup.h:12,
                    from kernel/cgroup/misc.c:10:
   include/linux/atomic/atomic-instrumented.h:3230:40: note: expected 'atomic_long_t *' {aka 'atomic_t *'} but argument is of type 'atomic64_t *'
    3230 | atomic_long_add(long i, atomic_long_t *v)
         |                         ~~~~~~~~~~~~~~~^
   cc1: some warnings being treated as errors


vim +/atomic_long_add +151 kernel/cgroup/misc.c

   123	
   124	/**
   125	 * misc_cg_charge() - Charge the cgroup, ignoring limits/capacity.
   126	 * @type: Misc res type to charge.
   127	 * @cg: Misc cgroup which will be charged.
   128	 * @amount: Amount to charge.
   129	 *
   130	 * Charge @amount to the misc cgroup. Caller must use the same cgroup during
   131	 * the uncharge call.
   132	 *
   133	 * Context: Any context.
   134	 */
   135	void misc_cg_charge(enum misc_res_type type, struct misc_cg *cg, u64 amount)
   136	{
   137		struct misc_res *res;
   138		struct misc_cg *i;
   139	
   140		if (!(valid_type(type) && cg && READ_ONCE(misc_res_capacity[type]))) {
   141			WARN_ON_ONCE(!valid_type(type));
   142			return;
   143		}
   144	
   145		if (!amount)
   146			return;
   147	
   148		for (i = cg; i; i = parent_misc(i)) {
   149			res = &i->res[type];
   150	
 > 151			atomic_long_add(amount, &res->usage);
   152		}
   153	}
   154	EXPORT_SYMBOL_GPL(misc_cg_charge);
   155	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki