All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Haitao Huang <haitao.huang@linux.intel.com>,
	Kamalesh Babulal <kamalesh.babulal@oracle.com>
Subject: Re: [RFC 0/6] tracking fd counts per cgroup
Date: Thu, 9 Nov 2023 08:44:48 -1000	[thread overview]
Message-ID: <ZU0ooOGzXJfa5Zz0@slm.duckdns.org> (raw)
In-Reply-To: <20231108002647.73784-1-tycho@tycho.pizza>

Hello,

On Tue, Nov 07, 2023 at 05:26:41PM -0700, Tycho Andersen wrote:
> Hi all,
> 
> At Netflix, we have a "canary" framework that will run test versions of
> an application and automatically detect anomalies in various metrics. We
> also have two "fleets", one full of virtual machines, and one that is a
> multi-tenant container environment.
> 
> On our full-VM fleet, one of the metrics we analyze is the number of open file
> descriptors, from /proc/sys/fs/file-nr. However, no equivalent exists for the
> multi-tenant container fleet, which has lead to several production issues.
> 
> This idea is not new of course [1], but hopefully the existence of the new misc
> cgroup will make it more tenable.
> 
> I'm not really tied to any of the semantics in this series (e.g. threads could
> be double counted even with a shared table), and am open to implementing this
> in other ways if it makes more sense.

As already raised by Christian, if the goal is monitoring, you should be
able to do that easily with BPF.

Thanks.

-- 
tejun

      parent reply	other threads:[~2023-11-09 18:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  0:26 [RFC 0/6] tracking fd counts per cgroup Tycho Andersen
2023-11-08  0:26 ` [RFC 1/6] fs: count_open_files() -> count_possible_open_files() Tycho Andersen
2023-11-08  0:26 ` [RFC 2/6] fs: introduce count_open_files() Tycho Andersen
2023-11-08  0:26 ` [RFC 3/6] misc: introduce misc_cg_charge() Tycho Andersen
2023-11-09 18:04   ` kernel test robot
2023-11-08  0:26 ` [RFC 4/6] misc cgroup: introduce an fd counter Tycho Andersen
2023-11-08 16:57   ` Al Viro
2023-11-08 21:01     ` Tycho Andersen
2023-11-09  9:53   ` Christian Brauner
2023-11-09 14:58     ` Tycho Andersen
2023-11-08  0:26 ` [RFC 5/6] selftests/cgroup: add a flags arg to clone_into_cgroup() Tycho Andersen
2023-11-08  0:26 ` [RFC 6/6] selftests/cgroup: add a test for misc cgroup Tycho Andersen
2023-11-09 18:44 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZU0ooOGzXJfa5Zz0@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=haitao.huang@linux.intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamalesh.babulal@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=tycho@tycho.pizza \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.