From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails
Date: Mon, 13 Nov 2023 16:49:41 +0100 [thread overview]
Message-ID: <20231113154941.GA2231337@pevik> (raw)
In-Reply-To: <1ce87b4d-88f6-4255-9483-fe860e41c93a@suse.cz>
> On 25. 09. 23 19:40, Petr Vorel wrote:
> > Hi,
> > ...
> > > > > > - umount $local_dir
> > > > > > + umount $local_dir || tst_res TFAIL "Unmount failed"
> > > > > I suppose that this should be TBROK instead. And that this, apart from
> > > > Right, TBROK looks to be the best.
> > > > Martin, if you're ok with the change, I'll update it before merge (after the
> > > > release).
> > > I don't see the point. This is a cleanup function. The TBROK will be changed
> > > to TWARN and the test will continue anyway.
> > But TFAIL in cleanup function looks to me strange as well. Should we endup with
> > TWARN then?
> TWARN makes sense. Feel free to change it during merge.
Good, changed and merged. Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-11-13 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 10:50 ` Martin Doucha
2023-09-20 8:00 ` Petr Vorel
2023-09-20 11:28 ` Richard Palethorpe
2023-09-22 12:05 ` Cyril Hrubis
2023-09-25 13:22 ` Petr Vorel
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2023-09-25 13:24 ` Petr Vorel
2023-09-25 13:45 ` Martin Doucha
2023-09-25 17:40 ` Petr Vorel
2023-11-13 15:46 ` Martin Doucha
2023-11-13 15:49 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113154941.GA2231337@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.