From: Richard Palethorpe <rpalethorpe@suse.de>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed
Date: Wed, 20 Sep 2023 12:28:36 +0100 [thread overview]
Message-ID: <87bkdxf5i0.fsf@suse.de> (raw)
In-Reply-To: <20230919114701.15327-3-mdoucha@suse.cz>
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Martin Doucha <mdoucha@suse.cz> writes:
> A race condition between the two parallel calls of rm_files may cause
> NFS unmount to fail and then the NFS client will get confused by remote
> filesystem change which leads to strange failures. Make sure both
> rm_files calls finish before returning from the main test function.
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs03.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs03.sh b/testcases/network/nfs/nfs_stress/nfs03.sh
> index e5f4de67c..e9ef5fb78 100755
> --- a/testcases/network/nfs/nfs_stress/nfs03.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs03.sh
> @@ -66,11 +66,13 @@ do_test()
> cd ../dir1
> wait $pid1
> rm_files &
> + pid3=$!
>
> tst_res TINFO "cd dir2 & removing files"
> cd ../dir2
> wait $pid2
> rm_files
> + wait $pid3
>
> tst_res TPASS "test done"
> }
> --
> 2.42.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-20 11:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:46 [LTP] [PATCH 0/3] NFS test fixes Martin Doucha
2023-09-19 11:46 ` [LTP] [PATCH 1/3] nfs_lib.sh: Log NFS mount and unmount Martin Doucha
2023-09-20 7:59 ` Petr Vorel
2023-09-20 11:26 ` Richard Palethorpe
2023-09-22 12:02 ` Cyril Hrubis
2023-09-19 11:46 ` [LTP] [PATCH 2/3] nfs03.sh: Wait for all files to be removed Martin Doucha
2023-09-20 7:59 ` Richard Palethorpe
2023-09-20 10:50 ` Martin Doucha
2023-09-20 8:00 ` Petr Vorel
2023-09-20 11:28 ` Richard Palethorpe [this message]
2023-09-22 12:05 ` Cyril Hrubis
2023-09-25 13:22 ` Petr Vorel
2023-09-19 11:46 ` [LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails Martin Doucha
2023-09-20 8:01 ` Petr Vorel
2023-09-20 11:27 ` Richard Palethorpe
2023-09-22 12:08 ` Cyril Hrubis
2023-09-25 13:24 ` Petr Vorel
2023-09-25 13:45 ` Martin Doucha
2023-09-25 17:40 ` Petr Vorel
2023-11-13 15:46 ` Martin Doucha
2023-11-13 15:49 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkdxf5i0.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.