From: kernel test robot <lkp@intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
Date: Tue, 14 Nov 2023 07:05:25 +0800 [thread overview]
Message-ID: <202311140621.sw31vG8M-lkp@intel.com> (raw)
In-Reply-To: <20231113201110.510724-4-imre.deak@intel.com>
Hi Imre,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20231113201110.510724-4-imre.deak%40intel.com
patch subject: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
config: i386-randconfig-002-20231114 (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311140621.sw31vG8M-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/display/drm_dp_mst_topology.o: in function `drm_dp_get_vc_payload_bw':
>> drivers/gpu/drm/display/drm_dp_mst_topology.c:3598: undefined reference to `__udivdi3'
vim +3598 drivers/gpu/drm/display/drm_dp_mst_topology.c
3570
3571 /**
3572 * drm_dp_get_vc_payload_bw - get the VC payload BW for an MST link
3573 * @mgr: The &drm_dp_mst_topology_mgr to use
3574 * @link_rate: link rate in 10kbits/s units
3575 * @link_lane_count: lane count
3576 *
3577 * Calculate the total bandwidth of a MultiStream Transport link. The returned
3578 * value is in units of PBNs/(timeslots/1 MTP). This value can be used to
3579 * convert the number of PBNs required for a given stream to the number of
3580 * timeslots this stream requires in each MTP.
3581 */
3582 int drm_dp_get_vc_payload_bw(const struct drm_dp_mst_topology_mgr *mgr,
3583 int link_rate, int link_lane_count)
3584 {
3585 int ret;
3586
3587 if (link_rate == 0 || link_lane_count == 0)
3588 drm_dbg_kms(mgr->dev, "invalid link rate/lane count: (%d / %d)\n",
3589 link_rate, link_lane_count);
3590
3591 /* See DP v2.0 2.6.4.2, 2.7.6.3 VCPayload_Bandwidth_for_OneTimeSlotPer_MTP_Allocation */
3592 /*
3593 * TODO: Return the value with a higher precision, allowing a better
3594 * slots per MTP allocation granularity. With the current returned
3595 * value +1 slot/MTP can get allocated on UHBR links.
3596 */
3597 ret = mul_u32_u32(link_rate * link_lane_count,
> 3598 drm_dp_bw_channel_coding_efficiency(drm_dp_is_uhbr_rate(link_rate))) /
3599 (1000000ULL * 8 * 5400);
3600
3601 return ret;
3602 }
3603 EXPORT_SYMBOL(drm_dp_get_vc_payload_bw);
3604
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Cc: oe-kbuild-all@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
Date: Tue, 14 Nov 2023 07:05:25 +0800 [thread overview]
Message-ID: <202311140621.sw31vG8M-lkp@intel.com> (raw)
In-Reply-To: <20231113201110.510724-4-imre.deak@intel.com>
Hi Imre,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20231113201110.510724-4-imre.deak%40intel.com
patch subject: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
config: i386-randconfig-002-20231114 (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311140621.sw31vG8M-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/display/drm_dp_mst_topology.o: in function `drm_dp_get_vc_payload_bw':
>> drivers/gpu/drm/display/drm_dp_mst_topology.c:3598: undefined reference to `__udivdi3'
vim +3598 drivers/gpu/drm/display/drm_dp_mst_topology.c
3570
3571 /**
3572 * drm_dp_get_vc_payload_bw - get the VC payload BW for an MST link
3573 * @mgr: The &drm_dp_mst_topology_mgr to use
3574 * @link_rate: link rate in 10kbits/s units
3575 * @link_lane_count: lane count
3576 *
3577 * Calculate the total bandwidth of a MultiStream Transport link. The returned
3578 * value is in units of PBNs/(timeslots/1 MTP). This value can be used to
3579 * convert the number of PBNs required for a given stream to the number of
3580 * timeslots this stream requires in each MTP.
3581 */
3582 int drm_dp_get_vc_payload_bw(const struct drm_dp_mst_topology_mgr *mgr,
3583 int link_rate, int link_lane_count)
3584 {
3585 int ret;
3586
3587 if (link_rate == 0 || link_lane_count == 0)
3588 drm_dbg_kms(mgr->dev, "invalid link rate/lane count: (%d / %d)\n",
3589 link_rate, link_lane_count);
3590
3591 /* See DP v2.0 2.6.4.2, 2.7.6.3 VCPayload_Bandwidth_for_OneTimeSlotPer_MTP_Allocation */
3592 /*
3593 * TODO: Return the value with a higher precision, allowing a better
3594 * slots per MTP allocation granularity. With the current returned
3595 * value +1 slot/MTP can get allocated on UHBR links.
3596 */
3597 ret = mul_u32_u32(link_rate * link_lane_count,
> 3598 drm_dp_bw_channel_coding_efficiency(drm_dp_is_uhbr_rate(link_rate))) /
3599 (1000000ULL * 8 * 5400);
3600
3601 return ret;
3602 }
3603 EXPORT_SYMBOL(drm_dp_get_vc_payload_bw);
3604
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
Date: Tue, 14 Nov 2023 07:05:25 +0800 [thread overview]
Message-ID: <202311140621.sw31vG8M-lkp@intel.com> (raw)
In-Reply-To: <20231113201110.510724-4-imre.deak@intel.com>
Hi Imre,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20231113201110.510724-4-imre.deak%40intel.com
patch subject: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates
config: i386-randconfig-002-20231114 (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231114/202311140621.sw31vG8M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311140621.sw31vG8M-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/display/drm_dp_mst_topology.o: in function `drm_dp_get_vc_payload_bw':
>> drivers/gpu/drm/display/drm_dp_mst_topology.c:3598: undefined reference to `__udivdi3'
vim +3598 drivers/gpu/drm/display/drm_dp_mst_topology.c
3570
3571 /**
3572 * drm_dp_get_vc_payload_bw - get the VC payload BW for an MST link
3573 * @mgr: The &drm_dp_mst_topology_mgr to use
3574 * @link_rate: link rate in 10kbits/s units
3575 * @link_lane_count: lane count
3576 *
3577 * Calculate the total bandwidth of a MultiStream Transport link. The returned
3578 * value is in units of PBNs/(timeslots/1 MTP). This value can be used to
3579 * convert the number of PBNs required for a given stream to the number of
3580 * timeslots this stream requires in each MTP.
3581 */
3582 int drm_dp_get_vc_payload_bw(const struct drm_dp_mst_topology_mgr *mgr,
3583 int link_rate, int link_lane_count)
3584 {
3585 int ret;
3586
3587 if (link_rate == 0 || link_lane_count == 0)
3588 drm_dbg_kms(mgr->dev, "invalid link rate/lane count: (%d / %d)\n",
3589 link_rate, link_lane_count);
3590
3591 /* See DP v2.0 2.6.4.2, 2.7.6.3 VCPayload_Bandwidth_for_OneTimeSlotPer_MTP_Allocation */
3592 /*
3593 * TODO: Return the value with a higher precision, allowing a better
3594 * slots per MTP allocation granularity. With the current returned
3595 * value +1 slot/MTP can get allocated on UHBR links.
3596 */
3597 ret = mul_u32_u32(link_rate * link_lane_count,
> 3598 drm_dp_bw_channel_coding_efficiency(drm_dp_is_uhbr_rate(link_rate))) /
3599 (1000000ULL * 8 * 5400);
3600
3601 return ret;
3602 }
3603 EXPORT_SYMBOL(drm_dp_get_vc_payload_bw);
3604
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-13 23:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 20:11 [Intel-gfx] [PATCH 1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links Imre Deak
2023-11-13 20:11 ` [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N values Imre Deak
2023-11-14 3:29 ` Murthy, Arun R
2023-11-14 7:43 ` Imre Deak
2023-11-15 13:29 ` Murthy, Arun R
2023-11-13 20:11 ` [Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Fix PBN / MTP_TU size calculation for UHBR rates Imre Deak
2023-11-15 13:38 ` Imre Deak
2023-11-15 13:41 ` Murthy, Arun R
2023-11-15 14:25 ` Imre Deak
2023-11-16 5:37 ` Murthy, Arun R
2023-11-13 20:11 ` [Intel-gfx] [PATCH 4/4] drm/dp_mst: Fix PBN divider " Imre Deak
2023-11-13 20:11 ` Imre Deak
2023-11-13 22:54 ` [Intel-gfx] " kernel test robot
2023-11-13 22:54 ` kernel test robot
2023-11-13 22:54 ` kernel test robot
2023-11-13 23:05 ` kernel test robot [this message]
2023-11-13 23:05 ` kernel test robot
2023-11-13 23:05 ` kernel test robot
2023-11-13 22:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links Patchwork
2023-11-13 22:50 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-14 2:07 ` [Intel-gfx] [PATCH 1/4] " Murthy, Arun R
2023-11-14 9:00 ` Jani Nikula
2023-11-14 13:07 ` Imre Deak
2023-11-15 13:42 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311140621.sw31vG8M-lkp@intel.com \
--to=lkp@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.