All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Sachin Bahadur <sachin.bahadur@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Block PF reinit if attached to bond
Date: Wed, 15 Nov 2023 17:42:21 +0000	[thread overview]
Message-ID: <20231115174221.GU74656@kernel.org> (raw)
In-Reply-To: <20231113235856.772920-1-sachin.bahadur@intel.com>

On Mon, Nov 13, 2023 at 03:58:56PM -0800, Sachin Bahadur wrote:
> PF interface part of LAG should not allow driver reinit via devlink. The
> Bond config will be lost due to driver reinit. ice_devlink_reload_down is
> called before PF driver reinit. If PF is attached to bond,
> ice_devlink_reload_down returns error.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Sachin Bahadur <sachin.bahadur@intel.com>

Hi Sachin,

I wonder if this should have a Fixes tag and be targeted at iwl-net.
It does feel like a bug from the description, but I could be wrong.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Sachin Bahadur <sachin.bahadur@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next v2] ice: Block PF reinit if attached to bond
Date: Wed, 15 Nov 2023 17:42:21 +0000	[thread overview]
Message-ID: <20231115174221.GU74656@kernel.org> (raw)
In-Reply-To: <20231113235856.772920-1-sachin.bahadur@intel.com>

On Mon, Nov 13, 2023 at 03:58:56PM -0800, Sachin Bahadur wrote:
> PF interface part of LAG should not allow driver reinit via devlink. The
> Bond config will be lost due to driver reinit. ice_devlink_reload_down is
> called before PF driver reinit. If PF is attached to bond,
> ice_devlink_reload_down returns error.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Sachin Bahadur <sachin.bahadur@intel.com>

Hi Sachin,

I wonder if this should have a Fixes tag and be targeted at iwl-net.
It does feel like a bug from the description, but I could be wrong.

  reply	other threads:[~2023-11-15 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 23:58 [Intel-wired-lan] [PATCH iwl-next v2] ice: Block PF reinit if attached to bond Sachin Bahadur
2023-11-13 23:58 ` Sachin Bahadur
2023-11-15 17:42 ` Simon Horman [this message]
2023-11-15 17:42   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115174221.GU74656@kernel.org \
    --to=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=sachin.bahadur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.