* [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
@ 2023-11-15 22:44 ` Rob Clark
0 siblings, 0 replies; 6+ messages in thread
From: Rob Clark @ 2023-11-15 22:44 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, freedreno, Rob Clark, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, open list
From: Rob Clark <robdclark@chromium.org>
The dpu devcore's are already associated with the dpu device. So we
should associate the gpu devcore's with the gpu device, for easier
classification.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_gpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index cfcb4317afdb..3fad5d58262f 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -292,8 +292,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
/* Set the active crash state to be dumped on failure */
gpu->crashstate = state;
- /* FIXME: Release the crashstate if this errors out? */
- dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
+ dev_coredumpm(&gpu->pdev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
msm_gpu_devcoredump_read, msm_gpu_devcoredump_free);
}
#else
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
@ 2023-11-15 22:44 ` Rob Clark
0 siblings, 0 replies; 6+ messages in thread
From: Rob Clark @ 2023-11-15 22:44 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, linux-arm-msm, Abhinav Kumar, open list, Sean Paul,
Dmitry Baryshkov, Marijn Suijten, freedreno
From: Rob Clark <robdclark@chromium.org>
The dpu devcore's are already associated with the dpu device. So we
should associate the gpu devcore's with the gpu device, for easier
classification.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_gpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index cfcb4317afdb..3fad5d58262f 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -292,8 +292,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
/* Set the active crash state to be dumped on failure */
gpu->crashstate = state;
- /* FIXME: Release the crashstate if this errors out? */
- dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
+ dev_coredumpm(&gpu->pdev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
msm_gpu_devcoredump_read, msm_gpu_devcoredump_free);
}
#else
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
2023-11-15 22:44 ` Rob Clark
@ 2023-11-15 22:58 ` Abhinav Kumar
-1 siblings, 0 replies; 6+ messages in thread
From: Abhinav Kumar @ 2023-11-15 22:58 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: linux-arm-msm, freedreno, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, open list
On 11/15/2023 2:44 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> The dpu devcore's are already associated with the dpu device. So we
> should associate the gpu devcore's with the gpu device, for easier
> classification.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
@ 2023-11-15 22:58 ` Abhinav Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Abhinav Kumar @ 2023-11-15 22:58 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, freedreno, linux-arm-msm, open list, Dmitry Baryshkov,
Marijn Suijten, Sean Paul
On 11/15/2023 2:44 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> The dpu devcore's are already associated with the dpu device. So we
> should associate the gpu devcore's with the gpu device, for easier
> classification.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
2023-11-15 22:58 ` Abhinav Kumar
@ 2023-11-16 22:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2023-11-16 22:00 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, dri-devel, linux-arm-msm, freedreno, Rob Clark,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter, open list
On Thu, 16 Nov 2023 at 00:58, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
>
>
> On 11/15/2023 2:44 PM, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The dpu devcore's are already associated with the dpu device. So we
> > should associate the gpu devcore's with the gpu device, for easier
> > classification.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device
@ 2023-11-16 22:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2023-11-16 22:00 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, linux-arm-msm, open list, dri-devel, Sean Paul,
Marijn Suijten, freedreno
On Thu, 16 Nov 2023 at 00:58, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
>
>
> On 11/15/2023 2:44 PM, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The dpu devcore's are already associated with the dpu device. So we
> > should associate the gpu devcore's with the gpu device, for easier
> > classification.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-16 22:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 22:44 [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device Rob Clark
2023-11-15 22:44 ` Rob Clark
2023-11-15 22:58 ` Abhinav Kumar
2023-11-15 22:58 ` Abhinav Kumar
2023-11-16 22:00 ` Dmitry Baryshkov
2023-11-16 22:00 ` Dmitry Baryshkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.