* [samba-ksmbd:ksmbd-for-next-next 5/5] fs/smb/server/vfs.c:921: warning: Function parameter or member 'get_write' not described in 'ksmbd_vfs_setxattr'
@ 2023-11-15 22:09 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-11-15 22:09 UTC (permalink / raw)
To: Namjae Jeon; +Cc: oe-kbuild-all
tree: git://git.samba.org/ksmbd.git ksmbd-for-next-next
head: 8445423a0a7af953b7f01a9898a91f3ac0082cb5
commit: 8445423a0a7af953b7f01a9898a91f3ac0082cb5 [5/5] ksmbd: fix possible deadlock in smb2_open
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231116/202311160659.VdkloROy-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/202311160659.VdkloROy-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311160659.VdkloROy-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/smb/server/vfs.c:54: warning: Function parameter or member 'parent' not described in 'ksmbd_vfs_lock_parent'
fs/smb/server/vfs.c:54: warning: Function parameter or member 'child' not described in 'ksmbd_vfs_lock_parent'
fs/smb/server/vfs.c:372: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_read'
fs/smb/server/vfs.c:372: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_read'
fs/smb/server/vfs.c:489: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_write'
fs/smb/server/vfs.c:489: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_write'
fs/smb/server/vfs.c:552: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:552: warning: Function parameter or member 'stat' not described in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:552: warning: Excess function parameter 'work' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:552: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:552: warning: Excess function parameter 'attrs' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:569: warning: Function parameter or member 'p_id' not described in 'ksmbd_vfs_fsync'
fs/smb/server/vfs.c:592: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:592: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:592: warning: Excess function parameter 'name' description in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:630: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_link'
fs/smb/server/vfs.c:802: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_truncate'
fs/smb/server/vfs.c:802: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_truncate'
fs/smb/server/vfs.c:843: warning: Excess function parameter 'size' description in 'ksmbd_vfs_listxattr'
>> fs/smb/server/vfs.c:921: warning: Function parameter or member 'get_write' not described in 'ksmbd_vfs_setxattr'
fs/smb/server/vfs.c:949: warning: Function parameter or member 'option' not described in 'ksmbd_vfs_set_fadvise'
fs/smb/server/vfs.c:949: warning: Excess function parameter 'options' description in 'ksmbd_vfs_set_fadvise'
fs/smb/server/vfs.c:1163: warning: Function parameter or member 'um' not described in 'ksmbd_vfs_lookup_in_dir'
fs/smb/server/vfs.c:1199: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_kern_path_locked'
vim +921 fs/smb/server/vfs.c
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 905
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 906 /**
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 907 * ksmbd_vfs_setxattr() - vfs helper for smb set extended attributes value
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 908 * @idmap: idmap of the relevant mount
3354db668808d5 fs/smb/server/vfs.c Namjae Jeon 2023-10-10 909 * @path: path of dentry to set XATTR at
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 910 * @attr_name: xattr name for setxattr
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 911 * @attr_value: xattr value to set
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 912 * @attr_size: size of xattr value
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 913 * @flags: destination buffer length
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 914 *
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 915 * Return: 0 on success, otherwise error
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 916 */
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 917 int ksmbd_vfs_setxattr(struct mnt_idmap *idmap,
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 918 const struct path *path, const char *attr_name,
8445423a0a7af9 fs/smb/server/vfs.c Namjae Jeon 2023-11-15 919 void *attr_value, size_t attr_size, int flags,
8445423a0a7af9 fs/smb/server/vfs.c Namjae Jeon 2023-11-15 920 bool get_write)
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 @921 {
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 922 int err;
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 923
8445423a0a7af9 fs/smb/server/vfs.c Namjae Jeon 2023-11-15 924 if (get_write == true) {
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 925 err = mnt_want_write(path->mnt);
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 926 if (err)
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 927 return err;
8445423a0a7af9 fs/smb/server/vfs.c Namjae Jeon 2023-11-15 928 }
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 929
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 930 err = vfs_setxattr(idmap,
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 931 path->dentry,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 932 attr_name,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 933 attr_value,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 934 attr_size,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 935 flags);
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 936 if (err)
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 937 ksmbd_debug(VFS, "setxattr failed, err %d\n", err);
8445423a0a7af9 fs/smb/server/vfs.c Namjae Jeon 2023-11-15 938 if (get_write == true)
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 939 mnt_drop_write(path->mnt);
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 940 return err;
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 941 }
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 942
:::::: The code at line 921 was first introduced by commit
:::::: f44158485826c076335d6860d35872271a83791d cifsd: add file operations
:::::: TO: Namjae Jeon <namjae.jeon@samsung.com>
:::::: CC: Steve French <stfrench@microsoft.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-15 22:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 22:09 [samba-ksmbd:ksmbd-for-next-next 5/5] fs/smb/server/vfs.c:921: warning: Function parameter or member 'get_write' not described in 'ksmbd_vfs_setxattr' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.