All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash
Date: Thu, 16 Nov 2023 16:46:40 +0100	[thread overview]
Message-ID: <20231116164640.7eedec50@xps-13> (raw)
In-Reply-To: <20231114123008.185071-1-amadeus@jmu.edu.cn>

Hi Chukun,

amadeus@jmu.edu.cn wrote on Tue, 14 Nov 2023 20:30:08 +0800:

> Hi Miquel,
> 
> > It's more like a request than a question. Please fix the parameter page
> > at run time by registering a ->.fixup_onfi_param_page() hook in
> > Toshiba's nand_manufacturer_ops structure.  
> 
> Sorry for the late reply. This flash is not ONFI compliant NAND,
> so onfi fixup can't work. Datasheet available at:
> https://europe.kioxia.com/content/dam/kioxia/newidr/productinfo/datasheet/201910/DST_TH58NYG3S0HBAI4-TDE_EN_31565.pdf

You said in your commit log that this flash was detected with a smaller
(or bigger, I don't remember) OOB size than it really has. This number
comes from somewhere? Is it an existing ID? Is it an auto-discovery
mechanism?

If it's an ID then why not adding a new entry. Otherwise you can I
guess make some changes in the device geometry in the manufacturer init
operation as well if the fixup-onfi hook does no apply.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash
Date: Thu, 16 Nov 2023 16:46:40 +0100	[thread overview]
Message-ID: <20231116164640.7eedec50@xps-13> (raw)
In-Reply-To: <20231114123008.185071-1-amadeus@jmu.edu.cn>

Hi Chukun,

amadeus@jmu.edu.cn wrote on Tue, 14 Nov 2023 20:30:08 +0800:

> Hi Miquel,
> 
> > It's more like a request than a question. Please fix the parameter page
> > at run time by registering a ->.fixup_onfi_param_page() hook in
> > Toshiba's nand_manufacturer_ops structure.  
> 
> Sorry for the late reply. This flash is not ONFI compliant NAND,
> so onfi fixup can't work. Datasheet available at:
> https://europe.kioxia.com/content/dam/kioxia/newidr/productinfo/datasheet/201910/DST_TH58NYG3S0HBAI4-TDE_EN_31565.pdf

You said in your commit log that this flash was detected with a smaller
(or bigger, I don't remember) OOB size than it really has. This number
comes from somewhere? Is it an existing ID? Is it an auto-discovery
mechanism?

If it's an ID then why not adding a new entry. Otherwise you can I
guess make some changes in the device geometry in the manufacturer init
operation as well if the fixup-onfi hook does no apply.

Thanks,
Miquèl

  parent reply	other threads:[~2023-11-16 15:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21 15:02 [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash Chukun Pan
2023-10-21 15:02 ` Chukun Pan
2023-10-23  7:54 ` Miquel Raynal
2023-10-23  7:54   ` Miquel Raynal
2023-10-29  7:20   ` Chukun Pan
2023-10-29  7:20     ` Chukun Pan
2023-10-29 13:48     ` Miquel Raynal
2023-10-29 13:48       ` Miquel Raynal
2023-11-14 12:30       ` Chukun Pan
2023-11-14 12:30         ` Chukun Pan
2023-11-15 14:00         ` Chukun Pan
2023-11-15 14:00           ` Chukun Pan
2023-11-16 15:46         ` Miquel Raynal [this message]
2023-11-16 15:46           ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116164640.7eedec50@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.