All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ronald Monthero <debug.penguin32@gmail.com>
To: miquel.raynal@bootlin.com, andriy.shevchenko@linux.intel.com
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
	martin.blumenstingl@googlemail.com, paul@crapouillou.net,
	robh@kernel.org, u.kleine-koenig@pengutronix.de,
	debug.penguin32@gmail.com, AVKrasnov@sberdevices.ru,
	r.czerwinski@pengutronix.de, jaimeliao.tw@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Roger Quadros <rogerq@kernel.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Poonam Aggrwal <poonam.aggrwal@freescale.com>,
	Dipen Dudhat <Dipen.Dudhat@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>,
	Li Yang <leoyang.li@nxp.com>, Liu Shuo <b35362@freescale.com>
Subject: [PATCH v4] mtd: rawnand: Increment IFC_TIMEOUT_MSECS for nand controller response
Date: Sat, 18 Nov 2023 18:31:51 +1000	[thread overview]
Message-ID: <20231118083156.776887-1-debug.penguin32@gmail.com> (raw)
In-Reply-To: <20231114091302.1f865d66@xps-13>

Under heavy load it is likely that the controller is done
with its own task but the thread unlocking the wait is not
scheduled in time. Increasing IFC_TIMEOUT_MSECS allows the
controller to respond within allowable timeslice of 1 sec.

fsl,ifc-nand 7e800000.nand: Controller is not responding

[<804b2047>] (nand_get_device) from [<804b5335>] (nand_write_oob+0x1b/0x4a)
[<804b5335>] (nand_write_oob) from [<804a3585>] (mtd_write+0x41/0x5c)
[<804a3585>] (mtd_write) from [<804c1d47>] (ubi_io_write+0x17f/0x22c)
[<804c1d47>] (ubi_io_write) from [<804c047b>] (ubi_eba_write_leb+0x5b/0x1d0)

Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ronald Monthero <debug.penguin32@gmail.com>
---
 drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c b/drivers/mtd/nand/raw/fsl_ifc_nand.c
index 20bb1e0cb5eb..f0e2318ce088 100644
--- a/drivers/mtd/nand/raw/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/raw/fsl_ifc_nand.c
@@ -21,7 +21,7 @@
 
 #define ERR_BYTE		0xFF /* Value returned for read
 					bytes when read failed	*/
-#define IFC_TIMEOUT_MSECS	500  /* Maximum number of mSecs to wait
+#define IFC_TIMEOUT_MSECS	1000 /* Maximum timeout to wait
 					for IFC NAND Machine	*/
 
 struct fsl_ifc_ctrl;
-- 
2.34.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Ronald Monthero <debug.penguin32@gmail.com>
To: miquel.raynal@bootlin.com, andriy.shevchenko@linux.intel.com
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
	martin.blumenstingl@googlemail.com, paul@crapouillou.net,
	robh@kernel.org, u.kleine-koenig@pengutronix.de,
	debug.penguin32@gmail.com, AVKrasnov@sberdevices.ru,
	r.czerwinski@pengutronix.de, jaimeliao.tw@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Roger Quadros <rogerq@kernel.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Poonam Aggrwal <poonam.aggrwal@freescale.com>,
	Dipen Dudhat <Dipen.Dudhat@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>,
	Li Yang <leoyang.li@nxp.com>, Liu Shuo <b35362@freescale.com>
Subject: [PATCH v4] mtd: rawnand: Increment IFC_TIMEOUT_MSECS for nand controller response
Date: Sat, 18 Nov 2023 18:31:51 +1000	[thread overview]
Message-ID: <20231118083156.776887-1-debug.penguin32@gmail.com> (raw)
In-Reply-To: <20231114091302.1f865d66@xps-13>

Under heavy load it is likely that the controller is done
with its own task but the thread unlocking the wait is not
scheduled in time. Increasing IFC_TIMEOUT_MSECS allows the
controller to respond within allowable timeslice of 1 sec.

fsl,ifc-nand 7e800000.nand: Controller is not responding

[<804b2047>] (nand_get_device) from [<804b5335>] (nand_write_oob+0x1b/0x4a)
[<804b5335>] (nand_write_oob) from [<804a3585>] (mtd_write+0x41/0x5c)
[<804a3585>] (mtd_write) from [<804c1d47>] (ubi_io_write+0x17f/0x22c)
[<804c1d47>] (ubi_io_write) from [<804c047b>] (ubi_eba_write_leb+0x5b/0x1d0)

Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ronald Monthero <debug.penguin32@gmail.com>
---
 drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c b/drivers/mtd/nand/raw/fsl_ifc_nand.c
index 20bb1e0cb5eb..f0e2318ce088 100644
--- a/drivers/mtd/nand/raw/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/raw/fsl_ifc_nand.c
@@ -21,7 +21,7 @@
 
 #define ERR_BYTE		0xFF /* Value returned for read
 					bytes when read failed	*/
-#define IFC_TIMEOUT_MSECS	500  /* Maximum number of mSecs to wait
+#define IFC_TIMEOUT_MSECS	1000 /* Maximum timeout to wait
 					for IFC NAND Machine	*/
 
 struct fsl_ifc_ctrl;
-- 
2.34.1


  reply	other threads:[~2023-11-18  8:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 13:16 [PATCH] mtd:nand: Increment IFC_TIMEOUT_MSECS for nand controller response Ronald Monthero
2023-11-13 13:16 ` Ronald Monthero
2023-11-13 13:44 ` Miquel Raynal
2023-11-13 13:44   ` Miquel Raynal
2023-11-13 15:17   ` Ronald Monthero
2023-11-13 15:17     ` Ronald Monthero
2023-11-13 15:53 ` [PATCH v2] mtd: rawnand: " Ronald Monthero
2023-11-13 15:53   ` Ronald Monthero
2023-11-13 15:56   ` kernel test robot
2023-11-13 16:04   ` Andy Shevchenko
2023-11-13 16:04     ` Andy Shevchenko
2023-11-13 16:11     ` Ronald Monthero
2023-11-13 16:11       ` Ronald Monthero
2023-11-13 17:32     ` [PATCH v3] " Ronald Monthero
2023-11-13 17:32       ` Ronald Monthero
2023-11-14  8:13       ` Miquel Raynal
2023-11-14  8:13         ` Miquel Raynal
2023-11-18  8:31         ` Ronald Monthero [this message]
2023-11-18  8:31           ` [PATCH v4] " Ronald Monthero
2023-11-20 10:46           ` Miquel Raynal
2023-11-20 10:46             ` Miquel Raynal
2023-11-13 16:07 ` [PATCH v2] " Ronald Monthero
2023-11-13 16:07   ` Ronald Monthero
2023-11-13 16:15   ` Andy Shevchenko
2023-11-13 16:15     ` Andy Shevchenko
2023-11-13 16:21     ` Ronald Monthero
2023-11-13 16:21       ` Ronald Monthero
2023-11-17 23:03 ` [PATCH] mtd:nand: " kernel test robot
2023-11-17 23:03   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231118083156.776887-1-debug.penguin32@gmail.com \
    --to=debug.penguin32@gmail.com \
    --cc=AVKrasnov@sberdevices.ru \
    --cc=Dipen.Dudhat@freescale.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=b35362@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=heiko@sntech.de \
    --cc=jaimeliao.tw@gmail.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=paul@crapouillou.net \
    --cc=poonam.aggrwal@freescale.com \
    --cc=r.czerwinski@pengutronix.de \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.