All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
	Daniel Vetter <daniel@ffwll.ch>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [Intel-gfx] [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Sun, 19 Nov 2023 11:14:40 +0100	[thread overview]
Message-ID: <20231119101445.4737-16-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com>

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/i915/display/intel_gmbus.c |    1 -
 drivers/gpu/drm/i915/display/intel_sdvo.c  |    1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 40d7b6f3f..e9e4dcf34 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
 		}
 
 		bus->adapter.owner = THIS_MODULE;
-		bus->adapter.class = I2C_CLASS_DDC;
 		snprintf(bus->adapter.name,
 			 sizeof(bus->adapter.name),
 			 "i915 gmbus %s", gmbus_pin->name);
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index a636f42ce..5e64d1baf 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
 	ddc->ddc_bus = ddc_bus;
 
 	ddc->ddc.owner = THIS_MODULE;
-	ddc->ddc.class = I2C_CLASS_DDC;
 	snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
 		 port_name(sdvo->base.port), ddc_bus);
 	ddc->ddc.dev.parent = &pdev->dev;


WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Sun, 19 Nov 2023 11:14:40 +0100	[thread overview]
Message-ID: <20231119101445.4737-16-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com>

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/i915/display/intel_gmbus.c |    1 -
 drivers/gpu/drm/i915/display/intel_sdvo.c  |    1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 40d7b6f3f..e9e4dcf34 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
 		}
 
 		bus->adapter.owner = THIS_MODULE;
-		bus->adapter.class = I2C_CLASS_DDC;
 		snprintf(bus->adapter.name,
 			 sizeof(bus->adapter.name),
 			 "i915 gmbus %s", gmbus_pin->name);
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index a636f42ce..5e64d1baf 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
 	ddc->ddc_bus = ddc_bus;
 
 	ddc->ddc.owner = THIS_MODULE;
-	ddc->ddc.class = I2C_CLASS_DDC;
 	snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
 		 port_name(sdvo->base.port), ddc_bus);
 	ddc->ddc.dev.parent = &pdev->dev;


WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Sun, 19 Nov 2023 11:14:40 +0100	[thread overview]
Message-ID: <20231119101445.4737-16-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com>

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/i915/display/intel_gmbus.c |    1 -
 drivers/gpu/drm/i915/display/intel_sdvo.c  |    1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 40d7b6f3f..e9e4dcf34 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
 		}
 
 		bus->adapter.owner = THIS_MODULE;
-		bus->adapter.class = I2C_CLASS_DDC;
 		snprintf(bus->adapter.name,
 			 sizeof(bus->adapter.name),
 			 "i915 gmbus %s", gmbus_pin->name);
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index a636f42ce..5e64d1baf 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
 	ddc->ddc_bus = ddc_bus;
 
 	ddc->ddc.owner = THIS_MODULE;
-	ddc->ddc.class = I2C_CLASS_DDC;
 	snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
 		 port_name(sdvo->base.port), ddc_bus);
 	ddc->ddc.dev.parent = &pdev->dev;


  parent reply	other threads:[~2023-11-19 10:15 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19 10:14 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 10:14 ` Heiner Kallweit
2023-11-19 10:14 ` Heiner Kallweit
2023-11-19 10:14 ` Heiner Kallweit
2023-11-19 10:14 ` [Intel-gfx] " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-20 11:34   ` Thomas Zimmermann
2023-11-20 11:34     ` Thomas Zimmermann
2023-11-19 10:14 ` [PATCH v3 03/20] drm/amd/display: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2024-01-22 15:31   ` Robert Foss
2024-01-22 15:31     ` Robert Foss
2023-11-19 10:14 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` Heiner Kallweit [this message]
2023-11-19 10:14   ` [PATCH v3 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-20 11:35   ` Thomas Zimmermann
2023-11-20 11:35     ` Thomas Zimmermann
2023-11-19 10:14 ` [PATCH v3 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-19 10:14   ` Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 20/20] include/linux/i2c.h: " Heiner Kallweit
  -- strict thread matches above, loose matches on Subject: below --
2023-11-19 11:28 [PATCH v3 RESEND 00/20] " Heiner Kallweit
2023-11-19 11:28 ` [Intel-gfx] [PATCH v3 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231119101445.4737-16-hkallweit1@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.