* [PATCH v2 1/3] rpi5: initial support
@ 2023-11-21 22:54 Dmitry Malkin
2023-11-22 13:54 ` Tom Rini
2023-11-22 18:56 ` Peter Robinson
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Malkin @ 2023-11-21 22:54 UTC (permalink / raw)
To: u-boot; +Cc: trini, mbrugger, pbrobinson
rpi5: add initial memory map for bcm2712
includes:
* 1GB of RAM (from 4GB or 8GB total)
* VPU memory interface
* SOC range (main peripherals)
Signed-off-by: Dmitry Malkin <dmitry@bedrocksystems.com>
---
v2:
new patch
---
arch/arm/mach-bcm283x/init.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/mach-bcm283x/init.c b/arch/arm/mach-bcm283x/init.c
index 7265faf6ce..362838e9b9 100644
--- a/arch/arm/mach-bcm283x/init.c
+++ b/arch/arm/mach-bcm283x/init.c
@@ -68,6 +68,33 @@ static struct mm_region
bcm2711_mem_map[MEM_MAP_MAX_ENTRIES] = {
}
};
+static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = {
+ {
+ .virt = 0x00000000UL,
+ .phys = 0x00000000UL,
+ .size = 0x3f800000UL,
+ .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
+ PTE_BLOCK_INNER_SHARE
+ }, {
+ .virt = 0x3f800000UL,
+ .phys = 0x3f800000UL,
+ .size = 0x00800000UL,
+ .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
+ PTE_BLOCK_NON_SHARE |
+ PTE_BLOCK_PXN | PTE_BLOCK_UXN
+ }, {
+ .virt = 0x107c000000UL,
+ .phys = 0x107c000000UL,
+ .size = 0x0004000000UL,
+ .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
+ PTE_BLOCK_NON_SHARE |
+ PTE_BLOCK_PXN | PTE_BLOCK_UXN
+ }, {
+ /* List terminator */
+ 0,
+ }
+};
+
struct mm_region *mem_map = bcm283x_mem_map;
/*
@@ -78,6 +105,7 @@ static const struct udevice_id board_ids[] = {
{ .compatible = "brcm,bcm2837", .data = (ulong)&bcm283x_mem_map},
{ .compatible = "brcm,bcm2838", .data = (ulong)&bcm2711_mem_map},
{ .compatible = "brcm,bcm2711", .data = (ulong)&bcm2711_mem_map},
+ { .compatible = "brcm,bcm2712", .data = (ulong)&bcm2712_mem_map},
{ },
};
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/3] rpi5: initial support
2023-11-21 22:54 [PATCH v2 1/3] rpi5: initial support Dmitry Malkin
@ 2023-11-22 13:54 ` Tom Rini
2023-11-22 18:56 ` Peter Robinson
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-11-22 13:54 UTC (permalink / raw)
To: Dmitry Malkin; +Cc: u-boot, mbrugger, pbrobinson
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Tue, Nov 21, 2023 at 11:54:24PM +0100, Dmitry Malkin wrote:
> rpi5: add initial memory map for bcm2712
>
> includes:
> * 1GB of RAM (from 4GB or 8GB total)
> * VPU memory interface
> * SOC range (main peripherals)
>
> Signed-off-by: Dmitry Malkin <dmitry@bedrocksystems.com>
I'm curious if the memory map portion of:
https://patchwork.ozlabs.org/project/uboot/patch/20231121-b4-qcom-common-target-v1-13-9492198e0c15@linaro.org/
could be used as inspiration here too?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/3] rpi5: initial support
2023-11-21 22:54 [PATCH v2 1/3] rpi5: initial support Dmitry Malkin
2023-11-22 13:54 ` Tom Rini
@ 2023-11-22 18:56 ` Peter Robinson
1 sibling, 0 replies; 3+ messages in thread
From: Peter Robinson @ 2023-11-22 18:56 UTC (permalink / raw)
To: Dmitry Malkin; +Cc: u-boot, trini, mbrugger
On Tue, Nov 21, 2023 at 10:54 PM Dmitry Malkin
<dmitry@bedrocksystems.com> wrote:
>
> rpi5: add initial memory map for bcm2712
Could this be the title for the patch, "initial support" is fine for
the cover letter, but doesn't really out line what this specific patch
actually does.
> includes:
> * 1GB of RAM (from 4GB or 8GB total)
> * VPU memory interface
> * SOC range (main peripherals)
Could you include details where this information came from as well please?
> Signed-off-by: Dmitry Malkin <dmitry@bedrocksystems.com>
> ---
> v2:
> new patch
> ---
> arch/arm/mach-bcm283x/init.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/mach-bcm283x/init.c b/arch/arm/mach-bcm283x/init.c
> index 7265faf6ce..362838e9b9 100644
> --- a/arch/arm/mach-bcm283x/init.c
> +++ b/arch/arm/mach-bcm283x/init.c
> @@ -68,6 +68,33 @@ static struct mm_region
> bcm2711_mem_map[MEM_MAP_MAX_ENTRIES] = {
> }
> };
>
> +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = {
> + {
> + .virt = 0x00000000UL,
> + .phys = 0x00000000UL,
> + .size = 0x3f800000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
> + PTE_BLOCK_INNER_SHARE
> + }, {
> + .virt = 0x3f800000UL,
> + .phys = 0x3f800000UL,
> + .size = 0x00800000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> + PTE_BLOCK_NON_SHARE |
> + PTE_BLOCK_PXN | PTE_BLOCK_UXN
> + }, {
> + .virt = 0x107c000000UL,
> + .phys = 0x107c000000UL,
> + .size = 0x0004000000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> + PTE_BLOCK_NON_SHARE |
> + PTE_BLOCK_PXN | PTE_BLOCK_UXN
> + }, {
> + /* List terminator */
> + 0,
> + }
> +};
> +
> struct mm_region *mem_map = bcm283x_mem_map;
>
> /*
> @@ -78,6 +105,7 @@ static const struct udevice_id board_ids[] = {
> { .compatible = "brcm,bcm2837", .data = (ulong)&bcm283x_mem_map},
> { .compatible = "brcm,bcm2838", .data = (ulong)&bcm2711_mem_map},
> { .compatible = "brcm,bcm2711", .data = (ulong)&bcm2711_mem_map},
> + { .compatible = "brcm,bcm2712", .data = (ulong)&bcm2712_mem_map},
> { },
> };
>
> --
> 2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-22 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 22:54 [PATCH v2 1/3] rpi5: initial support Dmitry Malkin
2023-11-22 13:54 ` Tom Rini
2023-11-22 18:56 ` Peter Robinson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.