From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: mkubecek@suse.cz, andrew@lunn.ch,
willemdebruijn.kernel@gmail.com,
Wojciech Drewek <wojciech.drewek@intel.com>,
corbet@lwn.net, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, jesse.brandeburg@intel.com,
Ahmed Zaki <ahmed.zaki@intel.com>,
edumazet@google.com, anthony.l.nguyen@intel.com,
horms@kernel.org, vladimir.oltean@nxp.com,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash
Date: Thu, 23 Nov 2023 08:27:37 -0800 [thread overview]
Message-ID: <20231123082737.471727c0@kernel.org> (raw)
In-Reply-To: <96d16597-12a7-4574-9c22-98a1b70bc21a@nvidia.com>
On Thu, 23 Nov 2023 15:33:04 +0200 Gal Pressman wrote:
> On 22/11/2023 1:33, Jakub Kicinski wrote:
> > Last but not least please keep the field check you moved to the drivers
> > in the core. Nobody will remember to check that other drivers added the
> > check as well.
>
> The wording of this sentence is a bit confusing, so I might be repeating
> what you already said, but this patchset needs to make sure that drivers
> that do not support the new symmetric flag return an error instead of
> silently ignoring it.
Ah, good point! That, too.
I was referring to what changed in v5, from the change long:
v5: move sanity checks from ethtool/ioctl.c to ice's and iavf's rxfnc
drivers entries (patches 5 and 6).
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Ahmed Zaki <ahmed.zaki@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
corbet@lwn.net, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, vladimir.oltean@nxp.com,
andrew@lunn.ch, horms@kernel.org, mkubecek@suse.cz,
willemdebruijn.kernel@gmail.com, alexander.duyck@gmail.com,
linux-doc@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash
Date: Thu, 23 Nov 2023 08:27:37 -0800 [thread overview]
Message-ID: <20231123082737.471727c0@kernel.org> (raw)
In-Reply-To: <96d16597-12a7-4574-9c22-98a1b70bc21a@nvidia.com>
On Thu, 23 Nov 2023 15:33:04 +0200 Gal Pressman wrote:
> On 22/11/2023 1:33, Jakub Kicinski wrote:
> > Last but not least please keep the field check you moved to the drivers
> > in the core. Nobody will remember to check that other drivers added the
> > check as well.
>
> The wording of this sentence is a bit confusing, so I might be repeating
> what you already said, but this patchset needs to make sure that drivers
> that do not support the new symmetric flag return an error instead of
> silently ignoring it.
Ah, good point! That, too.
I was referring to what changed in v5, from the change long:
v5: move sanity checks from ethtool/ioctl.c to ice's and iavf's rxfnc
drivers entries (patches 5 and 6).
next prev parent reply other threads:[~2023-11-23 16:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 20:56 [Intel-wired-lan] [PATCH net-next v6 0/7] Support symmetric-xor RSS hash Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-21 23:29 ` [Intel-wired-lan] " Jakub Kicinski
2023-11-21 23:29 ` Jakub Kicinski
2023-11-27 14:14 ` [Intel-wired-lan] " Ahmed Zaki
2023-11-27 14:14 ` Ahmed Zaki
2023-11-27 16:55 ` [Intel-wired-lan] " Jakub Kicinski
2023-11-27 16:55 ` Jakub Kicinski
2023-11-27 17:10 ` [Intel-wired-lan] " Edward Cree
2023-11-27 17:10 ` Edward Cree
2023-11-27 18:04 ` [Intel-wired-lan] " Jakub Kicinski
2023-11-27 18:04 ` Jakub Kicinski
2024-06-03 18:54 ` Edward Cree
2024-06-03 23:17 ` Jakub Kicinski
2024-06-04 14:58 ` Edward Cree
2024-06-04 17:33 ` Jakub Kicinski
2023-11-28 20:19 ` [Intel-wired-lan] " Keller, Jacob E
2023-11-28 20:19 ` Keller, Jacob E
2024-06-05 17:42 ` [Intel-wired-lan] " Gal Pressman
2024-06-05 17:42 ` Gal Pressman
2024-06-05 17:56 ` [Intel-wired-lan] " Ahmed Zaki
2024-06-05 17:56 ` Ahmed Zaki
2024-06-05 18:27 ` [Intel-wired-lan] " Keller, Jacob E
2024-06-05 18:27 ` Keller, Jacob E
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-21 23:33 ` [Intel-wired-lan] " Jakub Kicinski
2023-11-21 23:33 ` Jakub Kicinski
2023-11-23 13:33 ` [Intel-wired-lan] " Gal Pressman
2023-11-23 13:33 ` Gal Pressman
2023-11-23 16:27 ` Jakub Kicinski [this message]
2023-11-23 16:27 ` Jakub Kicinski
2023-11-27 14:21 ` [Intel-wired-lan] " Ahmed Zaki
2023-11-27 14:21 ` Ahmed Zaki
2023-11-27 16:57 ` [Intel-wired-lan] " Jakub Kicinski
2023-11-27 16:57 ` Jakub Kicinski
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 3/7] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 4/7] ice: refactor RSS configuration Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 5/7] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 6/7] ice: enable symmetric-xor RSS for Toeplitz hash function Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
2023-11-20 20:56 ` [Intel-wired-lan] [PATCH net-next v6 7/7] iavf: " Ahmed Zaki
2023-11-20 20:56 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123082737.471727c0@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.