From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
David Woodhouse <dwmw2@infradead.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Masahiro Yamada <masahiroy@kernel.org>,
Matt Turner <mattst88@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Peter Zijlstra <peterz@infradead.org>,
Rich Felker <dalias@libc.org>,
Richard Henderson <richard.henderson@linaro.org>,
Richard Weinberger <richard@nod.at>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: [PATCH v3 5/6] usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() static
Date: Thu, 23 Nov 2023 12:05:05 +0100 [thread overview]
Message-ID: <20231123110506.707903-6-arnd@kernel.org> (raw)
In-Reply-To: <20231123110506.707903-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
This function is only called locally and should always have been static:
drivers/usb/host/fsl-mph-dr-of.c:291:5: error: no previous prototype for 'fsl_usb2_mpc5121_init' [-Werror=missing-prototypes]
Fixes: 230f7ede6c2f ("USB: add USB EHCI support for MPC5121 SoC")
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/host/fsl-mph-dr-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 8508d37a2aff..6cdc3d805c32 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -288,7 +288,7 @@ static void fsl_usb2_mph_dr_of_remove(struct platform_device *ofdev)
#define PHYCTRL_LSFE (1 << 1) /* Line State Filter Enable */
#define PHYCTRL_PXE (1 << 0) /* PHY oscillator enable */
-int fsl_usb2_mpc5121_init(struct platform_device *pdev)
+static int fsl_usb2_mpc5121_init(struct platform_device *pdev)
{
struct fsl_usb2_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct clk *clk;
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
David Woodhouse <dwmw2@infradead.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Masahiro Yamada <masahiroy@kernel.org>,
Matt Turner <mattst88@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Peter Zijlstra <peterz@infradead.org>,
Rich Felker <dalias@libc.org>,
Richard Henderson <richard.henderson@linaro.org>,
Richard Weinberger <richard@nod.at>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: [PATCH v3 5/6] usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() static
Date: Thu, 23 Nov 2023 12:05:05 +0100 [thread overview]
Message-ID: <20231123110506.707903-6-arnd@kernel.org> (raw)
In-Reply-To: <20231123110506.707903-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
This function is only called locally and should always have been static:
drivers/usb/host/fsl-mph-dr-of.c:291:5: error: no previous prototype for 'fsl_usb2_mpc5121_init' [-Werror=missing-prototypes]
Fixes: 230f7ede6c2f ("USB: add USB EHCI support for MPC5121 SoC")
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/host/fsl-mph-dr-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 8508d37a2aff..6cdc3d805c32 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -288,7 +288,7 @@ static void fsl_usb2_mph_dr_of_remove(struct platform_device *ofdev)
#define PHYCTRL_LSFE (1 << 1) /* Line State Filter Enable */
#define PHYCTRL_PXE (1 << 0) /* PHY oscillator enable */
-int fsl_usb2_mpc5121_init(struct platform_device *pdev)
+static int fsl_usb2_mpc5121_init(struct platform_device *pdev)
{
struct fsl_usb2_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct clk *clk;
--
2.39.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-11-23 11:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:05 [PATCH v3 0/6] Treewide: enable -Wmissing-prototypes Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2023-11-23 11:05 ` [PATCH v3 1/6] ida: make 'ida_dump' static Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2023-11-23 11:05 ` [PATCH v3 2/6] jffs2: mark __jffs2_dbg_superblock_counts() static Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2023-11-23 11:05 ` [PATCH v3 3/6] sched: fair: move unused stub functions to header Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2023-11-23 11:05 ` [PATCH v3 4/6] x86: sta2x11: include header for sta2x11_get_instance() prototype Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann [this message]
2023-11-23 11:05 ` [PATCH v3 5/6] usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() static Arnd Bergmann
2023-11-23 11:05 ` [PATCH v3 6/6] Makefile.extrawarn: turn on missing-prototypes globally Arnd Bergmann
2023-11-23 11:05 ` Arnd Bergmann
2024-01-10 19:45 ` Guenter Roeck
2024-01-10 19:45 ` Guenter Roeck
2024-01-10 20:43 ` Arnd Bergmann
2024-01-10 20:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123110506.707903-6-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=richard@nod.at \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=tudor.ambarus@linaro.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.