From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
netdev@vger.kernel.org,
Marcin Szycik <marcin.szycik@linux.intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: field get conversion
Date: Fri, 24 Nov 2023 11:01:48 +0000 [thread overview]
Message-ID: <20231124110148.GJ50352@kernel.org> (raw)
In-Reply-To: <20231121211921.19834-11-jesse.brandeburg@intel.com>
On Tue, Nov 21, 2023 at 01:19:18PM -0800, Jesse Brandeburg wrote:
> Refactor the igc driver to use FIELD_GET() for mask and shift reads,
> which reduces lines of code and adds clarity of intent.
>
> This code was generated by the following coccinelle/spatch script and
> then manually repaired in a later patch.
>
> @get@
> constant shift,mask;
> expression a;
> @@
> -((a & mask) >> shift)
> +FIELD_GET(mask, a)
>
> and applied via:
> spatch --sp-file field_prep.cocci --in-place --dir \
> drivers/net/ethernet/intel/
>
> Cc: Julia Lawall <Julia.Lawall@inria.fr>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Julia Lawall <Julia.Lawall@inria.fr>,
Marcin Szycik <marcin.szycik@linux.intel.com>
Subject: Re: [PATCH iwl-next v1 10/13] igc: field get conversion
Date: Fri, 24 Nov 2023 11:01:48 +0000 [thread overview]
Message-ID: <20231124110148.GJ50352@kernel.org> (raw)
In-Reply-To: <20231121211921.19834-11-jesse.brandeburg@intel.com>
On Tue, Nov 21, 2023 at 01:19:18PM -0800, Jesse Brandeburg wrote:
> Refactor the igc driver to use FIELD_GET() for mask and shift reads,
> which reduces lines of code and adds clarity of intent.
>
> This code was generated by the following coccinelle/spatch script and
> then manually repaired in a later patch.
>
> @get@
> constant shift,mask;
> expression a;
> @@
> -((a & mask) >> shift)
> +FIELD_GET(mask, a)
>
> and applied via:
> spatch --sp-file field_prep.cocci --in-place --dir \
> drivers/net/ethernet/intel/
>
> Cc: Julia Lawall <Julia.Lawall@inria.fr>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-24 11:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 21:19 [Intel-wired-lan] [PATCH iwl-next v1 00/13] intel: use FIELD_PREP and FIELD_GET Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 01/13] e1000e: make lost bits explicit Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 10:59 ` [Intel-wired-lan] " Simon Horman
2023-11-24 10:59 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 02/13] intel: add bit macro includes where needed Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 10:59 ` [Intel-wired-lan] " Simon Horman
2023-11-24 10:59 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 03/13] intel: legacy: field prep conversion Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 10:59 ` [Intel-wired-lan] " Simon Horman
2023-11-24 10:59 ` Simon Horman
2023-12-05 6:15 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-05 6:15 ` Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 04/13] i40e: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:00 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:00 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 05/13] iavf: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:00 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:00 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 06/13] ice: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:00 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:00 ` Simon Horman
2023-12-05 6:29 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-05 6:29 ` Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 07/13] ice: fix pre-shifted bit usage Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:00 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:00 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 08/13] igc: field prep conversion Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:01 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:01 ` Simon Horman
2023-12-05 11:16 ` [Intel-wired-lan] " naamax.meir
2023-12-05 11:16 ` naamax.meir
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 09/13] intel: legacy: field get conversion Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:01 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:01 ` Simon Horman
2023-12-05 6:33 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-05 6:33 ` Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:01 ` Simon Horman [this message]
2023-11-24 11:01 ` Simon Horman
2023-12-06 8:22 ` [Intel-wired-lan] " naamax.meir
2023-12-06 8:22 ` naamax.meir
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 11/13] i40e: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:02 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:02 ` Simon Horman
2023-11-27 8:38 ` [Intel-wired-lan] " Loktionov, Aleksandr
2023-11-27 8:38 ` Loktionov, Aleksandr
2023-12-05 6:38 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-05 6:38 ` Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 12/13] iavf: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:02 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:02 ` Simon Horman
2023-11-21 21:19 ` [Intel-wired-lan] [PATCH iwl-next v1 13/13] ice: " Jesse Brandeburg
2023-11-21 21:19 ` Jesse Brandeburg
2023-11-24 11:03 ` [Intel-wired-lan] " Simon Horman
2023-11-24 11:03 ` Simon Horman
2023-11-29 22:31 ` [Intel-wired-lan] " Jesse Brandeburg
2023-11-29 22:31 ` Jesse Brandeburg
2023-11-30 16:26 ` [Intel-wired-lan] " Simon Horman
2023-11-30 16:26 ` Simon Horman
2023-12-05 6:41 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-05 6:41 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124110148.GJ50352@kernel.org \
--to=horms@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.